Title: [237919] trunk
Revision
237919
Author
tzaga...@apple.com
Date
2018-11-07 01:05:15 -0800 (Wed, 07 Nov 2018)

Log Message

REGRESSION(r237547): Test failures on 32-bit JSC since the JIT was disabled
https://bugs.webkit.org/show_bug.cgi?id=191184

Reviewed by Saam Barati.

JSTests:

Most tests were failing due to timeouts, since they are too slow to
run on CLoop. The exceptions are:

proxy-get-set-correct-receiver.js: Had to reduce the recursion depth not to overflow on CLoop
dont-crash-on-stack-overflow-when-parsing-builtin.js and
dont-crash-on-stack-overflow-when-parsing-default-constructor.js: had
to change the stack size since CLoop requires it to be page aligned.

* microbenchmarks/array-push-1.js:
* microbenchmarks/array-push-2.js:
* microbenchmarks/elidable-new-object-dag.js:
* microbenchmarks/elidable-new-object-roflcopter.js:
* microbenchmarks/elidable-new-object-tree.js:
* microbenchmarks/getter-richards.js:
* microbenchmarks/sinkable-new-object-dag.js:
* microbenchmarks/string-concat-long-convert.js:
* microbenchmarks/typed-array-get-set-by-val-profiling.js:
* slowMicrobenchmarks/array-push-3.js:
* slowMicrobenchmarks/large-map-iteration-with-additions.js:
* slowMicrobenchmarks/spread-small-array.js:
* slowMicrobenchmarks/undefined-property-access.js:
* stress/activation-sink-default-value-tdz-error.js:
* stress/activation-sink-default-value.js:
* stress/activation-sink-osrexit-default-value-tdz-error.js:
* stress/activation-sink-osrexit-default-value.js:
* stress/activation-sink-osrexit.js:
* stress/activation-sink.js:
* stress/allow-math-ic-b3-code-duplication.js:
* stress/array-push-multiple-int32.js:
* stress/arrowfunction-activation-sink-osrexit-default-value-tdz-error.js:
* stress/arrowfunction-lexical-this-activation-sink-osrexit.js:
* stress/arrowfunction-lexical-this-activation-sink.js:
* stress/dont-crash-on-stack-overflow-when-parsing-builtin.js:
* stress/dont-crash-on-stack-overflow-when-parsing-default-constructor.js:
* stress/elide-new-object-dag-then-exit.js:
* stress/materialize-regexp-cyclic.js:
* stress/new-regex-inline.js:
* stress/op_add.js:
* stress/op_bitand.js:
* stress/op_bitor.js:
* stress/op_bitxor.js:
* stress/op_div-ConstVar.js:
* stress/op_div-VarConst.js:
* stress/op_div-VarVar.js:
* stress/op_lshift-ConstVar.js:
* stress/op_lshift-VarConst.js:
* stress/op_lshift-VarVar.js:
* stress/op_mod-ConstVar.js:
* stress/op_mod-VarConst.js:
* stress/op_mod-VarVar.js:
* stress/op_mul-ConstVar.js:
* stress/op_mul-VarConst.js:
* stress/op_mul-VarVar.js:
* stress/op_rshift-ConstVar.js:
* stress/op_rshift-VarConst.js:
* stress/op_rshift-VarVar.js:
* stress/op_sub-ConstVar.js:
* stress/op_sub-VarConst.js:
* stress/op_sub-VarVar.js:
* stress/op_urshift-ConstVar.js:
* stress/op_urshift-VarConst.js:
* stress/op_urshift-VarVar.js:
* stress/proxy-get-set-correct-receiver.js:
* stress/regress-179562.js:
* stress/rest-parameter-many-arguments.js:
* stress/sampling-profiler-richards.js:
* stress/splay-flash-access-1ms.js:
* stress/tailCallForwardArguments.js:
* stress/typed-array-get-by-val-profiling.js:
* typeProfiler/getter-richards.js:

PerformanceTests:

Skip test when the JIT is disabled, it takes too long to run on CLoop.

* JetStream/cdjs/main.js:

Source/_javascript_Core:

Fix API test on CLoop: we can only disable the LLInt when the JIT is enabled.

* API/tests/PingPongStackOverflowTest.cpp:
(testPingPongStackOverflow):

LayoutTests:

Skip test when the JIT is disabled since it's too slow to run on CLoop.

* js/script-tests/regress-139548.js:

Modified Paths

Diff

Modified: trunk/JSTests/ChangeLog (237918 => 237919)


--- trunk/JSTests/ChangeLog	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/ChangeLog	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,81 @@
+2018-11-07  Tadeu Zagallo  <tzaga...@apple.com>
+
+        REGRESSION(r237547): Test failures on 32-bit JSC since the JIT was disabled
+        https://bugs.webkit.org/show_bug.cgi?id=191184
+
+        Reviewed by Saam Barati.
+
+        Most tests were failing due to timeouts, since they are too slow to
+        run on CLoop. The exceptions are:
+
+        proxy-get-set-correct-receiver.js: Had to reduce the recursion depth not to overflow on CLoop
+        dont-crash-on-stack-overflow-when-parsing-builtin.js and
+        dont-crash-on-stack-overflow-when-parsing-default-constructor.js: had
+        to change the stack size since CLoop requires it to be page aligned.
+
+        * microbenchmarks/array-push-1.js:
+        * microbenchmarks/array-push-2.js:
+        * microbenchmarks/elidable-new-object-dag.js:
+        * microbenchmarks/elidable-new-object-roflcopter.js:
+        * microbenchmarks/elidable-new-object-tree.js:
+        * microbenchmarks/getter-richards.js:
+        * microbenchmarks/sinkable-new-object-dag.js:
+        * microbenchmarks/string-concat-long-convert.js:
+        * microbenchmarks/typed-array-get-set-by-val-profiling.js:
+        * slowMicrobenchmarks/array-push-3.js:
+        * slowMicrobenchmarks/large-map-iteration-with-additions.js:
+        * slowMicrobenchmarks/spread-small-array.js:
+        * slowMicrobenchmarks/undefined-property-access.js:
+        * stress/activation-sink-default-value-tdz-error.js:
+        * stress/activation-sink-default-value.js:
+        * stress/activation-sink-osrexit-default-value-tdz-error.js:
+        * stress/activation-sink-osrexit-default-value.js:
+        * stress/activation-sink-osrexit.js:
+        * stress/activation-sink.js:
+        * stress/allow-math-ic-b3-code-duplication.js:
+        * stress/array-push-multiple-int32.js:
+        * stress/arrowfunction-activation-sink-osrexit-default-value-tdz-error.js:
+        * stress/arrowfunction-lexical-this-activation-sink-osrexit.js:
+        * stress/arrowfunction-lexical-this-activation-sink.js:
+        * stress/dont-crash-on-stack-overflow-when-parsing-builtin.js:
+        * stress/dont-crash-on-stack-overflow-when-parsing-default-constructor.js:
+        * stress/elide-new-object-dag-then-exit.js:
+        * stress/materialize-regexp-cyclic.js:
+        * stress/new-regex-inline.js:
+        * stress/op_add.js:
+        * stress/op_bitand.js:
+        * stress/op_bitor.js:
+        * stress/op_bitxor.js:
+        * stress/op_div-ConstVar.js:
+        * stress/op_div-VarConst.js:
+        * stress/op_div-VarVar.js:
+        * stress/op_lshift-ConstVar.js:
+        * stress/op_lshift-VarConst.js:
+        * stress/op_lshift-VarVar.js:
+        * stress/op_mod-ConstVar.js:
+        * stress/op_mod-VarConst.js:
+        * stress/op_mod-VarVar.js:
+        * stress/op_mul-ConstVar.js:
+        * stress/op_mul-VarConst.js:
+        * stress/op_mul-VarVar.js:
+        * stress/op_rshift-ConstVar.js:
+        * stress/op_rshift-VarConst.js:
+        * stress/op_rshift-VarVar.js:
+        * stress/op_sub-ConstVar.js:
+        * stress/op_sub-VarConst.js:
+        * stress/op_sub-VarVar.js:
+        * stress/op_urshift-ConstVar.js:
+        * stress/op_urshift-VarConst.js:
+        * stress/op_urshift-VarVar.js:
+        * stress/proxy-get-set-correct-receiver.js:
+        * stress/regress-179562.js:
+        * stress/rest-parameter-many-arguments.js:
+        * stress/sampling-profiler-richards.js:
+        * stress/splay-flash-access-1ms.js:
+        * stress/tailCallForwardArguments.js:
+        * stress/typed-array-get-by-val-profiling.js:
+        * typeProfiler/getter-richards.js:
+
 2018-11-06  Michael Saboff  <msab...@apple.com>
 
         Multiple stress/regexp-compile-oom.js tests are failing on High Sierra Debug and Release JSC testers.

Modified: trunk/JSTests/microbenchmarks/array-push-1.js (237918 => 237919)


--- trunk/JSTests/microbenchmarks/array-push-1.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/microbenchmarks/array-push-1.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 function arrayPush1() {
   var ret = [1];
   ret.push(1);

Modified: trunk/JSTests/microbenchmarks/array-push-2.js (237918 => 237919)


--- trunk/JSTests/microbenchmarks/array-push-2.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/microbenchmarks/array-push-2.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 function arrayPush2() {
   var ret = [1];
   ret.push(1, 2);

Modified: trunk/JSTests/microbenchmarks/elidable-new-object-dag.js (237918 => 237919)


--- trunk/JSTests/microbenchmarks/elidable-new-object-dag.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/microbenchmarks/elidable-new-object-dag.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 function sumOfArithSeries(limit) {
     return limit * (limit + 1) / 2;
 }

Modified: trunk/JSTests/microbenchmarks/elidable-new-object-roflcopter.js (237918 => 237919)


--- trunk/JSTests/microbenchmarks/elidable-new-object-roflcopter.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/microbenchmarks/elidable-new-object-roflcopter.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 function sumOfArithSeries(limit) {
     return limit * (limit + 1) / 2;
 }

Modified: trunk/JSTests/microbenchmarks/elidable-new-object-tree.js (237918 => 237919)


--- trunk/JSTests/microbenchmarks/elidable-new-object-tree.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/microbenchmarks/elidable-new-object-tree.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 function sumOfArithSeries(limit) {
     return limit * (limit + 1) / 2;
 }

Modified: trunk/JSTests/microbenchmarks/getter-richards.js (237918 => 237919)


--- trunk/JSTests/microbenchmarks/getter-richards.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/microbenchmarks/getter-richards.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,4 @@
-// FIXME: unskip when this is solved
-// https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "mips" or $architecture == "arm"
+//@ skip if not $jitTests
 //@ defaultQuickRun
 
 // Copyright 2006-2008 the V8 project authors. All rights reserved.

Modified: trunk/JSTests/microbenchmarks/sinkable-new-object-dag.js (237918 => 237919)


--- trunk/JSTests/microbenchmarks/sinkable-new-object-dag.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/microbenchmarks/sinkable-new-object-dag.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 function sumOfArithSeries(limit) {
     return limit * (limit + 1) / 2;
 }

Modified: trunk/JSTests/microbenchmarks/string-concat-long-convert.js (237918 => 237919)


--- trunk/JSTests/microbenchmarks/string-concat-long-convert.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/microbenchmarks/string-concat-long-convert.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 function test(a, b, c, d, e)
 {
     return a.concat(b, c, d, e);

Modified: trunk/JSTests/microbenchmarks/typed-array-get-set-by-val-profiling.js (237918 => 237919)


--- trunk/JSTests/microbenchmarks/typed-array-get-set-by-val-profiling.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/microbenchmarks/typed-array-get-set-by-val-profiling.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 // The type of arrayObject is polymorphic, but the access we do on it are not.
 function nonPolymorphicUint8ClampedArraySetter(arrayObject, isTypedArray) {
     if (isTypedArray) {

Modified: trunk/JSTests/slowMicrobenchmarks/array-push-3.js (237918 => 237919)


--- trunk/JSTests/slowMicrobenchmarks/array-push-3.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/slowMicrobenchmarks/array-push-3.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 function arrayPush3() {
   var ret = [1];
   ret.push(1, 2, 3);

Modified: trunk/JSTests/slowMicrobenchmarks/large-map-iteration-with-additions.js (237918 => 237919)


--- trunk/JSTests/slowMicrobenchmarks/large-map-iteration-with-additions.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/slowMicrobenchmarks/large-map-iteration-with-additions.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 let counter = 0;
 function bar(map) {
     for (let [key, value] of map) {

Modified: trunk/JSTests/slowMicrobenchmarks/spread-small-array.js (237918 => 237919)


--- trunk/JSTests/slowMicrobenchmarks/spread-small-array.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/slowMicrobenchmarks/spread-small-array.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 function foo(arg) {
     return [...arg];
 }

Modified: trunk/JSTests/slowMicrobenchmarks/undefined-property-access.js (237918 => 237919)


--- trunk/JSTests/slowMicrobenchmarks/undefined-property-access.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/slowMicrobenchmarks/undefined-property-access.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 var someGlobal;
 
 // This is a simple speed test. It should go fast.

Modified: trunk/JSTests/stress/activation-sink-default-value-tdz-error.js (237918 => 237919)


--- trunk/JSTests/stress/activation-sink-default-value-tdz-error.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/activation-sink-default-value-tdz-error.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,4 +1,5 @@
-//@ skip if $buildType == "debug"
+//@ skip if $buildType == "debug" or $architecture == "x86"
+
 "use strict";
 
 var n = 10000000;

Modified: trunk/JSTests/stress/activation-sink-default-value.js (237918 => 237919)


--- trunk/JSTests/stress/activation-sink-default-value.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/activation-sink-default-value.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 var n = 10000000;
 
 function bar(f) { f(10); }

Modified: trunk/JSTests/stress/activation-sink-osrexit-default-value-tdz-error.js (237918 => 237919)


--- trunk/JSTests/stress/activation-sink-osrexit-default-value-tdz-error.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/activation-sink-osrexit-default-value-tdz-error.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 "use strict";
 
 var n = 10000000;

Modified: trunk/JSTests/stress/activation-sink-osrexit-default-value.js (237918 => 237919)


--- trunk/JSTests/stress/activation-sink-osrexit-default-value.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/activation-sink-osrexit-default-value.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 var n = 10000000;
 
 function bar(set) { 

Modified: trunk/JSTests/stress/activation-sink-osrexit.js (237918 => 237919)


--- trunk/JSTests/stress/activation-sink-osrexit.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/activation-sink-osrexit.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 var n = 10000000;
 
 function bar() { }

Modified: trunk/JSTests/stress/activation-sink.js (237918 => 237919)


--- trunk/JSTests/stress/activation-sink.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/activation-sink.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 var n = 10000000;
 
 function bar(f) { f(10); }

Modified: trunk/JSTests/stress/allow-math-ic-b3-code-duplication.js (237918 => 237919)


--- trunk/JSTests/stress/allow-math-ic-b3-code-duplication.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/allow-math-ic-b3-code-duplication.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 function test1() {
     var o1;
     for (let i = 0; i < 1000000; ++i) {

Modified: trunk/JSTests/stress/array-push-multiple-int32.js (237918 => 237919)


--- trunk/JSTests/stress/array-push-multiple-int32.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/array-push-multiple-int32.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 function shouldBe(actual, expected)
 {
     if (actual !== expected)

Modified: trunk/JSTests/stress/arrowfunction-activation-sink-osrexit-default-value-tdz-error.js (237918 => 237919)


--- trunk/JSTests/stress/arrowfunction-activation-sink-osrexit-default-value-tdz-error.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/arrowfunction-activation-sink-osrexit-default-value-tdz-error.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 "use strict";
 
 var n = 1000000;

Modified: trunk/JSTests/stress/arrowfunction-lexical-this-activation-sink-osrexit.js (237918 => 237919)


--- trunk/JSTests/stress/arrowfunction-lexical-this-activation-sink-osrexit.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/arrowfunction-lexical-this-activation-sink-osrexit.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 var n = 10000000;
 
 var newContext = {

Modified: trunk/JSTests/stress/arrowfunction-lexical-this-activation-sink.js (237918 => 237919)


--- trunk/JSTests/stress/arrowfunction-lexical-this-activation-sink.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/arrowfunction-lexical-this-activation-sink.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 var n = 10000000;
 
 var newContext = {

Modified: trunk/JSTests/stress/dont-crash-on-stack-overflow-when-parsing-builtin.js (237918 => 237919)


--- trunk/JSTests/stress/dont-crash-on-stack-overflow-when-parsing-builtin.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/dont-crash-on-stack-overflow-when-parsing-builtin.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,4 +1,4 @@
-//@ runDefault("--softReservedZoneSize=16384", "--reservedZoneSize=0", "--useJIT=0", "--validateBytecode=1", "--maxPerThreadStackUsage=500000")
+//@ runDefault("--softReservedZoneSize=16384", "--reservedZoneSize=0", "--useJIT=0", "--validateBytecode=1", "--maxPerThreadStackUsage=499712")
 
 function f() {
     try {

Modified: trunk/JSTests/stress/dont-crash-on-stack-overflow-when-parsing-default-constructor.js (237918 => 237919)


--- trunk/JSTests/stress/dont-crash-on-stack-overflow-when-parsing-default-constructor.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/dont-crash-on-stack-overflow-when-parsing-default-constructor.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,4 +1,4 @@
-//@ runDefault("--softReservedZoneSize=16384", "--reservedZoneSize=0", "--useJIT=0", "--validateBytecode=1", "--maxPerThreadStackUsage=500000")
+//@ runDefault("--softReservedZoneSize=16384", "--reservedZoneSize=0", "--useJIT=0", "--validateBytecode=1", "--maxPerThreadStackUsage=499712")
 
 function runNearStackLimit(f) {
     function t() {

Modified: trunk/JSTests/stress/elide-new-object-dag-then-exit.js (237918 => 237919)


--- trunk/JSTests/stress/elide-new-object-dag-then-exit.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/elide-new-object-dag-then-exit.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 function sumOfArithSeries(limit) {
     return limit * (limit + 1) / 2;
 }

Modified: trunk/JSTests/stress/materialize-regexp-cyclic.js (237918 => 237919)


--- trunk/JSTests/stress/materialize-regexp-cyclic.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/materialize-regexp-cyclic.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ slow!
+
 function shouldBe(actual, expected)
 {
     if (actual !== expected)

Modified: trunk/JSTests/stress/new-regex-inline.js (237918 => 237919)


--- trunk/JSTests/stress/new-regex-inline.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/new-regex-inline.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 function assert(a) {
     if (!a)
         throw Error("bad assertion");

Modified: trunk/JSTests/stress/op_add.js (237918 => 237919)


--- trunk/JSTests/stress/op_add.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_add.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_bitand.js (237918 => 237919)


--- trunk/JSTests/stress/op_bitand.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_bitand.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_bitor.js (237918 => 237919)


--- trunk/JSTests/stress/op_bitor.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_bitor.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_bitxor.js (237918 => 237919)


--- trunk/JSTests/stress/op_bitxor.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_bitxor.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_div-ConstVar.js (237918 => 237919)


--- trunk/JSTests/stress/op_div-ConstVar.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_div-ConstVar.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,4 @@
+//@ skip if $architecture == "x86"
 //@ runFTLNoCJIT("--timeoutMultiplier=2.0")
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_div-VarConst.js (237918 => 237919)


--- trunk/JSTests/stress/op_div-VarConst.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_div-VarConst.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,4 @@
+//@ skip if $architecture == "x86"
 //@ runFTLNoCJIT("--timeoutMultiplier=2.0")
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_div-VarVar.js (237918 => 237919)


--- trunk/JSTests/stress/op_div-VarVar.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_div-VarVar.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,4 @@
+//@ skip if $architecture == "x86"
 //@ runFTLNoCJIT("--timeoutMultiplier=2.0")
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_lshift-ConstVar.js (237918 => 237919)


--- trunk/JSTests/stress/op_lshift-ConstVar.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_lshift-ConstVar.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_lshift-VarConst.js (237918 => 237919)


--- trunk/JSTests/stress/op_lshift-VarConst.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_lshift-VarConst.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_lshift-VarVar.js (237918 => 237919)


--- trunk/JSTests/stress/op_lshift-VarVar.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_lshift-VarVar.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_mod-ConstVar.js (237918 => 237919)


--- trunk/JSTests/stress/op_mod-ConstVar.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_mod-ConstVar.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT("--timeoutMultiplier=1.5")
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_mod-VarConst.js (237918 => 237919)


--- trunk/JSTests/stress/op_mod-VarConst.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_mod-VarConst.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT("--timeoutMultiplier=1.5")
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_mod-VarVar.js (237918 => 237919)


--- trunk/JSTests/stress/op_mod-VarVar.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_mod-VarVar.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT("--timeoutMultiplier=1.5")
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_mul-ConstVar.js (237918 => 237919)


--- trunk/JSTests/stress/op_mul-ConstVar.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_mul-ConstVar.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_mul-VarConst.js (237918 => 237919)


--- trunk/JSTests/stress/op_mul-VarConst.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_mul-VarConst.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_mul-VarVar.js (237918 => 237919)


--- trunk/JSTests/stress/op_mul-VarVar.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_mul-VarVar.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_rshift-ConstVar.js (237918 => 237919)


--- trunk/JSTests/stress/op_rshift-ConstVar.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_rshift-ConstVar.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_rshift-VarConst.js (237918 => 237919)


--- trunk/JSTests/stress/op_rshift-VarConst.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_rshift-VarConst.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_rshift-VarVar.js (237918 => 237919)


--- trunk/JSTests/stress/op_rshift-VarVar.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_rshift-VarVar.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_sub-ConstVar.js (237918 => 237919)


--- trunk/JSTests/stress/op_sub-ConstVar.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_sub-ConstVar.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_sub-VarConst.js (237918 => 237919)


--- trunk/JSTests/stress/op_sub-VarConst.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_sub-VarConst.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_sub-VarVar.js (237918 => 237919)


--- trunk/JSTests/stress/op_sub-VarVar.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_sub-VarVar.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_urshift-ConstVar.js (237918 => 237919)


--- trunk/JSTests/stress/op_urshift-ConstVar.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_urshift-ConstVar.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_urshift-VarConst.js (237918 => 237919)


--- trunk/JSTests/stress/op_urshift-VarConst.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_urshift-VarConst.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_urshift-VarVar.js (237918 => 237919)


--- trunk/JSTests/stress/op_urshift-VarVar.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/op_urshift-VarVar.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,6 @@
 // FIXME: unskip when this is solved
 // https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "arm"
+//@ skip if $architecture == "arm" or $architecture == "x86"
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/proxy-get-set-correct-receiver.js (237918 => 237919)


--- trunk/JSTests/stress/proxy-get-set-correct-receiver.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/proxy-get-set-correct-receiver.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -80,7 +80,7 @@
     let callCount = 0;
     let handler = {
         get(target, prop, receiver) {
-            if (callCount === 200)
+            if (callCount === 100)
                 assert(target === t);
             ++callCount;
             assert(receiver === proxy);
@@ -89,10 +89,10 @@
         }
     };
     let proxy = new Proxy(t, handler);
-    for (let i = 0; i < 200; ++i)
+    for (let i = 0; i < 100; ++i)
         proxy = new Proxy(proxy, handler);
     proxy.prop
-    assert(callCount === 201);
+    assert(callCount === 101);
 }, 10);
 
 test(function() {
@@ -100,7 +100,7 @@
     let callCount = 0;
     let handler = {
         set(target, prop, value, receiver) {
-            if (callCount === 200)
+            if (callCount === 100)
                 assert(target === t);
             ++callCount;
             assert(receiver === proxy);
@@ -110,8 +110,8 @@
         }
     };
     let proxy = new Proxy(t, handler);
-    for (let i = 0; i < 200; ++i)
+    for (let i = 0; i < 100; ++i)
         proxy = new Proxy(proxy, handler);
     proxy.prop = 20;
-    assert(callCount === 201);
+    assert(callCount === 101);
 }, 10);

Modified: trunk/JSTests/stress/regress-179562.js (237918 => 237919)


--- trunk/JSTests/stress/regress-179562.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/regress-179562.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,4 +1,4 @@
-//@ runFTLNoCJIT("--maxPerThreadStackUsage=400000")
+//@ runFTLNoCJIT("--maxPerThreadStackUsage=400000") if $jitTests
 
 function runNearStackLimit(f) {
     function t() {

Modified: trunk/JSTests/stress/rest-parameter-many-arguments.js (237918 => 237919)


--- trunk/JSTests/stress/rest-parameter-many-arguments.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/rest-parameter-many-arguments.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,4 @@
+//@ skip if $architecture == "x86"
 //@ if $architecture == "x86" then defaultSpotCheckNoMaximalFlush else defaultRun end
 
 function assert(b) {

Modified: trunk/JSTests/stress/sampling-profiler-richards.js (237918 => 237919)


--- trunk/JSTests/stress/sampling-profiler-richards.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/sampling-profiler-richards.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,7 @@
 // [JSC] [Armv7] stress/sampling-profiler-richards.js crashes
 // https://bugs.webkit.org/show_bug.cgi?id=190426
 //@ skip if $architecture == "arm" and $hostOS == "linux"
+//@ skip if $architecture == "x86"
 //@ runDefault("--collectContinuously=1", "--useSamplingProfiler=1", "--collectSamplingProfilerDataForJSCShell=1")
 
 "use strict";

Modified: trunk/JSTests/stress/splay-flash-access-1ms.js (237918 => 237919)


--- trunk/JSTests/stress/splay-flash-access-1ms.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/splay-flash-access-1ms.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,4 +1,5 @@
 //@ skip if $memoryLimited
+//@ skip if $architecture == "x86"
 //@ runNoisyTestDefault
 //@ runNoisyTestNoCJIT
 

Modified: trunk/JSTests/stress/tailCallForwardArguments.js (237918 => 237919)


--- trunk/JSTests/stress/tailCallForwardArguments.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/tailCallForwardArguments.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ skip if $architecture == "x86"
+
 var createBuiltin = $vm.createBuiltin;
 
 // This is pretty bad but I need a private name.

Modified: trunk/JSTests/stress/typed-array-get-by-val-profiling.js (237918 => 237919)


--- trunk/JSTests/stress/typed-array-get-by-val-profiling.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/stress/typed-array-get-by-val-profiling.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,5 @@
+//@ slow!
+
 function testArray(arrayType)
 {
     var testCode =

Modified: trunk/JSTests/typeProfiler/getter-richards.js (237918 => 237919)


--- trunk/JSTests/typeProfiler/getter-richards.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/JSTests/typeProfiler/getter-richards.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,4 +1,4 @@
-//@ if $buildType == "debug" or $architecture =~ /arm|mips/ then skip else runTypeProfiler end
+//@ if $buildType == "debug" or not $jitTests then skip else runTypeProfiler end
 
 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Copyright 2014 Apple Inc.

Modified: trunk/LayoutTests/ChangeLog (237918 => 237919)


--- trunk/LayoutTests/ChangeLog	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/LayoutTests/ChangeLog	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,14 @@
+2018-11-07  Tadeu Zagallo  <tzaga...@apple.com>
+
+        REGRESSION(r237547): Test failures on 32-bit JSC since the JIT was disabled
+        https://bugs.webkit.org/show_bug.cgi?id=191184
+
+        Reviewed by Saam Barati.
+
+        Skip test when the JIT is disabled since it's too slow to run on CLoop.
+
+        * js/script-tests/regress-139548.js:
+
 2018-11-06  Youenn Fablet  <you...@apple.com>
 
         Reenable imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-ontrack.https.html

Modified: trunk/LayoutTests/js/script-tests/regress-139548.js (237918 => 237919)


--- trunk/LayoutTests/js/script-tests/regress-139548.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/LayoutTests/js/script-tests/regress-139548.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,6 +1,4 @@
-// FIXME: unskip when this is solved
-// https://bugs.webkit.org/show_bug.cgi?id=191163
-//@ skip if $architecture == "mips" or $architecture == "arm"
+//@ skip if not $jitTests
 //@ slow!
 //@ noEagerNoNoLLIntTestsRunLayoutTest
 

Modified: trunk/PerformanceTests/ChangeLog (237918 => 237919)


--- trunk/PerformanceTests/ChangeLog	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/PerformanceTests/ChangeLog	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,14 @@
+2018-11-07  Tadeu Zagallo  <tzaga...@apple.com>
+
+        REGRESSION(r237547): Test failures on 32-bit JSC since the JIT was disabled
+        https://bugs.webkit.org/show_bug.cgi?id=191184
+
+        Reviewed by Saam Barati.
+
+        Skip test when the JIT is disabled, it takes too long to run on CLoop.
+
+        * JetStream/cdjs/main.js:
+
 2018-11-05  Myles C. Maxfield  <mmaxfi...@apple.com>
 
         Cache glyph paths and share underline skipping code between all the ports

Modified: trunk/PerformanceTests/JetStream/cdjs/main.js (237918 => 237919)


--- trunk/PerformanceTests/JetStream/cdjs/main.js	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/PerformanceTests/JetStream/cdjs/main.js	2018-11-07 09:05:15 UTC (rev 237919)
@@ -25,6 +25,7 @@
 
 // This is run as a JSC stress test. Let the harness know that this is a slow test.
 //@ slow!
+//@ skip if $architecture == "x86"
 
 load("constants.js");
 load("util.js");

Modified: trunk/Source/_javascript_Core/API/tests/PingPongStackOverflowTest.cpp (237918 => 237919)


--- trunk/Source/_javascript_Core/API/tests/PingPongStackOverflowTest.cpp	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/Source/_javascript_Core/API/tests/PingPongStackOverflowTest.cpp	2018-11-07 09:05:15 UTC (rev 237919)
@@ -127,7 +127,7 @@
 
     Options::softReservedZoneSize() = 128 * KB;
     Options::reservedZoneSize() = 64 * KB;
-#if ENABLE(C_LOOP)
+#if ENABLE(JIT)
     // Normally, we want to disable the LLINT to force the use of JITted code which is necessary for
     // reproducing the regression in https://bugs.webkit.org/show_bug.cgi?id=148749. However, we only
     // want to do this if the LLINT isn't the only available execution engine.

Modified: trunk/Source/_javascript_Core/ChangeLog (237918 => 237919)


--- trunk/Source/_javascript_Core/ChangeLog	2018-11-07 07:43:22 UTC (rev 237918)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-11-07 09:05:15 UTC (rev 237919)
@@ -1,3 +1,15 @@
+2018-11-07  Tadeu Zagallo  <tzaga...@apple.com>
+
+        REGRESSION(r237547): Test failures on 32-bit JSC since the JIT was disabled
+        https://bugs.webkit.org/show_bug.cgi?id=191184
+
+        Reviewed by Saam Barati.
+
+        Fix API test on CLoop: we can only disable the LLInt when the JIT is enabled.
+
+        * API/tests/PingPongStackOverflowTest.cpp:
+        (testPingPongStackOverflow):
+
 2018-11-06  Justin Fan  <justin_...@apple.com>
 
         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to