Title: [237970] trunk/Source/ThirdParty/libwebrtc
Revision
237970
Author
you...@apple.com
Date
2018-11-07 17:34:31 -0800 (Wed, 07 Nov 2018)

Log Message

webrtc/datachannel/basic-tcp.html will crash with an invalid crash
https://bugs.webkit.org/show_bug.cgi?id=178285
<rdar://problem/34985374>

Reviewed by Eric Carlson.

Reintroduce change made to libwebrtc and erroneously removed when refreshing libwebrtc.

* Source/webrtc/rtc_base/physicalsocketserver.cc:

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (237969 => 237970)


--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2018-11-08 01:31:39 UTC (rev 237969)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2018-11-08 01:34:31 UTC (rev 237970)
@@ -1,3 +1,15 @@
+2018-11-07  Youenn Fablet  <you...@apple.com>
+
+        webrtc/datachannel/basic-tcp.html will crash with an invalid crash
+        https://bugs.webkit.org/show_bug.cgi?id=178285
+        <rdar://problem/34985374>
+
+        Reviewed by Eric Carlson.
+
+        Reintroduce change made to libwebrtc and erroneously removed when refreshing libwebrtc.
+
+        * Source/webrtc/rtc_base/physicalsocketserver.cc:
+
 2018-10-30  Alexey Proskuryakov  <a...@apple.com>
 
         Clean up some obsolete MAX_ALLOWED macros

Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/physicalsocketserver.cc (237969 => 237970)


--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/physicalsocketserver.cc	2018-11-08 01:31:39 UTC (rev 237969)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/physicalsocketserver.cc	2018-11-08 01:34:31 UTC (rev 237970)
@@ -596,7 +596,7 @@
 #elif defined(WEBRTC_POSIX)
   fcntl(s_, F_SETFL, fcntl(s_, F_GETFL, 0) | O_NONBLOCK);
 #endif
-#if defined(WEBRTC_IOS)
+#if defined(WEBRTC_IOS) || (defined(WEBRTC_MAC) && defined(WEBRTC_WEBKIT_BUILD))
   // iOS may kill sockets when the app is moved to the background
   // (specifically, if the app doesn't use the "voip" UIBackgroundMode). When
   // we attempt to write to such a socket, SIGPIPE will be raised, which by
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to