Title: [238257] trunk/Source/WebCore
- Revision
- 238257
- Author
- jer.no...@apple.com
- Date
- 2018-11-15 15:51:30 -0800 (Thu, 15 Nov 2018)
Log Message
AVKit will set videoGravity to a nil string when building against iosmac
https://bugs.webkit.org/show_bug.cgi?id=191573
Reviewed by Dean Jackson.
Workaround AVKit behavior by treating nil videoGravity as the default,
which is AVLayerVideoGravityResizeAspect.
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerLayer setVideoGravity:]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (238256 => 238257)
--- trunk/Source/WebCore/ChangeLog 2018-11-15 23:18:58 UTC (rev 238256)
+++ trunk/Source/WebCore/ChangeLog 2018-11-15 23:51:30 UTC (rev 238257)
@@ -1,3 +1,16 @@
+2018-11-15 Jer Noble <jer.no...@apple.com>
+
+ AVKit will set videoGravity to a nil string when building against iosmac
+ https://bugs.webkit.org/show_bug.cgi?id=191573
+
+ Reviewed by Dean Jackson.
+
+ Workaround AVKit behavior by treating nil videoGravity as the default,
+ which is AVLayerVideoGravityResizeAspect.
+
+ * platform/ios/VideoFullscreenInterfaceAVKit.mm:
+ (-[WebAVPlayerLayer setVideoGravity:]):
+
2018-11-15 Brent Fulgham <bfulg...@apple.com>
[Win] Reduce the use of WKSI library calls: Font Handling
Modified: trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm (238256 => 238257)
--- trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2018-11-15 23:18:58 UTC (rev 238256)
+++ trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2018-11-15 23:51:30 UTC (rev 238257)
@@ -333,6 +333,12 @@
- (void)setVideoGravity:(NSString *)videoGravity
{
+#if PLATFORM(IOSMAC)
+ // FIXME<rdar://46011230>: remove this #if once this radar lands.
+ if (!videoGravity)
+ videoGravity = getAVLayerVideoGravityResizeAspect();
+#endif
+
_videoGravity = videoGravity;
if (![_avPlayerController delegate])
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
