Title: [238294] trunk/Source/WebKit
Revision
238294
Author
cdu...@apple.com
Date
2018-11-16 12:11:48 -0800 (Fri, 16 Nov 2018)

Log Message

Automatic process prewarming should be turned on if PSON is enabled via experimental features
https://bugs.webkit.org/show_bug.cgi?id=191761

Reviewed by Ryosuke Niwa.

m_isAutomaticProcessWarmingEnabledByClient is a std::optional and should not be initialized to
true / false until the client calls API to toggle the feature. When m_isAutomaticProcessWarmingEnabledByClient
is std::nullopt then m_processSwapsOnNavigationFromExperimentalFeatures controls automatic
process prewarming.

* UIProcess/API/APIProcessPoolConfiguration.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (238293 => 238294)


--- trunk/Source/WebKit/ChangeLog	2018-11-16 19:59:45 UTC (rev 238293)
+++ trunk/Source/WebKit/ChangeLog	2018-11-16 20:11:48 UTC (rev 238294)
@@ -1,3 +1,17 @@
+2018-11-16  Chris Dumez  <cdu...@apple.com>
+
+        Automatic process prewarming should be turned on if PSON is enabled via experimental features
+        https://bugs.webkit.org/show_bug.cgi?id=191761
+
+        Reviewed by Ryosuke Niwa.
+
+        m_isAutomaticProcessWarmingEnabledByClient is a std::optional and should not be initialized to
+        true / false until the client calls API to toggle the feature. When m_isAutomaticProcessWarmingEnabledByClient
+        is std::nullopt then m_processSwapsOnNavigationFromExperimentalFeatures controls automatic
+        process prewarming.
+
+        * UIProcess/API/APIProcessPoolConfiguration.h:
+
 2018-11-16  Alex Christensen  <achristen...@webkit.org>
 
         Add API to disable safe browsing checks

Modified: trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h (238293 => 238294)


--- trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h	2018-11-16 19:59:45 UTC (rev 238293)
+++ trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h	2018-11-16 20:11:48 UTC (rev 238294)
@@ -218,7 +218,7 @@
     bool m_processSwapsOnNavigationFromExperimentalFeatures { false };
     bool m_alwaysKeepAndReuseSwappedProcesses { false };
     bool m_processSwapsOnWindowOpenWithOpener { false };
-    std::optional<bool> m_isAutomaticProcessWarmingEnabledByClient { false };
+    std::optional<bool> m_isAutomaticProcessWarmingEnabledByClient;
     WTF::String m_customWebContentServiceBundleIdentifier;
 
 #if PLATFORM(IOS_FAMILY)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to