Title: [238518] trunk/Tools
Revision
238518
Author
aakash_j...@apple.com
Date
2018-11-26 13:44:27 -0800 (Mon, 26 Nov 2018)

Log Message

[ews-app] Set Foreign Keys in EWS Django app models
https://bugs.webkit.org/show_bug.cgi?id=191790

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/ews/models/builds.py: Set Foreign Key.
* BuildSlaveSupport/ews-app/ews/models/steps.py: Ditto.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/models/builds.py (238517 => 238518)


--- trunk/Tools/BuildSlaveSupport/ews-app/ews/models/builds.py	2018-11-26 21:39:46 UTC (rev 238517)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/models/builds.py	2018-11-26 21:44:27 UTC (rev 238518)
@@ -23,10 +23,11 @@
 from __future__ import unicode_literals
 
 from django.db import models
+from ews.models.patch import Patch
 
 
 class Builds(models.Model):
-    patchid = models.IntegerField()  # TODO: set foreign key
+    patch = models.ForeignKey(Patch, _on_delete_=models.CASCADE)
     buildid = models.IntegerField(primary_key=True)
     builderid = models.IntegerField()
     number = models.IntegerField()

Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/models/steps.py (238517 => 238518)


--- trunk/Tools/BuildSlaveSupport/ews-app/ews/models/steps.py	2018-11-26 21:39:46 UTC (rev 238517)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/models/steps.py	2018-11-26 21:44:27 UTC (rev 238518)
@@ -23,11 +23,12 @@
 from __future__ import unicode_literals
 
 from django.db import models
+from ews.models.builds import Builds
 
 
 class Steps(models.Model):
     stepid = models.IntegerField(primary_key=True)
-    buildid = models.IntegerField()  # TODO: set foreign key
+    build = models.ForeignKey(Builds, _on_delete_=models.CASCADE)
     result = models.IntegerField()
     state_string = models.TextField()
     started_at = models.IntegerField()
@@ -36,4 +37,4 @@
     modified = models.DateTimeField(auto_now=True)
 
     def __str__(self):
-        return str(self.buildid)
+        return str(self.stepid)

Modified: trunk/Tools/ChangeLog (238517 => 238518)


--- trunk/Tools/ChangeLog	2018-11-26 21:39:46 UTC (rev 238517)
+++ trunk/Tools/ChangeLog	2018-11-26 21:44:27 UTC (rev 238518)
@@ -1,5 +1,15 @@
 2018-11-26  Aakash Jain  <aakash_j...@apple.com>
 
+        [ews-app] Set Foreign Keys in EWS Django app models
+        https://bugs.webkit.org/show_bug.cgi?id=191790
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/models/builds.py: Set Foreign Key.
+        * BuildSlaveSupport/ews-app/ews/models/steps.py: Ditto.
+
+2018-11-26  Aakash Jain  <aakash_j...@apple.com>
+
         [ews-app] Do not store patch content in database
         https://bugs.webkit.org/show_bug.cgi?id=191788
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to