Title: [238594] trunk/Source/WebInspectorUI
Revision
238594
Author
nvasil...@apple.com
Date
2018-11-27 17:45:17 -0800 (Tue, 27 Nov 2018)

Log Message

Web Inspector: Experimental Computed panel is unreadable in Dark Mode
https://bugs.webkit.org/show_bug.cgi?id=192053

Reviewed by Matt Baker.

* UserInterface/Views/ComputedStyleDetailsPanel.css:
(@media (prefers-dark-interface)):
(.computed-with-traces .details-section.computed-style-properties:not(.collapsed) > :matches(.header, .content)):
* UserInterface/Views/ComputedStyleSection.css:
(.computed-style-section .computed-property-item.expanded):
(.computed-style-section .computed-property-item.expanded + .computed-property-item):
(@media (prefers-dark-interface)):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (238593 => 238594)


--- trunk/Source/WebInspectorUI/ChangeLog	2018-11-28 01:44:28 UTC (rev 238593)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-11-28 01:45:17 UTC (rev 238594)
@@ -1,5 +1,20 @@
 2018-11-27  Nikita Vasilyev  <nvasil...@apple.com>
 
+        Web Inspector: Experimental Computed panel is unreadable in Dark Mode
+        https://bugs.webkit.org/show_bug.cgi?id=192053
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/ComputedStyleDetailsPanel.css:
+        (@media (prefers-dark-interface)):
+        (.computed-with-traces .details-section.computed-style-properties:not(.collapsed) > :matches(.header, .content)):
+        * UserInterface/Views/ComputedStyleSection.css:
+        (.computed-style-section .computed-property-item.expanded):
+        (.computed-style-section .computed-property-item.expanded + .computed-property-item):
+        (@media (prefers-dark-interface)):
+
+2018-11-27  Nikita Vasilyev  <nvasil...@apple.com>
+
         Web Inspector: Computed panel: allow to expand properties to show list of overridden values
         https://bugs.webkit.org/show_bug.cgi?id=191984
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.css (238593 => 238594)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.css	2018-11-28 01:44:28 UTC (rev 238593)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.css	2018-11-28 01:45:17 UTC (rev 238594)
@@ -55,3 +55,9 @@
     width: var(--disclosure-button-size);
     height: var(--disclosure-button-size);
 }
+
+@media (prefers-dark-interface) {
+    .computed-with-traces .details-section.computed-style-properties:not(.collapsed) > :matches(.header, .content) {
+        background-color: var(--background-color);
+    }
+}

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.css (238593 => 238594)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.css	2018-11-28 01:44:28 UTC (rev 238593)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.css	2018-11-28 01:45:17 UTC (rev 238594)
@@ -42,12 +42,12 @@
 
 .computed-style-section .computed-property-item.expanded {
     padding-bottom: 2px;
-    background-color: var(--background-color);
-    border-top-color: hsla(0, 0%, 0%, 0.2);
+    background-color: var(--background-color-code);
+    border-top-color: var(--text-color-quaternary);
 }
 
 .computed-style-section .computed-property-item.expanded + .computed-property-item {
-    border-top-color: hsla(0, 0%, 0%, 0.2);
+    border-top-color: var(--text-color-quaternary);
 }
 
 .computed-style-section .computed-property-item .disclosure-button {
@@ -146,3 +146,9 @@
 .computed-style-properties.details-section > .content > .group {
     display: block;
 }
+
+@media (prefers-dark-interface) {
+    .computed-style-section .computed-property-item.expanded {
+        background-color: var(--background-color-code);
+    }
+}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to