Title: [238711] trunk/Source/WebInspectorUI
- Revision
- 238711
- Author
- [email protected]
- Date
- 2018-11-29 16:39:02 -0800 (Thu, 29 Nov 2018)
Log Message
Web Inspector: RTL: disclosure triangles should be flipped and aligned right
https://bugs.webkit.org/show_bug.cgi?id=192089
<rdar://problem/46316753>
Reviewed by Devin Rousso.
* UserInterface/Views/ComputedStyleSection.css:
(.computed-style-section .computed-property-item .disclosure-button):
(body[dir=rtl] .computed-style-section .computed-property-item .disclosure-button):
* UserInterface/Views/ConsoleMessageView.css:
(.console-message.expandable .console-top-level-message::before):
(body[dir=rtl] .console-message.expandable .console-top-level-message::before):
* UserInterface/Views/ErrorObjectView.css:
(.error-object > .formatted-error::before):
(body[dir=rtl] .error-object > .formatted-error::before):
(.error-object .content):
* UserInterface/Views/LogContentView.css:
(.console-group-title::before):
(body[dir=ltr] .console-group-title::before):
(body[dir=rtl] .console-group-title::before):
* UserInterface/Views/ObjectTreeView.css:
(body[dir=rtl] .object-tree > :matches(.title, .object-preview)::before):
* UserInterface/Views/TypeTreeElement.css:
(body[dir=rtl] .item.type-tree-element.parent > .disclosure-button):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (238710 => 238711)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-11-30 00:38:29 UTC (rev 238710)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-11-30 00:39:02 UTC (rev 238711)
@@ -1,3 +1,35 @@
+2018-11-29 Matt Baker <[email protected]>
+
+ Web Inspector: RTL: disclosure triangles should be flipped and aligned right
+ https://bugs.webkit.org/show_bug.cgi?id=192089
+ <rdar://problem/46316753>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/ComputedStyleSection.css:
+ (.computed-style-section .computed-property-item .disclosure-button):
+ (body[dir=rtl] .computed-style-section .computed-property-item .disclosure-button):
+
+ * UserInterface/Views/ConsoleMessageView.css:
+ (.console-message.expandable .console-top-level-message::before):
+ (body[dir=rtl] .console-message.expandable .console-top-level-message::before):
+
+ * UserInterface/Views/ErrorObjectView.css:
+ (.error-object > .formatted-error::before):
+ (body[dir=rtl] .error-object > .formatted-error::before):
+ (.error-object .content):
+
+ * UserInterface/Views/LogContentView.css:
+ (.console-group-title::before):
+ (body[dir=ltr] .console-group-title::before):
+ (body[dir=rtl] .console-group-title::before):
+
+ * UserInterface/Views/ObjectTreeView.css:
+ (body[dir=rtl] .object-tree > :matches(.title, .object-preview)::before):
+
+ * UserInterface/Views/TypeTreeElement.css:
+ (body[dir=rtl] .item.type-tree-element.parent > .disclosure-button):
+
2018-11-28 Dean Jackson <[email protected]>
[ES Modules] Allow .mjs content when loaded from file://
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.css (238710 => 238711)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.css 2018-11-30 00:38:29 UTC (rev 238710)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.css 2018-11-30 00:39:02 UTC (rev 238711)
@@ -54,7 +54,7 @@
display: inline-block;
width: var(--disclosure-button-size);
height: var(--disclosure-button-size);
- margin-left: calc(-1 * var(--disclosure-button-size));
+ -webkit-margin-start: calc(-1 * var(--disclosure-button-size));
border: 0;
background-color: transparent;
background-image: url(../Images/DisclosureTriangles.svg#closed-normal);
@@ -64,6 +64,10 @@
-webkit-appearance: none;
}
+body[dir=rtl] .computed-style-section .computed-property-item .disclosure-button {
+ transform: scaleX(-1);
+}
+
.computed-style-section .computed-property-item .property-traces {
display: none;
width: 100%;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css (238710 => 238711)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css 2018-11-30 00:38:29 UTC (rev 238710)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css 2018-11-30 00:39:02 UTC (rev 238711)
@@ -76,7 +76,7 @@
vertical-align: baseline;
margin-bottom: -2px;
- margin-right: 2px;
+ -webkit-margin-end: 2px;
width: 13px;
height: 13px;
@@ -89,6 +89,10 @@
content: "";
}
+body[dir=rtl] .console-message.expandable .console-top-level-message::before {
+ transform: scaleX(-1);
+}
+
.console-message.expandable.expanded .console-top-level-message::before {
background-image: url(../Images/DisclosureTriangles.svg#open-normal);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.css (238710 => 238711)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.css 2018-11-30 00:38:29 UTC (rev 238710)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.css 2018-11-30 00:39:02 UTC (rev 238711)
@@ -31,7 +31,7 @@
display: inline-block;
vertical-align: baseline;
margin-bottom: -2px;
- margin-right: 2px;
+ -webkit-margin-end: 2px;
width: 13px;
height: 13px;
background-image: url(../Images/DisclosureTriangles.svg#closed-normal);
@@ -41,6 +41,10 @@
content: "";
}
+body[dir=rtl] .error-object > .formatted-error::before {
+ transform: scaleX(-1);
+}
+
.error-object.expanded > .formatted-error::before {
background-image: url(../Images/DisclosureTriangles.svg#open-normal);
}
@@ -58,5 +62,5 @@
}
.error-object .content {
- padding-left: 16px
+ -webkit-padding-start: 16px
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css (238710 => 238711)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css 2018-11-30 00:38:29 UTC (rev 238710)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css 2018-11-30 00:39:02 UTC (rev 238711)
@@ -160,11 +160,19 @@
background-image: url(../Images/DisclosureTriangles.svg#open-normal);
background-size: 13px 13px;
top: 4px;
- left: 4px;
width: 13px;
height: 13px;
}
+body[dir=ltr] .console-group-title::before {
+ left: 4px;
+}
+
+body[dir=rtl] .console-group-title::before {
+ transform: scaleX(-1);
+ right: 4px;
+}
+
.console-group.collapsed .console-group-title::before {
background-image: url(../Images/DisclosureTriangles.svg#closed-normal);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css (238710 => 238711)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css 2018-11-30 00:38:29 UTC (rev 238710)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css 2018-11-30 00:39:02 UTC (rev 238711)
@@ -49,6 +49,10 @@
content: "";
}
+body[dir=rtl] .object-tree > :matches(.title, .object-preview)::before {
+ transform: scaleX(-1);
+}
+
.object-tree:not(.lossless-preview) > :matches(.title, .object-preview) {
margin-left: 0;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css (238710 => 238711)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css 2018-11-30 00:38:29 UTC (rev 238710)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css 2018-11-30 00:39:02 UTC (rev 238711)
@@ -59,6 +59,10 @@
background-size: 13px 13px;
}
+body[dir=rtl] .item.type-tree-element.parent > .disclosure-button {
+ transform: scaleX(-1);
+}
+
.item.type-tree-element.parent.expanded > .disclosure-button {
background-image: url(../Images/DisclosureTriangles.svg#open-normal);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
