Title: [238762] trunk/Source/WebInspectorUI
- Revision
- 238762
- Author
- nvasil...@apple.com
- Date
- 2018-11-30 16:15:16 -0800 (Fri, 30 Nov 2018)
Log Message
Web Inspector: Jumping from Computed to Styles should select property
https://bugs.webkit.org/show_bug.cgi?id=192198
Reviewed by Devin Rousso.
* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
(.spreadsheet-style-declaration-editor .property.highlighted): Deleted.
(@keyframes style-property-highlight): Deleted.
* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.highlightProperty):
Remove unnecessary `__propertyView` property.
* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype.detached):
(WI.SpreadsheetStyleProperty.prototype.highlight): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (238761 => 238762)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-12-01 00:14:02 UTC (rev 238761)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-12-01 00:15:16 UTC (rev 238762)
@@ -1,3 +1,21 @@
+2018-11-30 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: Jumping from Computed to Styles should select property
+ https://bugs.webkit.org/show_bug.cgi?id=192198
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
+ (.spreadsheet-style-declaration-editor .property.highlighted): Deleted.
+ (@keyframes style-property-highlight): Deleted.
+ * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
+ (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.highlightProperty):
+ Remove unnecessary `__propertyView` property.
+
+ * UserInterface/Views/SpreadsheetStyleProperty.js:
+ (WI.SpreadsheetStyleProperty.prototype.detached):
+ (WI.SpreadsheetStyleProperty.prototype.highlight): Deleted.
+
2018-11-30 Matt Baker <mattba...@apple.com>
Web Inspector: REGRESSION(r238599): Multiple Selection: selecting a breakpoint will change the selection to it's parent on the first click
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css (238761 => 238762)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css 2018-12-01 00:14:02 UTC (rev 238761)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css 2018-12-01 00:15:16 UTC (rev 238762)
@@ -145,14 +145,6 @@
color: hsl(0, 0%, 50%) !important;
}
-.spreadsheet-style-declaration-editor .property.highlighted {
- animation: style-property-highlight 2s;
-}
-
-@keyframes style-property-highlight {
- from { background-color: yellow; }
-}
-
.spreadsheet-style-declaration-editor .property:not(.disabled) .token-link {
color: var(--syntax-highlight-link-color);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js (238761 => 238762)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js 2018-12-01 00:14:02 UTC (rev 238761)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js 2018-12-01 00:15:16 UTC (rev 238762)
@@ -290,15 +290,9 @@
return false;
};
- for (let cssProperty of this._style.properties) {
- if (propertiesMatch(cssProperty)) {
- let propertyView = cssProperty.__propertyView;
- if (propertyView) {
- propertyView.highlight();
-
- if (cssProperty.editable)
- propertyView.valueTextField.startEditing();
- }
+ for (let i = 0; i < this._propertyViews.length; ++i) {
+ if (propertiesMatch(this._propertyViews[i].property)) {
+ this.selectProperties(i, i);
return true;
}
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js (238761 => 238762)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js 2018-12-01 00:14:02 UTC (rev 238761)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js 2018-12-01 00:15:16 UTC (rev 238762)
@@ -43,11 +43,6 @@
this._nameTextField = null;
this._valueTextField = null;
- if (!this._readOnly) {
- // This is only needed to navigate from Computed to the corresponding property in the Styles panel.
- this._property.__propertyView = this;
- }
-
this._selected = false;
this._hasInvalidVariableValue = false;
@@ -99,8 +94,6 @@
detached()
{
- this._property.__propertyView = null;
-
if (this._nameTextField)
this._nameTextField.detached();
@@ -116,11 +109,6 @@
this._valueTextField.element.blur();
}
- highlight()
- {
- this._element.classList.add("highlighted");
- }
-
remove(replacement = null)
{
this.element.remove();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
