Modified: trunk/LayoutTests/ChangeLog (238854 => 238855)
--- trunk/LayoutTests/ChangeLog 2018-12-04 17:05:10 UTC (rev 238854)
+++ trunk/LayoutTests/ChangeLog 2018-12-04 17:17:19 UTC (rev 238855)
@@ -1,3 +1,16 @@
+2018-12-04 Ryan Haddad <ryanhad...@apple.com>
+
+ Unreviewed, rolling out r238840.
+
+ The layout test added with this change is frequently failing.
+
+ Reverted changeset:
+
+ "REGRESSION (r238090): position:fixed sidebar on
+ https://www.w3.org/TR/SVG2/coords.html does not stay fixed"
+ https://bugs.webkit.org/show_bug.cgi?id=192320
+ https://trac.webkit.org/changeset/238840
+
2018-12-04 Devin Rousso <drou...@apple.com>
Web Inspector: Audit: tests should support async operations
Deleted: trunk/LayoutTests/compositing/fixed-with-main-thread-scrolling-expected.html (238854 => 238855)
--- trunk/LayoutTests/compositing/fixed-with-main-thread-scrolling-expected.html 2018-12-04 17:05:10 UTC (rev 238854)
+++ trunk/LayoutTests/compositing/fixed-with-main-thread-scrolling-expected.html 2018-12-04 17:17:19 UTC (rev 238855)
@@ -1,36 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
- <style>
- body {
- height: 6000px;
- }
- .box {
- position: absolute;
- top: 5718px;
- left: 10px;
- width: 200px;
- height: 200px;
- background-color: green;
- }
-
- .fixed-background {
- margin-top: 300px;
- height: 200px;
- background-image: linear-gradient(white, silver);
- background-attachment: fixed;
- }
- </style>
-</head>
-<body>
-
-<div class="box"></div>
-
-<div class="fixed-background">
- I have a fixed background.
-</div>
-<script>
- window.scrollTo(0, 6000);
-</script>
-</body>
-</html>
Deleted: trunk/LayoutTests/compositing/fixed-with-main-thread-scrolling.html (238854 => 238855)
--- trunk/LayoutTests/compositing/fixed-with-main-thread-scrolling.html 2018-12-04 17:05:10 UTC (rev 238854)
+++ trunk/LayoutTests/compositing/fixed-with-main-thread-scrolling.html 2018-12-04 17:17:19 UTC (rev 238855)
@@ -1,60 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
- <style>
- body {
- height: 6000px;
- }
- .box {
- position: fixed;
- top: 10px;
- left: 10px;
- width: 200px;
- height: 200px;
- background-color: green;
- }
-
- .fixed-background {
- margin-top: 300px;
- height: 200px;
- background-image: linear-gradient(white, silver);
- background-attachment: fixed;
- }
- </style>
- <script>
- if (window.testRunner) {
- testRunner.waitUntilDone();
- }
-
- function scrollTest()
- {
- eventSender.mouseMoveTo(20, 20);
- eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -1, "began", "none");
- eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -100, "changed", "none");
- eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -100, "changed", "none");
- eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -1, "changed", "none");
- eventSender.mouseScrollByWithWheelAndMomentumPhases(0, 0, "ended", "none");
- eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -100, "none", "begin");
- eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -100, "none", "continue");
- eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -100, "none", "continue");
- eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -100, "none", "continue");
- eventSender.mouseScrollByWithWheelAndMomentumPhases(0, 0, "none", "end");
- testRunner.notifyDone();
- }
-
- window.addEventListener('load', () => {
- setTimeout(() => {
- scrollTest();
- }, 0)
- }, false);
- </script>
-</head>
-<body>
-
-<div class="box"></div>
-
-<div class="fixed-background">
- I have a fixed background.
-</div>
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (238854 => 238855)
--- trunk/Source/WebCore/ChangeLog 2018-12-04 17:05:10 UTC (rev 238854)
+++ trunk/Source/WebCore/ChangeLog 2018-12-04 17:17:19 UTC (rev 238855)
@@ -1,3 +1,16 @@
+2018-12-04 Ryan Haddad <ryanhad...@apple.com>
+
+ Unreviewed, rolling out r238840.
+
+ The layout test added with this change is frequently failing.
+
+ Reverted changeset:
+
+ "REGRESSION (r238090): position:fixed sidebar on
+ https://www.w3.org/TR/SVG2/coords.html does not stay fixed"
+ https://bugs.webkit.org/show_bug.cgi?id=192320
+ https://trac.webkit.org/changeset/238840
+
2018-12-04 Carlos Garcia Campos <cgar...@igalia.com>
[SOUP] Move URLSoup back to WebCore after r238771
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (238854 => 238855)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2018-12-04 17:05:10 UTC (rev 238854)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2018-12-04 17:17:19 UTC (rev 238855)
@@ -666,20 +666,9 @@
if (!m_compositing && (m_forceCompositingMode || (isMainFrameCompositor() && page().pageOverlayController().overlayCount())))
enableCompositingMode(true);
- bool isPageScroll = !updateRoot || updateRoot == &rootRenderLayer();
updateRoot = &rootRenderLayer();
if (updateType == CompositingUpdateType::OnScroll || updateType == CompositingUpdateType::OnCompositedScroll) {
- // We only get here if we didn't scroll on the scrolling thread, so this update needs to re-position viewport-constrained layers.
- if (m_renderView.settings().acceleratedCompositingForFixedPositionEnabled() && isPageScroll) {
- if (auto* viewportConstrainedObjects = m_renderView.frameView().viewportConstrainedObjects()) {
- for (auto* renderer : *viewportConstrainedObjects) {
- if (auto* layer = renderer->layer())
- layer->setNeedsCompositingGeometryUpdate();
- }
- }
- }
-
// Scrolling can affect overlap. FIXME: avoid for page scrolling.
updateRoot->setDescendantsNeedCompositingRequirementsTraversal();
}
