Diff
Modified: trunk/Source/WebCore/ChangeLog (239150 => 239151)
--- trunk/Source/WebCore/ChangeLog 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebCore/ChangeLog 2018-12-13 06:44:39 UTC (rev 239151)
@@ -1,3 +1,16 @@
+2018-12-12 Fujii Hironori <hironori.fu...@sony.com>
+
+ [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
+ https://bugs.webkit.org/show_bug.cgi?id=192618
+
+ Reviewed by Alex Christensen.
+
+ No new tests, no behavior changes.
+
+ * platform/win/PopupMenuWin.h:
+ * platform/win/WCDataObject.cpp:
+ * platform/win/WCDataObject.h:
+
2018-12-12 Simon Fraser <simon.fra...@apple.com>
REGRESSION (r238090): CAPCHA UI jumps to the wrong location
Modified: trunk/Source/WebCore/platform/win/PopupMenuWin.h (239150 => 239151)
--- trunk/Source/WebCore/platform/win/PopupMenuWin.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebCore/platform/win/PopupMenuWin.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -140,7 +140,7 @@
friend class AccessiblePopupMenu;
};
-class AccessiblePopupMenu : public IAccessible {
+class AccessiblePopupMenu final : public IAccessible {
public:
AccessiblePopupMenu(const PopupMenuWin&);
~AccessiblePopupMenu();
Modified: trunk/Source/WebCore/platform/win/WCDataObject.cpp (239150 => 239151)
--- trunk/Source/WebCore/platform/win/WCDataObject.cpp 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebCore/platform/win/WCDataObject.cpp 2018-12-13 06:44:39 UTC (rev 239151)
@@ -32,7 +32,7 @@
namespace WebCore {
-class WCEnumFormatEtc : public IEnumFORMATETC
+class WCEnumFormatEtc final : public IEnumFORMATETC
{
public:
WCEnumFormatEtc(const Vector<FORMATETC>& formats);
Modified: trunk/Source/WebCore/platform/win/WCDataObject.h (239150 => 239151)
--- trunk/Source/WebCore/platform/win/WCDataObject.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebCore/platform/win/WCDataObject.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -41,7 +41,7 @@
}
};
-class WCDataObject : public IDataObject {
+class WCDataObject final : public IDataObject {
public:
void CopyMedium(STGMEDIUM* pMedDest, STGMEDIUM* pMedSrc, FORMATETC* pFmtSrc);
Modified: trunk/Source/WebKitLegacy/win/COMEnumVariant.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/COMEnumVariant.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/COMEnumVariant.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -31,7 +31,7 @@
#include "COMVariantSetter.h"
template<typename ContainerType>
-class COMEnumVariant : public IEnumVARIANT {
+class COMEnumVariant final : public IEnumVARIANT {
WTF_MAKE_NONCOPYABLE(COMEnumVariant);
public:
static COMEnumVariant* adopt(ContainerType&);
Modified: trunk/Source/WebKitLegacy/win/COMPropertyBag.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/COMPropertyBag.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/COMPropertyBag.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -35,7 +35,7 @@
#include "COMVariantSetter.h"
template<typename ValueType, typename KeyType = typename WTF::String, typename HashType = typename WTF::StringHash>
-class COMPropertyBag : public IPropertyBag, public IPropertyBag2 {
+class COMPropertyBag final : public IPropertyBag, public IPropertyBag2 {
WTF_MAKE_NONCOPYABLE(COMPropertyBag);
public:
typedef HashMap<KeyType, ValueType, HashType> HashMapType;
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2018-12-13 06:44:39 UTC (rev 239151)
@@ -1,3 +1,70 @@
+2018-12-12 Fujii Hironori <hironori.fu...@sony.com>
+
+ [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
+ https://bugs.webkit.org/show_bug.cgi?id=192618
+
+ Reviewed by Alex Christensen.
+
+ Classes which implement COM interface usually doesn't need the
+ virtual destructor because it has Release() virtual method to
+ destruct itself.
+
+ Marked 'final' such classes to suppress clang-cl's compilation
+ warnings.
+
+ * COMEnumVariant.h:
+ * COMPropertyBag.h:
+ * DefaultDownloadDelegate.h:
+ * DefaultPolicyDelegate.h:
+ * MemoryStream.h:
+ * WebActionPropertyBag.h:
+ * WebApplicationCache.h:
+ * WebArchive.h:
+ * WebBackForwardList.h:
+ * WebCache.h:
+ * WebCoreStatistics.h:
+ * WebCoreSupport/WebEditorClient.cpp:
+ * WebCoreSupport/WebInspectorDelegate.h:
+ * WebDataSource.h:
+ * WebDatabaseManager.cpp:
+ * WebDatabaseManager.h:
+ * WebDownload.h:
+ * WebDropSource.h:
+ * WebElementPropertyBag.h:
+ * WebError.h:
+ * WebFrame.cpp:
+ * WebFrame.h:
+ * WebFramePolicyListener.h:
+ * WebGeolocationPolicyListener.h:
+ * WebGeolocationPosition.h:
+ * WebHTMLRepresentation.h:
+ * WebHistory.h:
+ * WebHistoryItem.h:
+ * WebInspector.h:
+ * WebJavaScriptCollector.h:
+ * WebKitClassFactory.h:
+ * WebKitMessageLoop.h:
+ * WebKitStatistics.h:
+ * WebMutableURLRequest.h:
+ * WebNavigationData.h:
+ * WebNotification.h:
+ * WebNotificationCenter.h:
+ * WebPreferences.h:
+ * WebResource.h:
+ * WebScriptWorld.h:
+ * WebSecurityOrigin.h:
+ * WebSerializedJSValue.h:
+ * WebTextRenderer.h:
+ * WebURLAuthenticationChallenge.h:
+ * WebURLAuthenticationChallengeSender.h:
+ * WebURLCredential.h:
+ * WebURLProtectionSpace.h:
+ * WebURLResponse.h:
+ * WebUserContentURLPattern.h:
+ * WebView.cpp:
+ * WebView.h:
+ * WebWorkersPrivate.h:
+
2018-12-11 Fujii Hironori <hironori.fu...@sony.com>
[Win][Clang] Fix warning -Wmissing-field-initializers
Modified: trunk/Source/WebKitLegacy/win/DefaultDownloadDelegate.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/DefaultDownloadDelegate.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/DefaultDownloadDelegate.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -32,7 +32,7 @@
#include <CFNetwork/CFURLDownloadPriv.h>
#endif
-class DefaultDownloadDelegate : public IWebDownloadDelegate
+class DefaultDownloadDelegate final : public IWebDownloadDelegate
{
public:
static DefaultDownloadDelegate* sharedInstance();
Modified: trunk/Source/WebKitLegacy/win/DefaultPolicyDelegate.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/DefaultPolicyDelegate.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/DefaultPolicyDelegate.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -28,7 +28,7 @@
#include "WebKit.h"
-class DefaultPolicyDelegate : public IWebPolicyDelegate {
+class DefaultPolicyDelegate final : public IWebPolicyDelegate {
public:
static DefaultPolicyDelegate* sharedInstance();
static DefaultPolicyDelegate* createInstance();
Modified: trunk/Source/WebKitLegacy/win/MemoryStream.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/MemoryStream.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/MemoryStream.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -32,7 +32,7 @@
#include <WebCore/SharedBuffer.h>
#include <WTF/RefPtr.h>
-class MemoryStream : public IStream
+class MemoryStream final : public IStream
{
public:
static COMPtr<MemoryStream> createInstance(RefPtr<WebCore::SharedBuffer>&&);
Modified: trunk/Source/WebKitLegacy/win/WebActionPropertyBag.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebActionPropertyBag.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebActionPropertyBag.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -31,7 +31,7 @@
#include <WebCore/HTMLFormElement.h>
#include <WebCore/NavigationAction.h>
-class WebActionPropertyBag : public IPropertyBag {
+class WebActionPropertyBag final : public IPropertyBag {
public:
static WebActionPropertyBag* createInstance(const WebCore::NavigationAction&, RefPtr<WebCore::HTMLFormElement>&&, RefPtr<WebCore::Frame>&&);
Modified: trunk/Source/WebKitLegacy/win/WebApplicationCache.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebApplicationCache.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebApplicationCache.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -32,7 +32,7 @@
class ApplicationCacheStorage;
}
-class DECLSPEC_UUID("1119E970-4B13-4B9A-A049-41096104B689") WebApplicationCache : public IWebApplicationCache {
+class DECLSPEC_UUID("1119E970-4B13-4B9A-A049-41096104B689") WebApplicationCache final : public IWebApplicationCache {
public:
static WebApplicationCache* createInstance();
Modified: trunk/Source/WebKitLegacy/win/WebArchive.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebArchive.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebArchive.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -34,7 +34,7 @@
class LegacyWebArchive;
}
-class WebArchive : public IWebArchive
+class WebArchive final : public IWebArchive
{
public:
static WebArchive* createInstance();
Modified: trunk/Source/WebKitLegacy/win/WebBackForwardList.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebBackForwardList.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebBackForwardList.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -33,7 +33,7 @@
class BackForwardList;
-class WebBackForwardList : public IWebBackForwardList, IWebBackForwardListPrivate
+class WebBackForwardList final : public IWebBackForwardList, IWebBackForwardListPrivate
{
public:
static WebBackForwardList* createInstance(RefPtr<BackForwardList>&&);
Modified: trunk/Source/WebKitLegacy/win/WebCache.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebCache.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebCache.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -28,7 +28,7 @@
#include "WebKit.h"
-class WebCache : public IWebCache
+class WebCache final : public IWebCache
{
public:
static WebCache* createInstance();
Modified: trunk/Source/WebKitLegacy/win/WebCoreStatistics.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebCoreStatistics.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebCoreStatistics.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -28,7 +28,7 @@
#include "WebKit.h"
-class WebCoreStatistics : public IWebCoreStatistics {
+class WebCoreStatistics final : public IWebCoreStatistics {
public:
static WebCoreStatistics* createInstance();
protected:
Modified: trunk/Source/WebKitLegacy/win/WebCoreSupport/WebEditorClient.cpp (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebCoreSupport/WebEditorClient.cpp 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebCoreSupport/WebEditorClient.cpp 2018-12-13 06:44:39 UTC (rev 239151)
@@ -63,7 +63,7 @@
// WebEditorUndoTarget -------------------------------------------------------------
-class WebEditorUndoTarget : public IWebUndoTarget
+class WebEditorUndoTarget final : public IWebUndoTarget
{
public:
WebEditorUndoTarget();
@@ -508,7 +508,7 @@
}
}
-class WebEditorUndoCommand : public IWebUndoCommand
+class WebEditorUndoCommand final : public IWebUndoCommand
{
public:
WebEditorUndoCommand(UndoStep&, bool isUndo);
Modified: trunk/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorDelegate.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorDelegate.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorDelegate.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -32,7 +32,7 @@
#include "WebKit.h"
-class WebInspectorDelegate : public IWebUIDelegate {
+class WebInspectorDelegate final : public IWebUIDelegate {
public:
static WebInspectorDelegate* createInstance();
Modified: trunk/Source/WebKitLegacy/win/WebDataSource.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebDataSource.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebDataSource.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -35,7 +35,7 @@
extern const GUID IID_WebDataSource;
-class WebDataSource : public IWebDataSource, public IWebDataSourcePrivate
+class WebDataSource final : public IWebDataSource, public IWebDataSourcePrivate
{
public:
static WebDataSource* createInstance(WebDocumentLoader*);
Modified: trunk/Source/WebKitLegacy/win/WebDatabaseManager.cpp (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebDatabaseManager.cpp 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebDatabaseManager.cpp 2018-12-13 06:44:39 UTC (rev 239151)
@@ -57,7 +57,7 @@
return !wcscmp(s1, s2);
}
-class DatabaseDetailsPropertyBag : public IPropertyBag {
+class DatabaseDetailsPropertyBag final : public IPropertyBag {
WTF_MAKE_NONCOPYABLE(DatabaseDetailsPropertyBag);
public:
static DatabaseDetailsPropertyBag* createInstance(const DatabaseDetails&);
Modified: trunk/Source/WebKitLegacy/win/WebDatabaseManager.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebDatabaseManager.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebDatabaseManager.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -35,7 +35,7 @@
struct SecurityOriginData;
}
-class WebDatabaseManager : public IWebDatabaseManager2, private WebCore::DatabaseManagerClient {
+class WebDatabaseManager final : public IWebDatabaseManager2, private WebCore::DatabaseManagerClient {
public:
static WebDatabaseManager* createInstance();
Modified: trunk/Source/WebKitLegacy/win/WebDownload.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebDownload.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebDownload.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -43,7 +43,7 @@
class ResourceResponse;
}
-class WebDownload
+class WebDownload final
: public IWebDownload
, public IWebURLAuthenticationChallengeSender
#if USE(CURL)
Modified: trunk/Source/WebKitLegacy/win/WebDropSource.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebDropSource.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebDropSource.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -38,7 +38,7 @@
WebCore::PlatformMouseEvent generateMouseEvent(WebView*, bool isDrag);
-class WebDropSource : public IDropSource
+class WebDropSource final : public IDropSource
{
public:
virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
Modified: trunk/Source/WebKitLegacy/win/WebElementPropertyBag.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebElementPropertyBag.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebElementPropertyBag.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -32,7 +32,7 @@
class HitTestResult;
}
-class WebElementPropertyBag : public IPropertyBag
+class WebElementPropertyBag final : public IPropertyBag
{
public:
static WebElementPropertyBag* createInstance(const WebCore::HitTestResult&);
Modified: trunk/Source/WebKitLegacy/win/WebError.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebError.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebError.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -30,7 +30,7 @@
#include <WebCore/ResourceError.h>
#include <wtf/RetainPtr.h>
-class WebError : public IWebError, IWebErrorPrivate {
+class WebError final : public IWebError, IWebErrorPrivate {
public:
static WebError* createInstance(const WebCore::ResourceError&, IPropertyBag* userInfo = 0);
static WebError* createInstance();
Modified: trunk/Source/WebKitLegacy/win/WebFrame.cpp (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebFrame.cpp 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebFrame.cpp 2018-12-13 06:44:39 UTC (rev 239151)
@@ -758,7 +758,7 @@
return hr;
}
-class EnumChildFrames : public IEnumVARIANT
+class EnumChildFrames final : public IEnumVARIANT
{
public:
EnumChildFrames(Frame* f)
Modified: trunk/Source/WebKitLegacy/win/WebFrame.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebFrame.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebFrame.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -75,7 +75,7 @@
WebFrame* kit(WebCore::Frame*);
WEBKIT_API WebCore::Frame* core(WebFrame*);
-class DECLSPEC_UUID("{A3676398-4485-4a9d-87DC-CB5A40E6351D}") WebFrame : public IWebFrame2, IWebFramePrivate, IWebDocumentText
+class DECLSPEC_UUID("{A3676398-4485-4a9d-87DC-CB5A40E6351D}") WebFrame final : public IWebFrame2, IWebFramePrivate, IWebDocumentText
{
public:
static WebFrame* createInstance();
Modified: trunk/Source/WebKitLegacy/win/WebFramePolicyListener.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebFramePolicyListener.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebFramePolicyListener.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -35,7 +35,7 @@
class Frame;
}
-class WebFramePolicyListener : public IWebPolicyDecisionListener, public IWebFormSubmissionListener {
+class WebFramePolicyListener final : public IWebPolicyDecisionListener, public IWebFormSubmissionListener {
public:
static WebFramePolicyListener* createInstance(RefPtr<WebCore::Frame>&&);
protected:
Modified: trunk/Source/WebKitLegacy/win/WebGeolocationPolicyListener.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebGeolocationPolicyListener.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebGeolocationPolicyListener.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -33,7 +33,7 @@
class Geolocation;
}
-class WebGeolocationPolicyListener : public IWebGeolocationPolicyListener {
+class WebGeolocationPolicyListener final : public IWebGeolocationPolicyListener {
public:
static COMPtr<WebGeolocationPolicyListener> createInstance(RefPtr<WebCore::Geolocation>&&);
Modified: trunk/Source/WebKitLegacy/win/WebGeolocationPosition.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebGeolocationPosition.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebGeolocationPosition.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -29,7 +29,7 @@
#include <WebCore/COMPtr.h>
#include <WebCore/GeolocationPosition.h>
-class WebGeolocationPosition : public IWebGeolocationPosition {
+class WebGeolocationPosition final : public IWebGeolocationPosition {
public:
static COMPtr<WebGeolocationPosition> createInstance();
private:
Modified: trunk/Source/WebKitLegacy/win/WebHTMLRepresentation.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebHTMLRepresentation.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebHTMLRepresentation.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -30,7 +30,7 @@
class WebFrame;
-class WebHTMLRepresentation : public IWebHTMLRepresentation, IWebDocumentRepresentation
+class WebHTMLRepresentation final : public IWebHTMLRepresentation, IWebDocumentRepresentation
{
public:
static WebHTMLRepresentation* createInstance(WebFrame* frame);
Modified: trunk/Source/WebKitLegacy/win/WebHistory.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebHistory.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebHistory.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -41,7 +41,7 @@
class WebPreferences;
class WebVisitedLinkStore;
-class WebHistory : public IWebHistory, public IWebHistoryPrivate {
+class WebHistory final : public IWebHistory, public IWebHistoryPrivate {
public:
static WebHistory* createInstance();
private:
Modified: trunk/Source/WebKitLegacy/win/WebHistoryItem.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebHistoryItem.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebHistoryItem.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -38,7 +38,7 @@
//-----------------------------------------------------------------------------
-class WebHistoryItem : public IWebHistoryItem, IWebHistoryItemPrivate
+class WebHistoryItem final : public IWebHistoryItem, IWebHistoryItemPrivate
{
public:
static WebHistoryItem* createInstance();
Modified: trunk/Source/WebKitLegacy/win/WebInspector.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebInspector.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebInspector.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -36,7 +36,7 @@
class WebInspectorFrontendClient;
class WebView;
-class WebInspector : public IWebInspector, public IWebInspectorPrivate {
+class WebInspector final : public IWebInspector, public IWebInspectorPrivate {
WTF_MAKE_NONCOPYABLE(WebInspector);
public:
static WebInspector* createInstance(WebView* inspectedWebView, WebInspectorClient*);
Modified: trunk/Source/WebKitLegacy/win/WebJavaScriptCollector.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebJavaScriptCollector.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebJavaScriptCollector.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -28,7 +28,7 @@
#include "WebKit.h"
-class WebJavaScriptCollector : public IWebJavaScriptCollector
+class WebJavaScriptCollector final : public IWebJavaScriptCollector
{
public:
static WebJavaScriptCollector* createInstance();
Modified: trunk/Source/WebKitLegacy/win/WebKitClassFactory.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebKitClassFactory.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebKitClassFactory.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -28,7 +28,7 @@
#include <unknwn.h>
-class WebKitClassFactory : public IClassFactory
+class WebKitClassFactory final : public IClassFactory
{
public:
WebKitClassFactory(CLSID targetClass);
Modified: trunk/Source/WebKitLegacy/win/WebKitMessageLoop.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebKitMessageLoop.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebKitMessageLoop.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -28,7 +28,7 @@
#include "WebKit.h"
-class WebKitMessageLoop : public IWebKitMessageLoop {
+class WebKitMessageLoop final : public IWebKitMessageLoop {
public:
WebKitMessageLoop();
~WebKitMessageLoop();
Modified: trunk/Source/WebKitLegacy/win/WebKitStatistics.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebKitStatistics.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebKitStatistics.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -31,7 +31,7 @@
#include "WebKit.h"
-class WebKitStatistics : public IWebKitStatistics {
+class WebKitStatistics final : public IWebKitStatistics {
public:
static WebKitStatistics* createInstance();
protected:
Modified: trunk/Source/WebKitLegacy/win/WebMutableURLRequest.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebMutableURLRequest.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebMutableURLRequest.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -44,7 +44,7 @@
return static_cast<WebURLRequestCachePolicy>(policy);
}
-class WebMutableURLRequest : public IWebMutableURLRequest, IWebMutableURLRequestPrivate
+class WebMutableURLRequest final : public IWebMutableURLRequest, IWebMutableURLRequestPrivate
{
public:
static WebMutableURLRequest* createInstance();
Modified: trunk/Source/WebKitLegacy/win/WebNavigationData.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebNavigationData.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebNavigationData.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -31,7 +31,7 @@
#include <WebCore/BString.h>
#include <WebCore/COMPtr.h>
-class WebNavigationData : public IWebNavigationData {
+class WebNavigationData final : public IWebNavigationData {
public:
static WebNavigationData* createInstance(const WTF::String& url, const WTF::String& title, IWebURLRequest*, IWebURLResponse*, bool hasSubstituteData, const WTF::String& clientRedirectSource);
private:
Modified: trunk/Source/WebKitLegacy/win/WebNotification.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebNotification.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebNotification.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -28,7 +28,7 @@
#include "WebKit.h"
-class WebNotification : public IWebNotification
+class WebNotification final : public IWebNotification
{
public:
static WebNotification* createInstance(BSTR name = 0, IUnknown* anObject = 0, IPropertyBag* userInfo = 0);
Modified: trunk/Source/WebKitLegacy/win/WebNotificationCenter.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebNotificationCenter.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebNotificationCenter.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -30,7 +30,7 @@
struct WebNotificationCenterPrivate;
-class WebNotificationCenter : public IWebNotificationCenter {
+class WebNotificationCenter final : public IWebNotificationCenter {
public:
static WebNotificationCenter* createInstance();
Modified: trunk/Source/WebKitLegacy/win/WebPreferences.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebPreferences.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebPreferences.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -30,7 +30,7 @@
#include <WebCore/BString.h>
#include <wtf/RetainPtr.h>
-class WebPreferences : public IWebPreferences, public IWebPreferencesPrivate7 {
+class WebPreferences final : public IWebPreferences, public IWebPreferencesPrivate7 {
public:
static WebPreferences* createInstance();
protected:
Modified: trunk/Source/WebKitLegacy/win/WebResource.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebResource.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebResource.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -34,7 +34,7 @@
#include <wtf/URL.h>
#include <wtf/text/WTFString.h>
-class WebResource : public IWebResource {
+class WebResource final : public IWebResource {
public:
static WebResource* createInstance(RefPtr<WebCore::SharedBuffer>&&, const WebCore::ResourceResponse&);
protected:
Modified: trunk/Source/WebKitLegacy/win/WebScriptWorld.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebScriptWorld.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebScriptWorld.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -32,7 +32,7 @@
class DOMWrapperWorld;
}
-class WebScriptWorld : public IWebScriptWorld {
+class WebScriptWorld final : public IWebScriptWorld {
WTF_MAKE_NONCOPYABLE(WebScriptWorld);
public:
static WebScriptWorld* standardWorld();
Modified: trunk/Source/WebKitLegacy/win/WebSecurityOrigin.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebSecurityOrigin.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebSecurityOrigin.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -31,7 +31,7 @@
#include "WebKit.h"
#include <WebCore/SecurityOrigin.h>
-class DECLSPEC_UUID("6EB8D98F-2723-4472-88D3-5936F9D6E631") WebSecurityOrigin : public IWebSecurityOrigin2 {
+class DECLSPEC_UUID("6EB8D98F-2723-4472-88D3-5936F9D6E631") WebSecurityOrigin final : public IWebSecurityOrigin2 {
public:
// WebSecurityOrigin
static WebSecurityOrigin* createInstance(WebCore::SecurityOrigin* origin);
Modified: trunk/Source/WebKitLegacy/win/WebSerializedJSValue.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebSerializedJSValue.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebSerializedJSValue.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -35,7 +35,7 @@
class SerializedScriptValue;
}
-class WebSerializedJSValue : public IWebSerializedJSValue, public IWebSerializedJSValuePrivate {
+class WebSerializedJSValue final : public IWebSerializedJSValue, public IWebSerializedJSValuePrivate {
WTF_MAKE_NONCOPYABLE(WebSerializedJSValue);
public:
static COMPtr<WebSerializedJSValue> createInstance();
Modified: trunk/Source/WebKitLegacy/win/WebTextRenderer.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebTextRenderer.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebTextRenderer.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -31,7 +31,7 @@
#include "WebKit.h"
-class WebTextRenderer : public IWebTextRenderer {
+class WebTextRenderer final : public IWebTextRenderer {
public:
static WebTextRenderer* createInstance();
Modified: trunk/Source/WebKitLegacy/win/WebURLAuthenticationChallenge.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebURLAuthenticationChallenge.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebURLAuthenticationChallenge.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -30,7 +30,7 @@
#include <WebCore/AuthenticationChallenge.h>
#include <WebCore/COMPtr.h>
-class DECLSPEC_UUID("FD3B2381-0BB6-4B59-AF09-0E599C8901CF") WebURLAuthenticationChallenge : public IWebURLAuthenticationChallenge {
+class DECLSPEC_UUID("FD3B2381-0BB6-4B59-AF09-0E599C8901CF") WebURLAuthenticationChallenge final : public IWebURLAuthenticationChallenge {
public:
static WebURLAuthenticationChallenge* createInstance(const WebCore::AuthenticationChallenge&);
static WebURLAuthenticationChallenge* createInstance(const WebCore::AuthenticationChallenge&, IWebURLAuthenticationChallengeSender*);
Modified: trunk/Source/WebKitLegacy/win/WebURLAuthenticationChallengeSender.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebURLAuthenticationChallengeSender.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebURLAuthenticationChallengeSender.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -35,7 +35,7 @@
class AuthenticationClient;
}
-class DECLSPEC_UUID("5CACD637-F82F-491F-947A-5DCA38AA0FEA") WebURLAuthenticationChallengeSender
+class DECLSPEC_UUID("5CACD637-F82F-491F-947A-5DCA38AA0FEA") WebURLAuthenticationChallengeSender final
: public IWebURLAuthenticationChallengeSender
{
public:
Modified: trunk/Source/WebKitLegacy/win/WebURLCredential.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebURLCredential.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebURLCredential.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -29,7 +29,7 @@
#include "WebKit.h"
#include <WebCore/Credential.h>
-class WebURLCredential : public IWebURLCredential
+class WebURLCredential final : public IWebURLCredential
{
public:
static WebURLCredential* createInstance();
Modified: trunk/Source/WebKitLegacy/win/WebURLProtectionSpace.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebURLProtectionSpace.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebURLProtectionSpace.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -29,7 +29,7 @@
#include "WebKit.h"
#include <WebCore/ProtectionSpace.h>
-class WebURLProtectionSpace : public IWebURLProtectionSpace
+class WebURLProtectionSpace final : public IWebURLProtectionSpace
{
public:
static WebURLProtectionSpace* createInstance();
Modified: trunk/Source/WebKitLegacy/win/WebURLResponse.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebURLResponse.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebURLResponse.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -28,7 +28,7 @@
#include "WebKit.h"
#include <WebCore/ResourceResponse.h>
-class WebURLResponse : public IWebHTTPURLResponse, IWebURLResponsePrivate
+class WebURLResponse final : public IWebHTTPURLResponse, IWebURLResponsePrivate
{
public:
static WebURLResponse* createInstance();
Modified: trunk/Source/WebKitLegacy/win/WebUserContentURLPattern.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebUserContentURLPattern.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebUserContentURLPattern.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -33,7 +33,7 @@
class UserContentURLPattern;
}
-class WebUserContentURLPattern : public IWebUserContentURLPattern {
+class WebUserContentURLPattern final : public IWebUserContentURLPattern {
WTF_MAKE_NONCOPYABLE(WebUserContentURLPattern);
public:
static COMPtr<WebUserContentURLPattern> createInstance();
Modified: trunk/Source/WebKitLegacy/win/WebView.cpp (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebView.cpp 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebView.cpp 2018-12-13 06:44:39 UTC (rev 239151)
@@ -282,7 +282,7 @@
return toString(localStorageDatabasePath);
}
-class PreferencesChangedOrRemovedObserver : public IWebNotificationObserver {
+class PreferencesChangedOrRemovedObserver final : public IWebNotificationObserver {
public:
static PreferencesChangedOrRemovedObserver* sharedInstance();
@@ -7385,7 +7385,7 @@
}
#endif
-class EnumTextMatches : public IEnumTextMatches
+class EnumTextMatches final : public IEnumTextMatches
{
long m_ref;
UINT m_index;
Modified: trunk/Source/WebKitLegacy/win/WebView.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebView.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebView.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -85,7 +85,7 @@
interface ID2D1RenderTarget;
#endif
-class WebView
+class WebView final
: public IWebView
, public IWebViewPrivate5
, public IWebIBActions
Modified: trunk/Source/WebKitLegacy/win/WebWorkersPrivate.h (239150 => 239151)
--- trunk/Source/WebKitLegacy/win/WebWorkersPrivate.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Source/WebKitLegacy/win/WebWorkersPrivate.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -33,7 +33,7 @@
#include "WebKit.h"
-class WebWorkersPrivate : public IWebWorkersPrivate {
+class WebWorkersPrivate final : public IWebWorkersPrivate {
public:
static WebWorkersPrivate* createInstance();
private:
Modified: trunk/Tools/ChangeLog (239150 => 239151)
--- trunk/Tools/ChangeLog 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Tools/ChangeLog 2018-12-13 06:44:39 UTC (rev 239151)
@@ -1,3 +1,18 @@
+2018-12-12 Fujii Hironori <hironori.fu...@sony.com>
+
+ [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
+ https://bugs.webkit.org/show_bug.cgi?id=192618
+
+ Reviewed by Alex Christensen.
+
+ * DumpRenderTree/win/DRTDataObject.cpp:
+ * DumpRenderTree/win/DRTDataObject.h:
+ * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
+ * DumpRenderTree/win/DRTDropSource.h:
+ * DumpRenderTree/win/EditingDelegate.h:
+ * DumpRenderTree/win/PolicyDelegate.h:
+ * DumpRenderTree/win/UIDelegate.h:
+
2018-12-12 Ryosuke Niwa <rn...@webkit.org>
Make TextInputController.legacyAttributedString take DOM nodes and offsets
Modified: trunk/Tools/DumpRenderTree/win/DRTDataObject.cpp (239150 => 239151)
--- trunk/Tools/DumpRenderTree/win/DRTDataObject.cpp 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Tools/DumpRenderTree/win/DRTDataObject.cpp 2018-12-13 06:44:39 UTC (rev 239151)
@@ -47,7 +47,7 @@
return &urlFormat;
}
-class WCEnumFormatEtc : public IEnumFORMATETC {
+class WCEnumFormatEtc final : public IEnumFORMATETC {
public:
explicit WCEnumFormatEtc(const Vector<FORMATETC>& formats);
explicit WCEnumFormatEtc(const Vector<std::unique_ptr<FORMATETC>>& formats);
Modified: trunk/Tools/DumpRenderTree/win/DRTDataObject.h (239150 => 239151)
--- trunk/Tools/DumpRenderTree/win/DRTDataObject.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Tools/DumpRenderTree/win/DRTDataObject.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -44,7 +44,7 @@
}
};
-class DRTDataObject : public IDataObject {
+class DRTDataObject final : public IDataObject {
public:
void CopyMedium(STGMEDIUM* pMedDest, STGMEDIUM* pMedSrc, FORMATETC* pFmtSrc);
Modified: trunk/Tools/DumpRenderTree/win/DRTDesktopNotificationPresenter.h (239150 => 239151)
--- trunk/Tools/DumpRenderTree/win/DRTDesktopNotificationPresenter.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Tools/DumpRenderTree/win/DRTDesktopNotificationPresenter.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -32,7 +32,7 @@
#include <WebKitLegacy/WebKit.h>
#include <windef.h>
-class DRTDesktopNotificationPresenter : public IWebDesktopNotificationsDelegate {
+class DRTDesktopNotificationPresenter final : public IWebDesktopNotificationsDelegate {
public:
DRTDesktopNotificationPresenter();
Modified: trunk/Tools/DumpRenderTree/win/DRTDropSource.h (239150 => 239151)
--- trunk/Tools/DumpRenderTree/win/DRTDropSource.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Tools/DumpRenderTree/win/DRTDropSource.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -30,7 +30,7 @@
#include <ShlObj.h>
#include <windows.h>
-class DRTDropSource : public IDropSource {
+class DRTDropSource final : public IDropSource {
public:
virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
virtual ULONG STDMETHODCALLTYPE AddRef();
Modified: trunk/Tools/DumpRenderTree/win/EditingDelegate.h (239150 => 239151)
--- trunk/Tools/DumpRenderTree/win/EditingDelegate.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Tools/DumpRenderTree/win/EditingDelegate.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -31,7 +31,7 @@
#include <WebKitLegacy/WebKit.h>
-class __declspec(uuid("265DCD4B-79C3-44a2-84BC-511C3EDABD6F")) EditingDelegate : public IWebEditingDelegate2, public IWebNotificationObserver {
+class __declspec(uuid("265DCD4B-79C3-44a2-84BC-511C3EDABD6F")) EditingDelegate final : public IWebEditingDelegate2, public IWebNotificationObserver {
public:
EditingDelegate();
Modified: trunk/Tools/DumpRenderTree/win/PolicyDelegate.h (239150 => 239151)
--- trunk/Tools/DumpRenderTree/win/PolicyDelegate.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Tools/DumpRenderTree/win/PolicyDelegate.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -33,7 +33,7 @@
class TestRunner;
-class PolicyDelegate : public IWebPolicyDelegate {
+class PolicyDelegate final : public IWebPolicyDelegate {
public:
PolicyDelegate();
Modified: trunk/Tools/DumpRenderTree/win/UIDelegate.h (239150 => 239151)
--- trunk/Tools/DumpRenderTree/win/UIDelegate.h 2018-12-13 04:46:25 UTC (rev 239150)
+++ trunk/Tools/DumpRenderTree/win/UIDelegate.h 2018-12-13 06:44:39 UTC (rev 239151)
@@ -36,7 +36,7 @@
class DRTUndoManager;
class DRTDesktopNotificationPresenter;
-class UIDelegate : public IWebUIDelegate2, IWebUIDelegatePrivate3 {
+class UIDelegate final : public IWebUIDelegate2, IWebUIDelegatePrivate3 {
public:
UIDelegate();
