Title: [239526] trunk/Source/WebCore
- Revision
- 239526
- Author
- za...@apple.com
- Date
- 2018-12-21 16:02:19 -0800 (Fri, 21 Dec 2018)
Log Message
[iOS] Using file upload can trigger a crash under RenderThemeIOS::paintFileUploadIconDecorations()
https://bugs.webkit.org/show_bug.cgi?id=192357
<rdar://problem/42852260>
Reviewed by Simon Fraser.
Do not try to paint the file picker when painting is disabled.
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (239525 => 239526)
--- trunk/Source/WebCore/ChangeLog 2018-12-21 23:49:26 UTC (rev 239525)
+++ trunk/Source/WebCore/ChangeLog 2018-12-22 00:02:19 UTC (rev 239526)
@@ -1,3 +1,16 @@
+2018-12-21 Zalan Bujtas <za...@apple.com>
+
+ [iOS] Using file upload can trigger a crash under RenderThemeIOS::paintFileUploadIconDecorations()
+ https://bugs.webkit.org/show_bug.cgi?id=192357
+ <rdar://problem/42852260>
+
+ Reviewed by Simon Fraser.
+
+ Do not try to paint the file picker when painting is disabled.
+
+ * rendering/RenderFileUploadControl.cpp:
+ (WebCore::RenderFileUploadControl::paintObject):
+
2018-12-21 Jiewen Tan <jiewen_...@apple.com>
[WebAuthN] userPresence should always be true
Modified: trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp (239525 => 239526)
--- trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp 2018-12-21 23:49:26 UTC (rev 239525)
+++ trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp 2018-12-22 00:02:19 UTC (rev 239526)
@@ -117,6 +117,9 @@
if (style().visibility() != Visibility::Visible)
return;
+ if (paintInfo.context().paintingDisabled())
+ return;
+
// Push a clip.
GraphicsContextStateSaver stateSaver(paintInfo.context(), false);
if (paintInfo.phase == PaintPhase::Foreground || paintInfo.phase == PaintPhase::ChildBlockBackgrounds) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
