Title: [239596] trunk/Tools
- Revision
- 239596
- Author
- [email protected]
- Date
- 2019-01-03 10:20:57 -0800 (Thu, 03 Jan 2019)
Log Message
UserMedia test should use WKPageNavigationClient
https://bugs.webkit.org/show_bug.cgi?id=192913
Reviewed by Youenn Fablet.
The test currently uses the deprecated WKPageLoaderClient. It should use
WKPageNavigationClient instead, which provides the same callback under a similar name.
* TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (239595 => 239596)
--- trunk/Tools/ChangeLog 2019-01-03 17:58:32 UTC (rev 239595)
+++ trunk/Tools/ChangeLog 2019-01-03 18:20:57 UTC (rev 239596)
@@ -1,3 +1,16 @@
+2019-01-03 Michael Catanzaro <[email protected]>
+
+ UserMedia test should use WKPageNavigationClient
+ https://bugs.webkit.org/show_bug.cgi?id=192913
+
+ Reviewed by Youenn Fablet.
+
+ The test currently uses the deprecated WKPageLoaderClient. It should use
+ WKPageNavigationClient instead, which provides the same callback under a similar name.
+
+ * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
+ (TestWebKitAPI::TEST):
+
2019-01-02 Alex Christensen <[email protected]>
Homograph with LATIN SMALL LETTER R WITH FISHHOOK
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp (239595 => 239596)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp 2019-01-03 17:58:32 UTC (rev 239595)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp 2019-01-03 18:20:57 UTC (rev 239596)
@@ -132,11 +132,11 @@
// Load a second page in same process.
PlatformWebView webView2(context.get(), pageGroup.get());
WKPageSetPageUIClient(webView2.page(), &uiClient.base);
- WKPageLoaderClientV0 loaderClient;
- memset(&loaderClient, 0, sizeof(loaderClient));
- loaderClient.base.version = 0;
- loaderClient.processDidCrash = didCrashCallback;
- WKPageSetPageLoaderClient(webView2.page(), &loaderClient.base);
+ WKPageNavigationClientV0 navigationClient;
+ memset(&navigationClient, 0, sizeof(navigationClient));
+ navigationClient.base.version = 0;
+ navigationClient.webProcessDidCrash = didCrashCallback;
+ WKPageSetPageNavigationClient(webView2.page(), &navigationClient.base);
wasPrompted = false;
url = "" "html"));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
