Title: [239855] trunk/Tools
- Revision
- 239855
- Author
- commit-qu...@webkit.org
- Date
- 2019-01-10 20:38:04 -0800 (Thu, 10 Jan 2019)
Log Message
Remove MiniBrowser custom "Process Swap" menu item which does not work
https://bugs.webkit.org/show_bug.cgi?id=193344
Patch by Joseph Pecoraro <pecor...@apple.com> on 2019-01-10
Reviewed by Simon Fraser.
There is a menu item under the Experimental menu that does work.
* MiniBrowser/mac/AppDelegate.m:
(defaultConfiguration):
* MiniBrowser/mac/SettingsController.h:
* MiniBrowser/mac/SettingsController.m:
(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController processSwapOnNavigationEnabled]): Deleted.
(-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (239854 => 239855)
--- trunk/Tools/ChangeLog 2019-01-11 03:54:43 UTC (rev 239854)
+++ trunk/Tools/ChangeLog 2019-01-11 04:38:04 UTC (rev 239855)
@@ -1,3 +1,21 @@
+2019-01-10 Joseph Pecoraro <pecor...@apple.com>
+
+ Remove MiniBrowser custom "Process Swap" menu item which does not work
+ https://bugs.webkit.org/show_bug.cgi?id=193344
+
+ Reviewed by Simon Fraser.
+
+ There is a menu item under the Experimental menu that does work.
+
+ * MiniBrowser/mac/AppDelegate.m:
+ (defaultConfiguration):
+ * MiniBrowser/mac/SettingsController.h:
+ * MiniBrowser/mac/SettingsController.m:
+ (-[SettingsController _populateMenu]):
+ (-[SettingsController validateMenuItem:]):
+ (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
+ (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
+
2019-01-10 Timothy Hatcher <timo...@apple.com>
Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
Modified: trunk/Tools/MiniBrowser/mac/AppDelegate.m (239854 => 239855)
--- trunk/Tools/MiniBrowser/mac/AppDelegate.m 2019-01-11 03:54:43 UTC (rev 239854)
+++ trunk/Tools/MiniBrowser/mac/AppDelegate.m 2019-01-11 04:38:04 UTC (rev 239855)
@@ -101,8 +101,6 @@
processConfiguration.diskCacheSpeculativeValidationEnabled = ![SettingsController shared].networkCacheSpeculativeRevalidationDisabled;
if ([SettingsController shared].perWindowWebProcessesDisabled)
processConfiguration.maximumProcessCount = 1;
- if ([SettingsController shared].processSwapOnNavigationEnabled)
- processConfiguration.processSwapsOnNavigation = true;
if ([SettingsController shared].processSwapOnWindowOpenWithOpenerEnabled)
processConfiguration.processSwapsOnWindowOpenWithOpener = true;
Modified: trunk/Tools/MiniBrowser/mac/SettingsController.h (239854 => 239855)
--- trunk/Tools/MiniBrowser/mac/SettingsController.h 2019-01-11 03:54:43 UTC (rev 239854)
+++ trunk/Tools/MiniBrowser/mac/SettingsController.h 2019-01-11 04:38:04 UTC (rev 239855)
@@ -62,7 +62,6 @@
@property (nonatomic, readonly) BOOL loadsAllSiteIcons;
@property (nonatomic, readonly) BOOL usesGameControllerFramework;
@property (nonatomic, readonly) BOOL networkCacheSpeculativeRevalidationDisabled;
-@property (nonatomic, readonly) BOOL processSwapOnNavigationEnabled;
@property (nonatomic, readonly) BOOL processSwapOnWindowOpenWithOpenerEnabled;
@property (nonatomic, readonly) NSString *defaultURL;
Modified: trunk/Tools/MiniBrowser/mac/SettingsController.m (239854 => 239855)
--- trunk/Tools/MiniBrowser/mac/SettingsController.m 2019-01-11 03:54:43 UTC (rev 239854)
+++ trunk/Tools/MiniBrowser/mac/SettingsController.m 2019-01-11 04:38:04 UTC (rev 239855)
@@ -74,7 +74,6 @@
static NSString * const PerWindowWebProcessesDisabledKey = @"PerWindowWebProcessesDisabled";
static NSString * const NetworkCacheSpeculativeRevalidationDisabledKey = @"NetworkCacheSpeculativeRevalidationDisabled";
-static NSString * const ProcessSwapOnNavigationKey = @"ProcessSwapOnNavigation";
static NSString * const ProcessSwapOnWindowOpenWithOpenerKey = @"ProcessSwapOnWindowOpenWithOpener";
typedef NS_ENUM(NSInteger, DebugOverylayMenuItemTag) {
@@ -188,7 +187,6 @@
[self _addItemWithTitle:@"Load All Site Icons Per-Page" action:@selector(toggleLoadsAllSiteIcons:) indented:YES];
[self _addItemWithTitle:@"Use GameController.framework on macOS (Restart required)" action:@selector(toggleUsesGameControllerFramework:) indented:YES];
[self _addItemWithTitle:@"Disable network cache speculative revalidation" action:@selector(toggleNetworkCacheSpeculativeRevalidationDisabled:) indented:YES];
- [self _addItemWithTitle:@"Enable Process Swap on Navigation" action:@selector(toggleProcessSwapOnNavigation:) indented:YES];
[self _addItemWithTitle:@"Enable Process Swap on window.open() with an opener" action:@selector(toggleProcessSwapOnWindowOpenWithOpener:) indented:YES];
NSMenuItem *debugOverlaysSubmenuItem = [[NSMenuItem alloc] initWithTitle:@"Debug Overlays" action:nil keyEquivalent:@""];
@@ -307,8 +305,6 @@
[menuItem setState:[self usesGameControllerFramework] ? NSControlStateValueOn : NSControlStateValueOff];
else if (action == @selector(toggleNetworkCacheSpeculativeRevalidationDisabled:))
[menuItem setState:[self networkCacheSpeculativeRevalidationDisabled] ? NSControlStateValueOn : NSControlStateValueOff];
- else if (action == @selector(toggleProcessSwapOnNavigation:))
- [menuItem setState:[self processSwapOnNavigationEnabled] ? NSControlStateValueOn : NSControlStateValueOff];
else if (action == @selector(toggleProcessSwapOnWindowOpenWithOpener:))
[menuItem setState:[self processSwapOnWindowOpenWithOpenerEnabled] ? NSControlStateValueOn : NSControlStateValueOff];
else if (action == @selector(toggleUseUISideCompositing:))
@@ -530,16 +526,6 @@
[self _toggleBooleanDefault:NetworkCacheSpeculativeRevalidationDisabledKey];
}
-- (BOOL)processSwapOnNavigationEnabled
-{
- return [[NSUserDefaults standardUserDefaults] boolForKey:ProcessSwapOnNavigationKey];
-}
-
-- (void)toggleProcessSwapOnNavigation:(id)sender
-{
- [self _toggleBooleanDefault:ProcessSwapOnNavigationKey];
-}
-
- (BOOL)processSwapOnWindowOpenWithOpenerEnabled
{
return [[NSUserDefaults standardUserDefaults] boolForKey:ProcessSwapOnWindowOpenWithOpenerKey];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes