Title: [240001] trunk/Source/ThirdParty/ANGLE
- Revision
- 240001
- Author
- [email protected]
- Date
- 2019-01-15 13:47:51 -0800 (Tue, 15 Jan 2019)
Log Message
clang-tidy: Fix unnecessary copy of for loop variables in ANGLE
<https://webkit.org/b/193443>
Reviewed by Alex Christensen.
Fix unwanted copying of loop variables by making them const
references.
* src/compiler/preprocessor/MacroExpander.cpp:
(pp::MacroExpander::ScopedMacroReenabler::~ScopedMacroReenabler):
- Prevents copy and reference churn of std::shared_ptr<Macro>
objects.
* src/compiler/translator/Compiler.cpp:
(sh::TCompiler::useAllMembersInUnusedStandardAndSharedBlocks):
- Prevents copy of sh::InterfaceBlock structs.
(sh::TCompiler::initializeOutputVariables):
- Prevents copy of sh::Varying structs.
* src/libANGLE/Program.cpp:
(gl::(anonymous namespace)::IncludeSameArrayElement):
- Prevents copy of std::string objects.
Modified Paths
Diff
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (240000 => 240001)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2019-01-15 21:21:02 UTC (rev 240000)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2019-01-15 21:47:51 UTC (rev 240001)
@@ -1,3 +1,26 @@
+2019-01-15 David Kilzer <[email protected]>
+
+ clang-tidy: Fix unnecessary copy of for loop variables in ANGLE
+ <https://webkit.org/b/193443>
+
+ Reviewed by Alex Christensen.
+
+ Fix unwanted copying of loop variables by making them const
+ references.
+
+ * src/compiler/preprocessor/MacroExpander.cpp:
+ (pp::MacroExpander::ScopedMacroReenabler::~ScopedMacroReenabler):
+ - Prevents copy and reference churn of std::shared_ptr<Macro>
+ objects.
+ * src/compiler/translator/Compiler.cpp:
+ (sh::TCompiler::useAllMembersInUnusedStandardAndSharedBlocks):
+ - Prevents copy of sh::InterfaceBlock structs.
+ (sh::TCompiler::initializeOutputVariables):
+ - Prevents copy of sh::Varying structs.
+ * src/libANGLE/Program.cpp:
+ (gl::(anonymous namespace)::IncludeSameArrayElement):
+ - Prevents copy of std::string objects.
+
2018-10-03 Dan Bernstein <[email protected]>
ANGLE part of [Xcode] Update some build settings as recommended by Xcode 10
Modified: trunk/Source/ThirdParty/ANGLE/src/compiler/preprocessor/MacroExpander.cpp (240000 => 240001)
--- trunk/Source/ThirdParty/ANGLE/src/compiler/preprocessor/MacroExpander.cpp 2019-01-15 21:21:02 UTC (rev 240000)
+++ trunk/Source/ThirdParty/ANGLE/src/compiler/preprocessor/MacroExpander.cpp 2019-01-15 21:47:51 UTC (rev 240001)
@@ -70,7 +70,7 @@
MacroExpander::ScopedMacroReenabler::~ScopedMacroReenabler()
{
mExpander->mDeferReenablingMacros = false;
- for (auto macro : mExpander->mMacrosToReenable)
+ for (const auto& macro : mExpander->mMacrosToReenable)
{
// Copying the string here by using substr is a check for use-after-free. It detects
// use-after-free more reliably than just toggling the disabled flag.
Modified: trunk/Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp (240000 => 240001)
--- trunk/Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp 2019-01-15 21:21:02 UTC (rev 240000)
+++ trunk/Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp 2019-01-15 21:47:51 UTC (rev 240001)
@@ -1067,7 +1067,7 @@
{
sh::InterfaceBlockList list;
- for (auto block : uniformBlocks)
+ for (const auto& block : uniformBlocks)
{
if (!block.staticUse &&
(block.layout == sh::BLOCKLAYOUT_STD140 || block.layout == sh::BLOCKLAYOUT_SHARED))
@@ -1084,7 +1084,7 @@
InitVariableList list;
if (shaderType == GL_VERTEX_SHADER || shaderType == GL_GEOMETRY_SHADER_OES)
{
- for (auto var : outputVaryings)
+ for (const auto& var : outputVaryings)
{
list.push_back(var);
if (var.name == "gl_Position")
@@ -1097,7 +1097,7 @@
else
{
ASSERT(shaderType == GL_FRAGMENT_SHADER);
- for (auto var : outputVariables)
+ for (const auto& var : outputVariables)
{
list.push_back(var);
}
Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/Program.cpp (240000 => 240001)
--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/Program.cpp 2019-01-15 21:21:02 UTC (rev 240000)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/Program.cpp 2019-01-15 21:47:51 UTC (rev 240001)
@@ -192,7 +192,7 @@
{
std::vector<unsigned int> subscripts;
std::string baseName = ParseResourceName(name, &subscripts);
- for (auto nameInSet : nameSet)
+ for (const auto& nameInSet : nameSet)
{
std::vector<unsigned int> arrayIndices;
std::string arrayName = ParseResourceName(nameInSet, &arrayIndices);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
