Title: [240016] trunk/Source/WebKit
- Revision
- 240016
- Author
- [email protected]
- Date
- 2019-01-15 15:55:36 -0800 (Tue, 15 Jan 2019)
Log Message
Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=193468
<rdar://problem/38645869>
Reviewed by Beth Dakin.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded):
I'm not sure why this got *worse*, but we should null-check RenderView.
It's OK to bail from scaleViewToFitDocumentIfNeeded, we'll re-do it
the next time we paint (which will surely happen if we gain a RenderView).
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (240015 => 240016)
--- trunk/Source/WebKit/ChangeLog 2019-01-15 23:48:31 UTC (rev 240015)
+++ trunk/Source/WebKit/ChangeLog 2019-01-15 23:55:36 UTC (rev 240016)
@@ -1,3 +1,17 @@
+2019-01-15 Tim Horton <[email protected]>
+
+ Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded()
+ https://bugs.webkit.org/show_bug.cgi?id=193468
+ <rdar://problem/38645869>
+
+ Reviewed by Beth Dakin.
+
+ * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+ (WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded):
+ I'm not sure why this got *worse*, but we should null-check RenderView.
+ It's OK to bail from scaleViewToFitDocumentIfNeeded, we'll re-do it
+ the next time we paint (which will surely happen if we gain a RenderView).
+
2019-01-15 Chris Dumez <[email protected]>
Unreviewed, rolling out r239993, r239995, r239997, and
Modified: trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (240015 => 240016)
--- trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2019-01-15 23:48:31 UTC (rev 240015)
+++ trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2019-01-15 23:55:36 UTC (rev 240016)
@@ -312,6 +312,9 @@
if (!m_shouldScaleViewToFitDocument)
return;
+ if (!m_webPage.mainFrameView()->renderView())
+ return;
+
LOG(Resize, "TiledCoreAnimationDrawingArea %p scaleViewToFitDocumentIfNeeded", this);
m_webPage.layoutIfNeeded();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
