Diff
Modified: trunk/JSTests/ChangeLog (240268 => 240269)
--- trunk/JSTests/ChangeLog 2019-01-22 19:06:42 UTC (rev 240268)
+++ trunk/JSTests/ChangeLog 2019-01-22 19:41:10 UTC (rev 240269)
@@ -1,3 +1,14 @@
+2019-01-22 Saam Barati <[email protected]>
+
+ Unreviewed. Rollout r240223. It regressed JetStream2 by 1%.
+
+ * stress/arith-abs-to-arith-negate-range-optimizaton.js:
+ (testUncheckedBetweenIntMinInclusiveAndZeroExclusive):
+ (testUncheckedLessThanZero):
+ (testUncheckedLessThanOrEqualZero):
+ * stress/movhint-backwards-propagation-must-merge-use-as-value-add.js: Removed.
+ * stress/movhint-backwards-propagation-must-merge-use-as-value.js: Removed.
+
2019-01-22 Yusuke Suzuki <[email protected]>
[JSC] Invalidate old scope operations using global lexical binding epoch
Modified: trunk/JSTests/stress/arith-abs-to-arith-negate-range-optimizaton.js (240268 => 240269)
--- trunk/JSTests/stress/arith-abs-to-arith-negate-range-optimizaton.js 2019-01-22 19:06:42 UTC (rev 240268)
+++ trunk/JSTests/stress/arith-abs-to-arith-negate-range-optimizaton.js 2019-01-22 19:41:10 UTC (rev 240269)
@@ -233,7 +233,7 @@
throw "Failed testUncheckedBetweenIntMinInclusiveAndZeroExclusive() on -2147483648";
}
}
- if (numberOfDFGCompiles(opaqueUncheckedBetweenIntMinInclusiveAndZeroExclusive) > 2) {
+ if (numberOfDFGCompiles(opaqueUncheckedBetweenIntMinInclusiveAndZeroExclusive) > 1) {
throw "Failed optimizing testUncheckedBetweenIntMinInclusiveAndZeroExclusive(). None of the tested case need to OSR Exit.";
}
}
@@ -376,7 +376,7 @@
throw "Failed testUncheckedLessThanOrEqualZero() on -2147483648";
}
}
- if (numberOfDFGCompiles(opaqueUncheckedLessThanZero) > 2) {
+ if (numberOfDFGCompiles(opaqueUncheckedLessThanZero) > 1) {
throw "Failed optimizing testUncheckedLessThanZero(). None of the tested case need to OSR Exit.";
}
@@ -420,7 +420,7 @@
throw "Failed testUncheckedLessThanOrEqualZero() on -2147483648";
}
}
- if (numberOfDFGCompiles(opaqueUncheckedLessThanOrEqualZero) > 2) {
+ if (numberOfDFGCompiles(opaqueUncheckedLessThanOrEqualZero) > 1) {
throw "Failed optimizing testUncheckedLessThanOrEqualZero(). None of the tested case need to OSR Exit.";
}
}
Deleted: trunk/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value-add.js (240268 => 240269)
--- trunk/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value-add.js 2019-01-22 19:06:42 UTC (rev 240268)
+++ trunk/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value-add.js 2019-01-22 19:41:10 UTC (rev 240269)
@@ -1,16 +0,0 @@
-function foo(v, a, b) {
- if (v) {
- let r = a + b;
- OSRExit();
- return r;
- }
-}
-noInline(foo);
-
-for (let i = 0; i < 10000; ++i) {
- let r = foo(true, 4, 4);
- if (r !== 8)
- throw new Error("Bad!");
-}
-if (foo(true, 2**31 - 1, 1) !== 2**31)
- throw new Error("Bad!");
Deleted: trunk/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value.js (240268 => 240269)
--- trunk/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value.js 2019-01-22 19:06:42 UTC (rev 240268)
+++ trunk/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value.js 2019-01-22 19:41:10 UTC (rev 240269)
@@ -1,16 +0,0 @@
-function foo(v, a, b) {
- if (v) {
- let r = a / b;
- OSRExit();
- return r;
- }
-}
-noInline(foo);
-
-for (let i = 0; i < 10000; ++i) {
- let r = foo(true, 4, 4);
- if (r !== 1)
- throw new Error("Bad!");
-}
-if (foo(true, 1, 4) !== 0.25)
- throw new Error("Bad!");
Modified: trunk/Source/_javascript_Core/ChangeLog (240268 => 240269)
--- trunk/Source/_javascript_Core/ChangeLog 2019-01-22 19:06:42 UTC (rev 240268)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-01-22 19:41:10 UTC (rev 240269)
@@ -1,3 +1,10 @@
+2019-01-22 Saam Barati <[email protected]>
+
+ Unreviewed. Rollout r240223. It regressed JetStream2 by 1%.
+
+ * dfg/DFGBackwardsPropagationPhase.cpp:
+ (JSC::DFG::BackwardsPropagationPhase::propagate):
+
2019-01-22 Tadeu Zagallo <[email protected]>
Unreviewed, restore bytecode cache-related JSC options deleted in r240254
Modified: trunk/Source/_javascript_Core/dfg/DFGBackwardsPropagationPhase.cpp (240268 => 240269)
--- trunk/Source/_javascript_Core/dfg/DFGBackwardsPropagationPhase.cpp 2019-01-22 19:06:42 UTC (rev 240268)
+++ trunk/Source/_javascript_Core/dfg/DFGBackwardsPropagationPhase.cpp 2019-01-22 19:41:10 UTC (rev 240269)
@@ -205,6 +205,7 @@
break;
}
+ case MovHint:
case Check:
case CheckVarargs:
break;
