Title: [240290] trunk/Source/WebInspectorUI
- Revision
- 240290
- Author
- commit-qu...@webkit.org
- Date
- 2019-01-22 13:23:31 -0800 (Tue, 22 Jan 2019)
Log Message
Web Inspector: Network Table appears broken after filter - rows look collapsed
https://bugs.webkit.org/show_bug.cgi?id=192730
<rdar://problem/46853158>
Patch by Joseph Pecoraro <pecor...@apple.com> on 2019-01-22
Reviewed by Devin Rousso.
* UserInterface/Views/Table.js:
(WI.Table.prototype._applyColumnWidthsToColumnsIfNeeded):
Affect the filler row like the other applyColumnWidths calls since this
now may be the initial call to size visible columns.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (240289 => 240290)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-01-22 21:22:34 UTC (rev 240289)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-01-22 21:23:31 UTC (rev 240290)
@@ -1,3 +1,16 @@
+2019-01-22 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Network Table appears broken after filter - rows look collapsed
+ https://bugs.webkit.org/show_bug.cgi?id=192730
+ <rdar://problem/46853158>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/Table.js:
+ (WI.Table.prototype._applyColumnWidthsToColumnsIfNeeded):
+ Affect the filler row like the other applyColumnWidths calls since this
+ now may be the initial call to size visible columns.
+
2019-01-22 Devin Rousso <drou...@apple.com>
Web Inspector: Audit: use plural strings for Passed, Failed, and Unsupported
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Table.js (240289 => 240290)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2019-01-22 21:22:34 UTC (rev 240289)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2019-01-22 21:23:31 UTC (rev 240290)
@@ -1153,11 +1153,13 @@
{
// Apply and create missing cells only if row needs a width update.
for (let row of this._listElement.children) {
- if (row.__widthGeneration !== this._widthGeneration && row !== this._fillerRow) {
+ if (row.__widthGeneration !== this._widthGeneration) {
for (let i = 0; i < row.children.length; ++i)
row.children[i].style.width = this._columnWidths[i] + "px";
- if (row.children.length !== this._visibleColumns.length)
- this._populateRow(row);
+ if (row !== this._fillerRow) {
+ if (row.children.length !== this._visibleColumns.length)
+ this._populateRow(row);
+ }
row.__widthGeneration = this._widthGeneration;
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
