Title: [240502] trunk/Source/WebInspectorUI
- Revision
- 240502
- Author
- [email protected]
- Date
- 2019-01-25 13:49:03 -0800 (Fri, 25 Jan 2019)
Log Message
Web Inspector: Audit: remove experimental setting
https://bugs.webkit.org/show_bug.cgi?id=193743
<rdar://problem/28234022>
Reviewed by Joseph Pecoraro.
* UserInterface/Base/Setting.js:
(WI.Setting):
(WI.Setting.localStorageKey): Added.
(WI.Setting.migrateValue):
Drive-by: add the localStorage key prefix to the key passed into `WI.Setting.migrateValue`.
* UserInterface/Base/Main.js:
(WI.loaded):
* UserInterface/Views/AuditTabContentView.js:
(WI.AuditTabContentView.isTabAllowed):
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
* Localizations/en.lproj/localizedStrings.js:
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (240501 => 240502)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-01-25 21:43:10 UTC (rev 240501)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-01-25 21:49:03 UTC (rev 240502)
@@ -1,5 +1,30 @@
2019-01-25 Devin Rousso <[email protected]>
+ Web Inspector: Audit: remove experimental setting
+ https://bugs.webkit.org/show_bug.cgi?id=193743
+ <rdar://problem/28234022>
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Base/Setting.js:
+ (WI.Setting):
+ (WI.Setting.localStorageKey): Added.
+ (WI.Setting.migrateValue):
+ Drive-by: add the localStorage key prefix to the key passed into `WI.Setting.migrateValue`.
+
+ * UserInterface/Base/Main.js:
+ (WI.loaded):
+
+ * UserInterface/Views/AuditTabContentView.js:
+ (WI.AuditTabContentView.isTabAllowed):
+
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+
+ * Localizations/en.lproj/localizedStrings.js:
+
+2019-01-25 Devin Rousso <[email protected]>
+
Web Inspector: show uncaught exception view for unhandled promise rejections
https://bugs.webkit.org/show_bug.cgi?id=193832
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (240501 => 240502)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-01-25 21:43:10 UTC (rev 240501)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-01-25 21:49:03 UTC (rev 240502)
@@ -133,7 +133,6 @@
localizedStrings["Audit"] = "Audit";
localizedStrings["Audit Error: %s"] = "Audit Error: %s";
localizedStrings["Audit Warning: %s"] = "Audit Warning: %s";
-localizedStrings["Audit:"] = "Audit:";
localizedStrings["Audits"] = "Audits";
localizedStrings["Author Stylesheet"] = "Author Stylesheet";
localizedStrings["Auto Increment"] = "Auto Increment";
@@ -361,7 +360,6 @@
localizedStrings["Element may overlap another compositing element"] = "Element may overlap another compositing element";
localizedStrings["Element overlaps other compositing element"] = "Element overlaps other compositing element";
localizedStrings["Elements"] = "Elements";
-localizedStrings["Enable Audit Tab"] = "Enable Audit Tab";
localizedStrings["Enable Breakpoint"] = "Enable Breakpoint";
localizedStrings["Enable Breakpoints"] = "Enable Breakpoints";
localizedStrings["Enable Computed Style Cascades"] = "Enable Computed Style Cascades";
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (240501 => 240502)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2019-01-25 21:43:10 UTC (rev 240501)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2019-01-25 21:49:03 UTC (rev 240502)
@@ -148,6 +148,7 @@
WI.TimelineTabContentView.Type,
WI.StorageTabContentView.Type,
WI.CanvasTabContentView.Type,
+ WI.AuditTabContentView.Type,
WI.ConsoleTabContentView.Type,
]);
this._selectedTabIndexSetting = new WI.Setting("selected-tab-index", 0);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js (240501 => 240502)
--- trunk/Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js 2019-01-25 21:43:10 UTC (rev 240501)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js 2019-01-25 21:49:03 UTC (rev 240502)
@@ -49,7 +49,7 @@
static isTabAllowed()
{
- return !!window.RuntimeAgent && WI.settings.experimentalEnableAuditTab.value;
+ return WI.sharedApp.debuggableType === WI.DebuggableType.Web;
}
// Public
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (240501 => 240502)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2019-01-25 21:43:10 UTC (rev 240501)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2019-01-25 21:49:03 UTC (rev 240502)
@@ -264,9 +264,6 @@
experimentalSettingsView.addSeparator();
}
- experimentalSettingsView.addSetting(WI.UIString("Audit:"), WI.settings.experimentalEnableAuditTab, WI.UIString("Enable Audit Tab"));
- experimentalSettingsView.addSeparator();
-
experimentalSettingsView.addSetting(WI.UIString("User Interface:"), WI.settings.experimentalEnableNewTabBar, WI.UIString("Enable New Tab Bar"));
experimentalSettingsView.addSeparator();
@@ -277,8 +274,6 @@
let newTabs = WI._openTabsSetting.value.slice();
if (!initialValues.get(WI.settings.experimentalEnableLayersTab) && window.LayerTreeAgent && WI.settings.experimentalEnableLayersTab.value)
newTabs.push(WI.LayersTabContentView.Type);
- if (!initialValues.get(WI.settings.experimentalEnableAuditTab) && WI.settings.experimentalEnableAuditTab.value)
- newTabs.push(WI.AuditTabContentView.Type);
WI._openTabsSetting.value = newTabs;
InspectorFrontendHost.reopen();
@@ -296,7 +291,6 @@
listenForChange(WI.settings.experimentalEnableComputedStyleCascades);
listenForChange(WI.settings.experimentalEnableLayersTab);
- listenForChange(WI.settings.experimentalEnableAuditTab);
listenForChange(WI.settings.experimentalEnableNewTabBar);
this.addSettingsView(experimentalSettingsView);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
