Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (240524 => 240525)
--- trunk/Source/_javascript_Core/ChangeLog 2019-01-25 23:49:38 UTC (rev 240524)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-01-25 23:52:51 UTC (rev 240525)
@@ -1,3 +1,30 @@
+2019-01-25 Keith Rollin <[email protected]>
+
+ Update Xcode projects with "Check .xcfilelists" build phase
+ https://bugs.webkit.org/show_bug.cgi?id=193790
+ <rdar://problem/47201374>
+
+ Reviewed by Alex Christensen.
+
+ Support for XCBuild includes specifying inputs and outputs to various
+ Run Script build phases. These inputs and outputs are specified as
+ .xcfilelist files. Once created, these .xcfilelist files need to be
+ kept up-to-date. In order to check that they are up-to-date or not,
+ add an Xcode build step that invokes an external script that performs
+ the checking. If the .xcfilelists are found to be out-of-date, update
+ them, halt the build, and instruct the developer to restart the build
+ with up-to-date files.
+
+ At this time, the checking and regenerating is performed only if the
+ WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
+ who want to use this facility can set this variable and test out the
+ checking/regenerating. Once it seems like there are no egregious
+ issues that upset a developer's workflow, we'll unconditionally enable
+ this facility.
+
+ * _javascript_Core.xcodeproj/project.pbxproj:
+ * Scripts/check-xcfilelists.sh: Added.
+
2019-01-25 Joseph Pecoraro <[email protected]>
Web Inspector: Exclude Debugger Threads from CPU Usage values in Web Inspector
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (240524 => 240525)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2019-01-25 23:49:38 UTC (rev 240524)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2019-01-25 23:52:51 UTC (rev 240525)
@@ -10022,6 +10022,7 @@
3713F014142905240036387F /* Check For Inappropriate Objective-C Class Names */,
A55DEAA416703DF7003DB841 /* Check For Inappropriate Macros in External Headers */,
1A02D9A81B34A882000D1522 /* Add Symlink in /System/Library/PrivateFrameworks */,
+ 53609F9021DFFA9C008FA60A /* Check .xcfilelists */,
);
buildRules = (
);
@@ -10238,6 +10239,24 @@
shellPath = /bin/sh;
shellScript = "eval \"${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}\"\n";
};
+ 53609F9021DFFA9C008FA60A /* Check .xcfilelists */ = {
+ isa = PBXShellScriptBuildPhase;
+ buildActionMask = 2147483647;
+ files = (
+ );
+ inputFileListPaths = (
+ );
+ inputPaths = (
+ );
+ name = "Check .xcfilelists";
+ outputFileListPaths = (
+ );
+ outputPaths = (
+ );
+ runOnlyForDeploymentPostprocessing = 0;
+ shellPath = /bin/sh;
+ shellScript = "Scripts/check-xcfilelists.sh\n";
+ };
53B4BD091F68AF8900D2BEA3 /* Generate Unified Sources */ = {
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
Added: trunk/Source/_javascript_Core/Scripts/check-xcfilelists.sh (0 => 240525)
--- trunk/Source/_javascript_Core/Scripts/check-xcfilelists.sh (rev 0)
+++ trunk/Source/_javascript_Core/Scripts/check-xcfilelists.sh 2019-01-25 23:52:51 UTC (rev 240525)
@@ -0,0 +1,11 @@
+#!/bin/sh
+
+[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
+[ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
+[ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
+
+SCRIPT="${BUILD_SCRIPTS_DIR}/generate-xcfilelists"
+[ -f "${SCRIPT}" ] || SCRIPT="${PROJECT_DIR}/../../Tools/Scripts/generate-xcfilelists"
+[ -f "${SCRIPT}" ] || { echo "### Cannot find generate-xcfilelists script"; exit 1; }
+
+"${SCRIPT}" generate-xcode --project _javascript_Core --platform "${PLATFORM_NAME}" --configuration "${CONFIGURATION}"
Property changes on: trunk/Source/_javascript_Core/Scripts/check-xcfilelists.sh
___________________________________________________________________
Added: svn:executable
+*
\ No newline at end of property
Modified: trunk/Source/WebCore/ChangeLog (240524 => 240525)
--- trunk/Source/WebCore/ChangeLog 2019-01-25 23:49:38 UTC (rev 240524)
+++ trunk/Source/WebCore/ChangeLog 2019-01-25 23:52:51 UTC (rev 240525)
@@ -1,3 +1,32 @@
+2019-01-25 Keith Rollin <[email protected]>
+
+ Update Xcode projects with "Check .xcfilelists" build phase
+ https://bugs.webkit.org/show_bug.cgi?id=193790
+ <rdar://problem/47201374>
+
+ Reviewed by Alex Christensen.
+
+ Support for XCBuild includes specifying inputs and outputs to various
+ Run Script build phases. These inputs and outputs are specified as
+ .xcfilelist files. Once created, these .xcfilelist files need to be
+ kept up-to-date. In order to check that they are up-to-date or not,
+ add an Xcode build step that invokes an external script that performs
+ the checking. If the .xcfilelists are found to be out-of-date, update
+ them, halt the build, and instruct the developer to restart the build
+ with up-to-date files.
+
+ At this time, the checking and regenerating is performed only if the
+ WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
+ who want to use this facility can set this variable and test out the
+ checking/regenerating. Once it seems like there are no egregious
+ issues that upset a developer's workflow, we'll unconditionally enable
+ this facility.
+
+ No new tests since there should be no observable behavior difference.
+
+ * Scripts/check-xcfilelists.sh: Added.
+ * WebCore.xcodeproj/project.pbxproj:
+
2019-01-25 Joseph Pecoraro <[email protected]>
Web Inspector: Exclude Debugger Threads from CPU Usage values in Web Inspector
Added: trunk/Source/WebCore/Scripts/check-xcfilelists.sh (0 => 240525)
--- trunk/Source/WebCore/Scripts/check-xcfilelists.sh (rev 0)
+++ trunk/Source/WebCore/Scripts/check-xcfilelists.sh 2019-01-25 23:52:51 UTC (rev 240525)
@@ -0,0 +1,11 @@
+#!/bin/sh
+
+[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
+[ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
+[ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
+
+SCRIPT="${BUILD_SCRIPTS_DIR}/generate-xcfilelists"
+[ -f "${SCRIPT}" ] || SCRIPT="${PROJECT_DIR}/../../Tools/Scripts/generate-xcfilelists"
+[ -f "${SCRIPT}" ] || { echo "### Cannot find generate-xcfilelists script"; exit 1; }
+
+"${SCRIPT}" generate-xcode --project WebCore --platform "${PLATFORM_NAME}" --configuration "${CONFIGURATION}"
Property changes on: trunk/Source/WebCore/Scripts/check-xcfilelists.sh
___________________________________________________________________
Added: svn:executable
+*
\ No newline at end of property
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (240524 => 240525)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2019-01-25 23:49:38 UTC (rev 240524)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2019-01-25 23:52:51 UTC (rev 240525)
@@ -32423,6 +32423,7 @@
37A1EAA3142699BC0087F425 /* Check For Inappropriate Objective-C Class Names */,
5DF50887116F3077005202AB /* Check For Inappropriate Files In Framework */,
71D6AA381DA4E69400B23969 /* Copy modern media controls code and assets */,
+ 5379C7AA21E5287100E4A8F6 /* Check .xcfilelists */,
);
buildRules = (
);
@@ -32602,6 +32603,24 @@
shellPath = /bin/sh;
shellScript = "Scripts/generate-unified-sources.sh\n";
};
+ 5379C7AA21E5287100E4A8F6 /* Check .xcfilelists */ = {
+ isa = PBXShellScriptBuildPhase;
+ buildActionMask = 2147483647;
+ files = (
+ );
+ inputFileListPaths = (
+ );
+ inputPaths = (
+ );
+ name = "Check .xcfilelists";
+ outputFileListPaths = (
+ );
+ outputPaths = (
+ );
+ runOnlyForDeploymentPostprocessing = 0;
+ shellPath = /bin/sh;
+ shellScript = "Scripts/check-xcfilelists.sh\n";
+ };
5D0D540D0E9862F60029E223 /* Check For Weak VTables and Externals */ = {
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
Modified: trunk/Source/WebKit/ChangeLog (240524 => 240525)
--- trunk/Source/WebKit/ChangeLog 2019-01-25 23:49:38 UTC (rev 240524)
+++ trunk/Source/WebKit/ChangeLog 2019-01-25 23:52:51 UTC (rev 240525)
@@ -1,3 +1,30 @@
+2019-01-25 Keith Rollin <[email protected]>
+
+ Update Xcode projects with "Check .xcfilelists" build phase
+ https://bugs.webkit.org/show_bug.cgi?id=193790
+ <rdar://problem/47201374>
+
+ Reviewed by Alex Christensen.
+
+ Support for XCBuild includes specifying inputs and outputs to various
+ Run Script build phases. These inputs and outputs are specified as
+ .xcfilelist files. Once created, these .xcfilelist files need to be
+ kept up-to-date. In order to check that they are up-to-date or not,
+ add an Xcode build step that invokes an external script that performs
+ the checking. If the .xcfilelists are found to be out-of-date, update
+ them, halt the build, and instruct the developer to restart the build
+ with up-to-date files.
+
+ At this time, the checking and regenerating is performed only if the
+ WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
+ who want to use this facility can set this variable and test out the
+ checking/regenerating. Once it seems like there are no egregious
+ issues that upset a developer's workflow, we'll unconditionally enable
+ this facility.
+
+ * Scripts/check-xcfilelists.sh: Added.
+ * WebKit.xcodeproj/project.pbxproj:
+
2019-01-25 Alex Christensen <[email protected]>
Move logic from ChildProcess::setApplicationIsDaemon to NetworkProcess::initializeProcess
Added: trunk/Source/WebKit/Scripts/check-xcfilelists.sh (0 => 240525)
--- trunk/Source/WebKit/Scripts/check-xcfilelists.sh (rev 0)
+++ trunk/Source/WebKit/Scripts/check-xcfilelists.sh 2019-01-25 23:52:51 UTC (rev 240525)
@@ -0,0 +1,11 @@
+#!/bin/sh
+
+[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
+[ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
+[ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
+
+SCRIPT="${BUILD_SCRIPTS_DIR}/generate-xcfilelists"
+[ -f "${SCRIPT}" ] || SCRIPT="${PROJECT_DIR}/../../Tools/Scripts/generate-xcfilelists"
+[ -f "${SCRIPT}" ] || { echo "### Cannot find generate-xcfilelists script"; exit 1; }
+
+"${SCRIPT}" generate-xcode --project WebKit --platform "${PLATFORM_NAME}" --configuration "${CONFIGURATION}"
Property changes on: trunk/Source/WebKit/Scripts/check-xcfilelists.sh
___________________________________________________________________
Added: svn:executable
+*
\ No newline at end of property
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (240524 => 240525)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2019-01-25 23:49:38 UTC (rev 240524)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2019-01-25 23:52:51 UTC (rev 240525)
@@ -10048,6 +10048,7 @@
5DF408D1131DDBEC00130071 /* Check For Inappropriate Files In Framework */,
A55DEAA61670402E003DB841 /* Check For Inappropriate Macros in External Headers */,
1A2180161B5454620046AEC4 /* Add Symlink in /System/Library/PrivateFrameworks */,
+ 5379C7AC21E5288500E4A8F6 /* Check .xcfilelists */,
);
buildRules = (
);
@@ -10483,6 +10484,24 @@
shellPath = /bin/sh;
shellScript = "eval \"${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}\"\n";
};
+ 5379C7AC21E5288500E4A8F6 /* Check .xcfilelists */ = {
+ isa = PBXShellScriptBuildPhase;
+ buildActionMask = 2147483647;
+ files = (
+ );
+ inputFileListPaths = (
+ );
+ inputPaths = (
+ );
+ name = "Check .xcfilelists";
+ outputFileListPaths = (
+ );
+ outputPaths = (
+ );
+ runOnlyForDeploymentPostprocessing = 0;
+ shellPath = /bin/sh;
+ shellScript = "Scripts/check-xcfilelists.sh\n";
+ };
5DF408C5131DD46700130071 /* Check For Weak VTables and Externals */ = {
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
Modified: trunk/Tools/ChangeLog (240524 => 240525)
--- trunk/Tools/ChangeLog 2019-01-25 23:49:38 UTC (rev 240524)
+++ trunk/Tools/ChangeLog 2019-01-25 23:52:51 UTC (rev 240525)
@@ -1,5 +1,34 @@
2019-01-25 Keith Rollin <[email protected]>
+ Update Xcode projects with "Check .xcfilelists" build phase
+ https://bugs.webkit.org/show_bug.cgi?id=193790
+ <rdar://problem/47201374>
+
+ Reviewed by Alex Christensen.
+
+ Support for XCBuild includes specifying inputs and outputs to various
+ Run Script build phases. These inputs and outputs are specified as
+ .xcfilelist files. Once created, these .xcfilelist files need to be
+ kept up-to-date. In order to check that they are up-to-date or not,
+ add an Xcode build step that invokes an external script that performs
+ the checking. If the .xcfilelists are found to be out-of-date, update
+ them, halt the build, and instruct the developer to restart the build
+ with up-to-date files.
+
+ At this time, the checking and regenerating is performed only if the
+ WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
+ who want to use this facility can set this variable and test out the
+ checking/regenerating. Once it seems like there are no egregious
+ issues that upset a developer's workflow, we'll unconditionally enable
+ this facility.
+
+ * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
+ * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
+ * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
+ * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
+
+2019-01-25 Keith Rollin <[email protected]>
+
Update Xcode projects with "Apply Configuration to XCFileLists" build target
https://bugs.webkit.org/show_bug.cgi?id=193781
<rdar://problem/47201153>
Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj (240524 => 240525)
--- trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj 2019-01-25 23:49:38 UTC (rev 240524)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj 2019-01-25 23:52:51 UTC (rev 240525)
@@ -953,6 +953,7 @@
buildConfigurationList = A1321C9F188F9A3600125434 /* Build configuration list for PBXNativeTarget "DumpRenderTree (Library)" */;
buildPhases = (
9340994D08540CAE007F3BC8 /* Sources */,
+ 53A8193B21E52997000B93AB /* Check .xcfilelists */,
);
buildRules = (
);
@@ -1054,6 +1055,24 @@
shellPath = /bin/sh;
shellScript = "eval \"${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}\"\n";
};
+ 53A8193B21E52997000B93AB /* Check .xcfilelists */ = {
+ isa = PBXShellScriptBuildPhase;
+ buildActionMask = 2147483647;
+ files = (
+ );
+ inputFileListPaths = (
+ );
+ inputPaths = (
+ );
+ name = "Check .xcfilelists";
+ outputFileListPaths = (
+ );
+ outputPaths = (
+ );
+ runOnlyForDeploymentPostprocessing = 0;
+ shellPath = /bin/sh;
+ shellScript = "Scripts/check-xcfilelists.sh\n";
+ };
/* End PBXShellScriptBuildPhase section */
/* Begin PBXSourcesBuildPhase section */
Added: trunk/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh (0 => 240525)
--- trunk/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh (rev 0)
+++ trunk/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh 2019-01-25 23:52:51 UTC (rev 240525)
@@ -0,0 +1,11 @@
+#!/bin/sh
+
+[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
+[ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
+[ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
+
+SCRIPT="${BUILD_SCRIPTS_DIR}/generate-xcfilelists"
+[ -f "${SCRIPT}" ] || SCRIPT="${PROJECT_DIR}/../../Tools/Scripts/generate-xcfilelists"
+[ -f "${SCRIPT}" ] || { echo "### Cannot find generate-xcfilelists script"; exit 1; }
+
+"${SCRIPT}" generate-xcode --project DumpRenderTree --platform "${PLATFORM_NAME}" --configuration "${CONFIGURATION}"
Property changes on: trunk/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh
___________________________________________________________________
Added: svn:executable
+*
\ No newline at end of property
Added: trunk/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh (0 => 240525)
--- trunk/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh (rev 0)
+++ trunk/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh 2019-01-25 23:52:51 UTC (rev 240525)
@@ -0,0 +1,11 @@
+#!/bin/sh
+
+[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
+[ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
+[ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
+
+SCRIPT="${BUILD_SCRIPTS_DIR}/generate-xcfilelists"
+[ -f "${SCRIPT}" ] || SCRIPT="${PROJECT_DIR}/../../Tools/Scripts/generate-xcfilelists"
+[ -f "${SCRIPT}" ] || { echo "### Cannot find generate-xcfilelists script"; exit 1; }
+
+"${SCRIPT}" generate-xcode --project WebKitTestRunner --platform "${PLATFORM_NAME}" --configuration "${CONFIGURATION}"
Property changes on: trunk/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh
___________________________________________________________________
Added: svn:executable
+*
\ No newline at end of property
Modified: trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj (240524 => 240525)
--- trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj 2019-01-25 23:49:38 UTC (rev 240524)
+++ trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj 2019-01-25 23:52:51 UTC (rev 240525)
@@ -952,6 +952,7 @@
BC25185E11D15D54002EBC01 /* Resources */,
BC25185F11D15D54002EBC01 /* Sources */,
BC25186011D15D54002EBC01 /* Frameworks */,
+ 53A8193A21E52973000B93AB /* Check .xcfilelists */,
);
buildRules = (
);
@@ -1059,6 +1060,24 @@
shellPath = /bin/sh;
shellScript = "eval \"${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}\"\n";
};
+ 53A8193A21E52973000B93AB /* Check .xcfilelists */ = {
+ isa = PBXShellScriptBuildPhase;
+ buildActionMask = 2147483647;
+ files = (
+ );
+ inputFileListPaths = (
+ );
+ inputPaths = (
+ );
+ name = "Check .xcfilelists";
+ outputFileListPaths = (
+ );
+ outputPaths = (
+ );
+ runOnlyForDeploymentPostprocessing = 0;
+ shellPath = /bin/sh;
+ shellScript = "Scripts/check-xcfilelists.sh\n";
+ };
BC952D8211F3BF78003398B4 /* Generate Derived Sources */ = {
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
