Title: [240531] trunk/Source/WebKit
- Revision
- 240531
- Author
- [email protected]
- Date
- 2019-01-25 16:44:42 -0800 (Fri, 25 Jan 2019)
Log Message
Find-in-page on nyt.com scrolls around without touching the screen when find holes are visible
https://bugs.webkit.org/show_bug.cgi?id=193853
Reviewed by Simon Fraser.
* WebProcess/WebPage/ios/FindControllerIOS.mm:
(WebKit::FindController::updateFindIndicator):
There is no reason to scroll/zoom to the find indicator just because the
holes are up, we should only do it on initial indicator presentation.
This was a mistake in r178755 that was previously never exercised because
isShowingOverlay was always false.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (240530 => 240531)
--- trunk/Source/WebKit/ChangeLog 2019-01-26 00:44:15 UTC (rev 240530)
+++ trunk/Source/WebKit/ChangeLog 2019-01-26 00:44:42 UTC (rev 240531)
@@ -1,3 +1,17 @@
+2019-01-25 Tim Horton <[email protected]>
+
+ Find-in-page on nyt.com scrolls around without touching the screen when find holes are visible
+ https://bugs.webkit.org/show_bug.cgi?id=193853
+
+ Reviewed by Simon Fraser.
+
+ * WebProcess/WebPage/ios/FindControllerIOS.mm:
+ (WebKit::FindController::updateFindIndicator):
+ There is no reason to scroll/zoom to the find indicator just because the
+ holes are up, we should only do it on initial indicator presentation.
+ This was a mistake in r178755 that was previously never exercised because
+ isShowingOverlay was always false.
+
2019-01-25 Keith Rollin <[email protected]>
Update Xcode projects with "Check .xcfilelists" build phase
Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/FindControllerIOS.mm (240530 => 240531)
--- trunk/Source/WebKit/WebProcess/WebPage/ios/FindControllerIOS.mm 2019-01-26 00:44:15 UTC (rev 240530)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/FindControllerIOS.mm 2019-01-26 00:44:42 UTC (rev 240531)
@@ -105,7 +105,7 @@
m_findIndicatorOverlay->setFrame(enclosingIntRect(textIndicator->textBoundingRectInRootViewCoordinates()));
m_findIndicatorOverlay->setNeedsDisplay();
- if (isShowingOverlay || shouldAnimate) {
+ if (shouldAnimate) {
FloatRect visibleContentRect = m_webPage->mainFrameView()->unobscuredContentRectIncludingScrollbars();
bool isReplaced;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
