Title: [240679] trunk/Source/_javascript_Core
Revision
240679
Author
[email protected]
Date
2019-01-29 13:55:51 -0800 (Tue, 29 Jan 2019)

Log Message

[JSC] FTL should handle LocalAllocator*
https://bugs.webkit.org/show_bug.cgi?id=193980

Reviewed by Saam Barati.

At some point, Allocator holds LocalAllocator* instead of 32bit integer. In FTL allocation path, we fail to use this constant LocalAllocator*
because the FTL still use the incoming value as 32bit integer there.

* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::allocateHeapCell):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (240678 => 240679)


--- trunk/Source/_javascript_Core/ChangeLog	2019-01-29 21:38:26 UTC (rev 240678)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-01-29 21:55:51 UTC (rev 240679)
@@ -1,3 +1,16 @@
+2019-01-29  Yusuke Suzuki  <[email protected]>
+
+        [JSC] FTL should handle LocalAllocator*
+        https://bugs.webkit.org/show_bug.cgi?id=193980
+
+        Reviewed by Saam Barati.
+
+        At some point, Allocator holds LocalAllocator* instead of 32bit integer. In FTL allocation path, we fail to use this constant LocalAllocator*
+        because the FTL still use the incoming value as 32bit integer there.
+
+        * ftl/FTLLowerDFGToB3.cpp:
+        (JSC::FTL::DFG::LowerDFGToB3::allocateHeapCell):
+
 2019-01-29  Keith Rollin  <[email protected]>
 
         Add .xcfilelists to Run Script build phases

Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (240678 => 240679)


--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2019-01-29 21:38:26 UTC (rev 240678)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2019-01-29 21:55:51 UTC (rev 240679)
@@ -13041,7 +13041,7 @@
     LValue allocateHeapCell(LValue allocator, LBasicBlock slowPath)
     {
         JITAllocator actualAllocator;
-        if (allocator->hasInt32())
+        if (allocator->hasIntPtr())
             actualAllocator = JITAllocator::constant(Allocator(bitwise_cast<LocalAllocator*>(allocator->asIntPtr())));
         else
             actualAllocator = JITAllocator::variable();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to