Title: [240699] trunk/Source/WebInspectorUI
- Revision
- 240699
- Author
- [email protected]
- Date
- 2019-01-29 17:57:45 -0800 (Tue, 29 Jan 2019)
Log Message
Web Inspector: Enabled Changes panel in Elements tab by default
https://bugs.webkit.org/show_bug.cgi?id=193986
<rdar://problem/47647683>
Reviewed by Matt Baker.
* UserInterface/Base/Setting.js:
* UserInterface/Views/ElementsTabContentView.js:
(WI.ElementsTabContentView):
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (240698 => 240699)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-01-30 01:55:52 UTC (rev 240698)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-01-30 01:57:45 UTC (rev 240699)
@@ -1,5 +1,19 @@
2019-01-29 Nikita Vasilyev <[email protected]>
+ Web Inspector: Enabled Changes panel in Elements tab by default
+ https://bugs.webkit.org/show_bug.cgi?id=193986
+ <rdar://problem/47647683>
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Base/Setting.js:
+ * UserInterface/Views/ElementsTabContentView.js:
+ (WI.ElementsTabContentView):
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+
+2019-01-29 Nikita Vasilyev <[email protected]>
+
Web Inspector: Styles: enable computed style cascades by default
https://bugs.webkit.org/show_bug.cgi?id=193983
<rdar://problem/47645821>
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (240698 => 240699)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2019-01-30 01:55:52 UTC (rev 240698)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2019-01-30 01:57:45 UTC (rev 240699)
@@ -152,7 +152,6 @@
zoomFactor: new WI.Setting("zoom-factor", 1),
// Experimental
- experimentalEnableChangesPanel: new WI.Setting("experimental-enable-changes-panel", false),
experimentalEnableLayersTab: new WI.Setting("experimental-enable-layers-tab", false),
experimentalEnableNewTabBar: new WI.Setting("experimental-enable-new-tab-bar", false),
experimentalEnableAuditTab: new WI.Setting("experimental-enable-audit-tab", false),
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js (240698 => 240699)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js 2019-01-30 01:55:52 UTC (rev 240698)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js 2019-01-30 01:57:45 UTC (rev 240699)
@@ -29,10 +29,7 @@
{
let tabBarItem = WI.GeneralTabBarItem.fromTabInfo(WI.ElementsTabContentView.tabInfo());
- let detailsSidebarPanelConstructors = [WI.RulesStyleDetailsSidebarPanel, WI.ComputedStyleDetailsSidebarPanel];
- if (WI.settings.experimentalEnableChangesPanel.value)
- detailsSidebarPanelConstructors.push(WI.ChangesDetailsSidebarPanel);
- detailsSidebarPanelConstructors.push(WI.DOMNodeDetailsSidebarPanel);
+ let detailsSidebarPanelConstructors = [WI.RulesStyleDetailsSidebarPanel, WI.ComputedStyleDetailsSidebarPanel, WI.ChangesDetailsSidebarPanel, WI.DOMNodeDetailsSidebarPanel];
if (window.LayerTreeAgent)
detailsSidebarPanelConstructors.push(WI.LayerTreeDetailsSidebarPanel);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (240698 => 240699)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2019-01-30 01:55:52 UTC (rev 240698)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2019-01-30 01:57:45 UTC (rev 240699)
@@ -253,12 +253,6 @@
let initialValues = new Map;
- if (window.CSSAgent) {
- let group = experimentalSettingsView.addGroup(WI.UIString("Styles Sidebar:"));
- group.addSetting(WI.settings.experimentalEnableChangesPanel, WI.UIString("Enable Changes Panel"));
- experimentalSettingsView.addSeparator();
- }
-
if (window.LayerTreeAgent) {
experimentalSettingsView.addSetting(WI.UIString("Layers:"), WI.settings.experimentalEnableLayersTab, WI.UIString("Enable Layers Tab"));
experimentalSettingsView.addSeparator();
@@ -289,7 +283,6 @@
});
}
- listenForChange(WI.settings.experimentalEnableChangesPanel);
listenForChange(WI.settings.experimentalEnableLayersTab);
listenForChange(WI.settings.experimentalEnableNewTabBar);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
