Title: [240702] trunk/Source/WebKit
- Revision
- 240702
- Author
- [email protected]
- Date
- 2019-01-29 18:55:03 -0800 (Tue, 29 Jan 2019)
Log Message
iOS: Nullptr crash in WebPage::getPositionInformation dereferencing an input element for data list
https://bugs.webkit.org/show_bug.cgi?id=193996
Reviewed by Wenson Hsieh.
Added a missing nullptr check.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (240701 => 240702)
--- trunk/Source/WebKit/ChangeLog 2019-01-30 02:03:39 UTC (rev 240701)
+++ trunk/Source/WebKit/ChangeLog 2019-01-30 02:55:03 UTC (rev 240702)
@@ -1,3 +1,15 @@
+2019-01-29 Ryosuke Niwa <[email protected]>
+
+ iOS: Nullptr crash in WebPage::getPositionInformation dereferencing an input element for data list
+ https://bugs.webkit.org/show_bug.cgi?id=193996
+
+ Reviewed by Wenson Hsieh.
+
+ Added a missing nullptr check.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::getPositionInformation):
+
2019-01-29 Simon Fraser <[email protected]>
Add nodes to the scrolling tree in z-index order.
Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (240701 => 240702)
--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2019-01-30 02:03:39 UTC (rev 240701)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2019-01-30 02:55:03 UTC (rev 240702)
@@ -2248,7 +2248,7 @@
// Prevent the callout bar from showing when tapping on the datalist button.
#if ENABLE(DATALIST_ELEMENT)
- if (is<HTMLInputElement>(*hitNode)) {
+ if (is<HTMLInputElement>(hitNode)) {
const HTMLInputElement& input = downcast<HTMLInputElement>(*hitNode);
if (input.list()) {
HitTestResult result = m_page->mainFrame().eventHandler().hitTestResultAtPoint(request.point, HitTestRequest::ReadOnly | HitTestRequest::Active);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
