Title: [240732] trunk/Source/_javascript_Core
- Revision
- 240732
- Author
- [email protected]
- Date
- 2019-01-30 14:56:46 -0800 (Wed, 30 Jan 2019)
Log Message
CachedBytecode's move constructor should not call `freeDataIfOwned`
https://bugs.webkit.org/show_bug.cgi?id=194045
Reviewed by Mark Lam.
That might result in freeing a garbage value
* parser/SourceProvider.h:
(JSC::CachedBytecode::CachedBytecode):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (240731 => 240732)
--- trunk/Source/_javascript_Core/ChangeLog 2019-01-30 22:42:11 UTC (rev 240731)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-01-30 22:56:46 UTC (rev 240732)
@@ -1,3 +1,15 @@
+2019-01-30 Tadeu Zagallo <[email protected]>
+
+ CachedBytecode's move constructor should not call `freeDataIfOwned`
+ https://bugs.webkit.org/show_bug.cgi?id=194045
+
+ Reviewed by Mark Lam.
+
+ That might result in freeing a garbage value
+
+ * parser/SourceProvider.h:
+ (JSC::CachedBytecode::CachedBytecode):
+
2019-01-30 Keith Miller <[email protected]>
mul32 should convert powers of 2 to an lshift
Modified: trunk/Source/_javascript_Core/parser/SourceProvider.h (240731 => 240732)
--- trunk/Source/_javascript_Core/parser/SourceProvider.h 2019-01-30 22:42:11 UTC (rev 240731)
+++ trunk/Source/_javascript_Core/parser/SourceProvider.h 2019-01-30 22:56:46 UTC (rev 240732)
@@ -67,7 +67,10 @@
CachedBytecode(CachedBytecode&& other)
{
- *this = WTFMove(other);
+ m_owned = other.m_owned;
+ m_size = other.m_size;
+ m_data = other.m_data;
+ other.m_owned = false;
}
CachedBytecode& operator=(CachedBytecode&& other)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
