Title: [240739] trunk/Source/_javascript_Core
- Revision
- 240739
- Author
- [email protected]
- Date
- 2019-01-30 16:46:59 -0800 (Wed, 30 Jan 2019)
Log Message
Remove assertion that CachedSymbolTables should have no RareData
https://bugs.webkit.org/show_bug.cgi?id=194037
Reviewed by Mark Lam.
It turns out that we don't need to cache the SymbolTableRareData and
we should not assert that it's empty.
* runtime/CachedTypes.cpp:
(JSC::CachedSymbolTable::encode):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (240738 => 240739)
--- trunk/Source/_javascript_Core/ChangeLog 2019-01-31 00:33:41 UTC (rev 240738)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-01-31 00:46:59 UTC (rev 240739)
@@ -1,5 +1,18 @@
2019-01-30 Tadeu Zagallo <[email protected]>
+ Remove assertion that CachedSymbolTables should have no RareData
+ https://bugs.webkit.org/show_bug.cgi?id=194037
+
+ Reviewed by Mark Lam.
+
+ It turns out that we don't need to cache the SymbolTableRareData and
+ we should not assert that it's empty.
+
+ * runtime/CachedTypes.cpp:
+ (JSC::CachedSymbolTable::encode):
+
+2019-01-30 Tadeu Zagallo <[email protected]>
+
CachedBytecode's move constructor should not call `freeDataIfOwned`
https://bugs.webkit.org/show_bug.cgi?id=194045
Modified: trunk/Source/_javascript_Core/runtime/CachedTypes.cpp (240738 => 240739)
--- trunk/Source/_javascript_Core/runtime/CachedTypes.cpp 2019-01-31 00:33:41 UTC (rev 240738)
+++ trunk/Source/_javascript_Core/runtime/CachedTypes.cpp 2019-01-31 00:46:59 UTC (rev 240739)
@@ -906,7 +906,6 @@
public:
void encode(Encoder& encoder, const SymbolTable& symbolTable)
{
- ASSERT(!symbolTable.m_rareData);
m_map.encode(encoder, symbolTable.m_map);
m_maxScopeOffset = symbolTable.m_maxScopeOffset;
m_usesNonStrictEval = symbolTable.m_usesNonStrictEval;
@@ -935,8 +934,6 @@
unsigned m_usesNonStrictEval : 1;
unsigned m_nestedLexicalScope : 1;
unsigned m_scopeType : 3;
- // FIXME: do we need to cached this eventually?
- // CachedPtr<SymbolTableRareData> rareData;
CachedPtr<CachedScopedArgumentsTable> m_arguments;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
