Title: [240747] trunk/Source/WebKit
- Revision
- 240747
- Author
- [email protected]
- Date
- 2019-01-30 17:55:27 -0800 (Wed, 30 Jan 2019)
Log Message
Add default constructor for NetworkActivityTracker
https://bugs.webkit.org/show_bug.cgi?id=194058
<rdar://problem/47685457>
Reviewed by Chris Dumez.
ResourceNetworkActivityTracker has a default constructor. It also has
a NetworkActivityTracker data member, which does not have a default
constructor. This will cause some compilers to complain -- they can't
default-create a ResourceNetworkActivityTracker because they can't
default-create its data members. Address this by adding a default
constructor for NetworkActivityTracker.
* NetworkProcess/NetworkActivityTracker.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (240746 => 240747)
--- trunk/Source/WebKit/ChangeLog 2019-01-31 01:52:55 UTC (rev 240746)
+++ trunk/Source/WebKit/ChangeLog 2019-01-31 01:55:27 UTC (rev 240747)
@@ -1,3 +1,20 @@
+2019-01-30 Keith Rollin <[email protected]>
+
+ Add default constructor for NetworkActivityTracker
+ https://bugs.webkit.org/show_bug.cgi?id=194058
+ <rdar://problem/47685457>
+
+ Reviewed by Chris Dumez.
+
+ ResourceNetworkActivityTracker has a default constructor. It also has
+ a NetworkActivityTracker data member, which does not have a default
+ constructor. This will cause some compilers to complain -- they can't
+ default-create a ResourceNetworkActivityTracker because they can't
+ default-create its data members. Address this by adding a default
+ constructor for NetworkActivityTracker.
+
+ * NetworkProcess/NetworkActivityTracker.h:
+
2019-01-30 Daniel Steffen <[email protected]>
<rdar://problem/29471922> Safari should switch from the legacy denap SPI to handling vouchers
Modified: trunk/Source/WebKit/NetworkProcess/NetworkActivityTracker.h (240746 => 240747)
--- trunk/Source/WebKit/NetworkProcess/NetworkActivityTracker.h 2019-01-31 01:52:55 UTC (rev 240746)
+++ trunk/Source/WebKit/NetworkProcess/NetworkActivityTracker.h 2019-01-31 01:55:27 UTC (rev 240747)
@@ -64,7 +64,8 @@
Failure,
};
- NetworkActivityTracker(Label, Domain = Domain::WebKit);
+ NetworkActivityTracker() = default;
+ explicit NetworkActivityTracker(Label, Domain = Domain::WebKit);
~NetworkActivityTracker();
void setParent(NetworkActivityTracker&);
@@ -77,8 +78,8 @@
private:
#if HAVE(NW_ACTIVITY)
- Domain m_domain;
- Label m_label;
+ Domain m_domain { Domain::Invalid };
+ Label m_label { Label::Invalid };
bool m_isCompleted { false };
RetainPtr<nw_activity_t> m_networkActivity;
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
