Title: [240765] trunk
- Revision
- 240765
- Author
- [email protected]
- Date
- 2019-01-30 23:31:21 -0800 (Wed, 30 Jan 2019)
Log Message
Enable swipe tests on iOS
https://bugs.webkit.org/show_bug.cgi?id=194076
Reviewed by Geoffrey Garen.
Tools:
Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
it causes a debug assertion failure in runUIScript.
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::beginBackSwipe):
(WTR::UIScriptController::completeBackSwipe):
LayoutTests:
Enabled tests in LayoutTests/swipe and added iOS specific results for the failing tests.
* platform/ios/TestExpectations:
* platform/ios/swipe/basic-cached-back-swipe-expected.txt: Added.
* platform/ios/swipe/main-frame-pinning-requirement-expected.txt: Added.
* platform/ios/swipe/pushState-cached-back-swipe-expected.txt: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (240764 => 240765)
--- trunk/LayoutTests/ChangeLog 2019-01-31 07:28:38 UTC (rev 240764)
+++ trunk/LayoutTests/ChangeLog 2019-01-31 07:31:21 UTC (rev 240765)
@@ -1,3 +1,17 @@
+2019-01-30 Ryosuke Niwa <[email protected]>
+
+ Enable swipe tests on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=194076
+
+ Reviewed by Geoffrey Garen.
+
+ Enabled tests in LayoutTests/swipe and added iOS specific results for the failing tests.
+
+ * platform/ios/TestExpectations:
+ * platform/ios/swipe/basic-cached-back-swipe-expected.txt: Added.
+ * platform/ios/swipe/main-frame-pinning-requirement-expected.txt: Added.
+ * platform/ios/swipe/pushState-cached-back-swipe-expected.txt: Added.
+
2019-01-30 Chris Dumez <[email protected]>
Regression(PSON) History navigations to twitter.com lead to a 403 HTTP error
Modified: trunk/LayoutTests/platform/ios/TestExpectations (240764 => 240765)
--- trunk/LayoutTests/platform/ios/TestExpectations 2019-01-31 07:28:38 UTC (rev 240764)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2019-01-31 07:31:21 UTC (rev 240765)
@@ -11,6 +11,7 @@
http/tests/quicklook [ Pass ]
media/ios [ Pass ]
quicklook [ Pass ]
+swipe [ Pass ]
fast/text-autosizing/ios [ Pass ]
fast/zooming/ios [ Pass ]
Added: trunk/LayoutTests/platform/ios/swipe/basic-cached-back-swipe-expected.txt (0 => 240765)
--- trunk/LayoutTests/platform/ios/swipe/basic-cached-back-swipe-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/ios/swipe/basic-cached-back-swipe-expected.txt 2019-01-31 07:31:21 UTC (rev 240765)
@@ -0,0 +1,6 @@
+startSwipeGesture
+didBeginSwipe
+completeSwipeGesture
+didEndSwipe
+didRemoveSwipeSnapshot
+
Added: trunk/LayoutTests/platform/ios/swipe/main-frame-pinning-requirement-expected.txt (0 => 240765)
--- trunk/LayoutTests/platform/ios/swipe/main-frame-pinning-requirement-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/ios/swipe/main-frame-pinning-requirement-expected.txt 2019-01-31 07:31:21 UTC (rev 240765)
@@ -0,0 +1,7 @@
+startSwipeGesture
+Failure. Should never begin a swipe, because we were in the middle of a scrolling gesture that started when the main frame was not pinned to the left.
+didEndSwipe
+completeSwipeGesture
+startSwipeGesture
+didRemoveSwipeSnapshot
+
Added: trunk/LayoutTests/platform/ios/swipe/pushState-cached-back-swipe-expected.txt (0 => 240765)
--- trunk/LayoutTests/platform/ios/swipe/pushState-cached-back-swipe-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/ios/swipe/pushState-cached-back-swipe-expected.txt 2019-01-31 07:31:21 UTC (rev 240765)
@@ -0,0 +1,6 @@
+startSwipeGesture
+didBeginSwipe
+completeSwipeGesture
+didEndSwipe
+didRemoveSwipeSnapshot
+
Modified: trunk/Tools/ChangeLog (240764 => 240765)
--- trunk/Tools/ChangeLog 2019-01-31 07:28:38 UTC (rev 240764)
+++ trunk/Tools/ChangeLog 2019-01-31 07:31:21 UTC (rev 240765)
@@ -1,3 +1,17 @@
+2019-01-30 Ryosuke Niwa <[email protected]>
+
+ Enable swipe tests on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=194076
+
+ Reviewed by Geoffrey Garen.
+
+ Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
+ it causes a debug assertion failure in runUIScript.
+
+ * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
+ (WTR::UIScriptController::beginBackSwipe):
+ (WTR::UIScriptController::completeBackSwipe):
+
2019-01-30 Keith Rollin <[email protected]>
Use correct printf format specifier
Modified: trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm (240764 => 240765)
--- trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm 2019-01-31 07:28:38 UTC (rev 240764)
+++ trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm 2019-01-31 07:31:21 UTC (rev 240765)
@@ -822,9 +822,6 @@
{
TestRunnerWKWebView *webView = TestController::singleton().mainWebView()->platformView();
[webView _beginBackSwipeForTesting];
-
- unsigned callbackID = m_context->prepareForAsyncTask(callback, CallbackTypeNonPersistent);
- m_context->asyncTaskComplete(callbackID);
}
void UIScriptController::completeBackSwipe(JSValueRef callback)
@@ -831,9 +828,6 @@
{
TestRunnerWKWebView *webView = TestController::singleton().mainWebView()->platformView();
[webView _completeBackSwipeForTesting];
-
- unsigned callbackID = m_context->prepareForAsyncTask(callback, CallbackTypeNonPersistent);
- m_context->asyncTaskComplete(callbackID);
}
static BOOL forEachViewInHierarchy(UIView *view, void(^mapFunction)(UIView *subview, BOOL *stop))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
