Title: [241112] trunk/Source/WebKit
Revision
241112
Author
cfleiz...@apple.com
Date
2019-02-06 18:53:16 -0800 (Wed, 06 Feb 2019)

Log Message

AX:  com.apple.WebKit.WebContent at WebKit: -[WKAccessibilityWebPageObjectBase axObjectCache]
https://bugs.webkit.org/show_bug.cgi?id=194306
<rdar://problem/47764549>

Reviewed by Zalan Bujtas.

Check the page reference is still valid.
Modernize code in this area.

* WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (241111 => 241112)


--- trunk/Source/WebKit/ChangeLog	2019-02-07 00:42:18 UTC (rev 241111)
+++ trunk/Source/WebKit/ChangeLog	2019-02-07 02:53:16 UTC (rev 241112)
@@ -1,3 +1,16 @@
+2019-02-06  chris fleizach  <cfleiz...@apple.com>
+
+        AX:  com.apple.WebKit.WebContent at WebKit: -[WKAccessibilityWebPageObjectBase axObjectCache]
+        https://bugs.webkit.org/show_bug.cgi?id=194306
+        <rdar://problem/47764549>
+
+        Reviewed by Zalan Bujtas.
+
+        Check the page reference is still valid.
+        Modernize code in this area.
+
+        * WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:
+
 2019-02-06  Daniel Bates  <daba...@apple.com>
 
         Move toNSEventModifierFlags() and toNSButtonNumber() to WebEventFactory.mm

Modified: trunk/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm (241111 => 241112)


--- trunk/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm	2019-02-07 00:42:18 UTC (rev 241111)
+++ trunk/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm	2019-02-07 02:53:16 UTC (rev 241112)
@@ -50,12 +50,16 @@
 
 - (WebCore::AXObjectCache*)axObjectCache
 {
-    WebCore::Page* page = m_page->corePage();
+    if (!m_page)
+        return nullptr;
+
+    auto page = m_page->corePage();
     if (!page)
-        return nil;
-    WebCore::Frame& core = page->mainFrame();
+        return nullptr;
+
+    auto& core = page->mainFrame();
     if (!core.document())
-        return nil;
+        return nullptr;
 
     return core.document()->axObjectCache();
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to