Title: [241492] trunk/Source/WebCore
- Revision
- 241492
- Author
- jer.no...@apple.com
- Date
- 2019-02-13 18:28:48 -0800 (Wed, 13 Feb 2019)
Log Message
[Mac] PiP window can get "stuck" if PiP is closed while Safari window is minimized.
https://bugs.webkit.org/show_bug.cgi?id=194621
<rdar://problem/48002560>
Reviewed by Eric Carlson.
When Safari is minimized, no rAF() requests are executed. Don't gate responding to presentation
change events in the media-controller.js on rAF().
* Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype._returnMediaLayerToInlineIfNeeded):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (241491 => 241492)
--- trunk/Source/WebCore/ChangeLog 2019-02-14 02:28:20 UTC (rev 241491)
+++ trunk/Source/WebCore/ChangeLog 2019-02-14 02:28:48 UTC (rev 241492)
@@ -1,3 +1,17 @@
+2019-02-13 Jer Noble <jer.no...@apple.com>
+
+ [Mac] PiP window can get "stuck" if PiP is closed while Safari window is minimized.
+ https://bugs.webkit.org/show_bug.cgi?id=194621
+ <rdar://problem/48002560>
+
+ Reviewed by Eric Carlson.
+
+ When Safari is minimized, no rAF() requests are executed. Don't gate responding to presentation
+ change events in the media-controller.js on rAF().
+
+ * Modules/modern-media-controls/media/media-controller.js:
+ (MediaController.prototype._returnMediaLayerToInlineIfNeeded):
+
2019-02-13 John Wilander <wilan...@apple.com>
Ignore Ad Click Attribution where source and destination are same-site
Modified: trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js (241491 => 241492)
--- trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js 2019-02-14 02:28:20 UTC (rev 241491)
+++ trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js 2019-02-14 02:28:48 UTC (rev 241492)
@@ -284,7 +284,7 @@
_returnMediaLayerToInlineIfNeeded()
{
if (this.host)
- window.requestAnimationFrame(() => this.host.setPreparedToReturnVideoLayerToInline(this.media.webkitPresentationMode !== PiPMode));
+ this.host.setPreparedToReturnVideoLayerToInline(this.media.webkitPresentationMode !== PiPMode);
}
_controlsClassForLayoutTraits(layoutTraits)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
