Title: [241704] releases/WebKitGTK/webkit-2.24/Source/WebCore
- Revision
- 241704
- Author
- carlo...@webkit.org
- Date
- 2019-02-18 08:16:09 -0800 (Mon, 18 Feb 2019)
Log Message
Merge r241632 - Sample domainsVisited diagnostic logging
https://bugs.webkit.org/show_bug.cgi?id=194657
Reviewed by Ryosuke Niwa.
Sample domainsVisited diagnostic logging, we are getting a lot of data from
this key and this is hurting our other keys.
* page/Page.cpp:
(WebCore::Page::logNavigation):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog (241703 => 241704)
--- releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog 2019-02-18 16:16:05 UTC (rev 241703)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog 2019-02-18 16:16:09 UTC (rev 241704)
@@ -1,3 +1,16 @@
+2019-02-15 Chris Dumez <cdu...@apple.com>
+
+ Sample domainsVisited diagnostic logging
+ https://bugs.webkit.org/show_bug.cgi?id=194657
+
+ Reviewed by Ryosuke Niwa.
+
+ Sample domainsVisited diagnostic logging, we are getting a lot of data from
+ this key and this is hurting our other keys.
+
+ * page/Page.cpp:
+ (WebCore::Page::logNavigation):
+
2019-02-15 Ryosuke Niwa <rn...@webkit.org>
Crash in the hit testing code via HTMLPlugInElement::isReplacementObscured()
Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/page/Page.cpp (241703 => 241704)
--- releases/WebKitGTK/webkit-2.24/Source/WebCore/page/Page.cpp 2019-02-18 16:16:05 UTC (rev 241703)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/page/Page.cpp 2019-02-18 16:16:09 UTC (rev 241704)
@@ -2369,7 +2369,7 @@
diagnosticLoggingClient().logDiagnosticMessage(DiagnosticLoggingKeys::navigationKey(), navigationDescription, ShouldSample::No);
if (!navigation.domain.isEmpty())
- diagnosticLoggingClient().logDiagnosticMessageWithEnhancedPrivacy(DiagnosticLoggingKeys::domainVisitedKey(), navigation.domain, ShouldSample::No);
+ diagnosticLoggingClient().logDiagnosticMessageWithEnhancedPrivacy(DiagnosticLoggingKeys::domainVisitedKey(), navigation.domain, ShouldSample::Yes);
}
void Page::mainFrameLoadStarted(const URL& destinationURL, FrameLoadType type)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
