Title: [241842] trunk/Source/WebCore
Revision
241842
Author
commit-qu...@webkit.org
Date
2019-02-20 14:52:18 -0800 (Wed, 20 Feb 2019)

Log Message

Always call CompletionHandlers after r240909
https://bugs.webkit.org/show_bug.cgi?id=194823

Patch by Alex Christensen <achristen...@webkit.org> on 2019-02-20
Reviewed by Ryosuke Niwa.

* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
(WebCore::PolicyChecker::checkNewWindowPolicy):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (241841 => 241842)


--- trunk/Source/WebCore/ChangeLog	2019-02-20 22:37:28 UTC (rev 241841)
+++ trunk/Source/WebCore/ChangeLog	2019-02-20 22:52:18 UTC (rev 241842)
@@ -1,3 +1,14 @@
+2019-02-20  Alex Christensen  <achristen...@webkit.org>
+
+        Always call CompletionHandlers after r240909
+        https://bugs.webkit.org/show_bug.cgi?id=194823
+
+        Reviewed by Ryosuke Niwa.
+
+        * loader/PolicyChecker.cpp:
+        (WebCore::PolicyChecker::checkNavigationPolicy):
+        (WebCore::PolicyChecker::checkNewWindowPolicy):
+
 2019-02-20  Andy Estes  <aes...@apple.com>
 
         [Xcode] Add SDKVariant.xcconfig to various Xcode projects

Modified: trunk/Source/WebCore/loader/PolicyChecker.cpp (241841 => 241842)


--- trunk/Source/WebCore/loader/PolicyChecker.cpp	2019-02-20 22:37:28 UTC (rev 241841)
+++ trunk/Source/WebCore/loader/PolicyChecker.cpp	2019-02-20 22:52:18 UTC (rev 241842)
@@ -193,7 +193,7 @@
          blobURLLifetimeExtension = WTFMove(blobURLLifetimeExtension), requestIdentifier] (PolicyAction policyAction, PolicyCheckIdentifier responseIdentifier) mutable {
 
         if (!responseIdentifier.isValidFor(requestIdentifier))
-            return;
+            return function({ }, nullptr, NavigationPolicyDecision::IgnoreLoad);
 
         m_delegateIsDecidingNavigationPolicy = false;
 
@@ -234,7 +234,7 @@
         requestIdentifier] (PolicyAction policyAction, PolicyCheckIdentifier responseIdentifier) mutable {
 
         if (!responseIdentifier.isValidFor(requestIdentifier))
-            return;
+            return function({ }, nullptr, { }, { }, ShouldContinue::No);
 
         switch (policyAction) {
         case PolicyAction::Download:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to