Title: [242214] branches/safari-607-branch/Source/WebCore
Revision
242214
Author
bshaf...@apple.com
Date
2019-02-28 12:44:16 -0800 (Thu, 28 Feb 2019)

Log Message

Cherry-pick r242204. rdar://problem/48483754

    Locale names can be nullptr
    https://bugs.webkit.org/show_bug.cgi?id=195171
    <rdar://problem/48262376>

    Reviewed by Dean Jackson.

    Nullptr can't be used in keys to HashMaps, so take an early out in this case.

    This is a partial revert of r241288.

    * platform/graphics/cocoa/FontDescriptionCocoa.cpp:
    (WebCore::FontDescription::platformResolveGenericFamily):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (242213 => 242214)


--- branches/safari-607-branch/Source/WebCore/ChangeLog	2019-02-28 20:17:53 UTC (rev 242213)
+++ branches/safari-607-branch/Source/WebCore/ChangeLog	2019-02-28 20:44:16 UTC (rev 242214)
@@ -1,3 +1,37 @@
+2019-02-28  Babak Shafiei  <bshaf...@apple.com>
+
+        Cherry-pick r242204. rdar://problem/48483754
+
+    Locale names can be nullptr
+    https://bugs.webkit.org/show_bug.cgi?id=195171
+    <rdar://problem/48262376>
+    
+    Reviewed by Dean Jackson.
+    
+    Nullptr can't be used in keys to HashMaps, so take an early out in this case.
+    
+    This is a partial revert of r241288.
+    
+    * platform/graphics/cocoa/FontDescriptionCocoa.cpp:
+    (WebCore::FontDescription::platformResolveGenericFamily):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-02-28  Myles C. Maxfield  <mmaxfi...@apple.com>
+
+            Locale names can be nullptr
+            https://bugs.webkit.org/show_bug.cgi?id=195171
+            <rdar://problem/48262376>
+
+            Reviewed by Dean Jackson.
+
+            Nullptr can't be used in keys to HashMaps, so take an early out in this case.
+
+            This is a partial revert of r241288.
+
+            * platform/graphics/cocoa/FontDescriptionCocoa.cpp:
+            (WebCore::FontDescription::platformResolveGenericFamily):
+
 2019-02-28  Alan Coon  <alanc...@apple.com>
 
         Apply patch. rdar://problem/48464974

Modified: branches/safari-607-branch/Source/WebCore/platform/graphics/cocoa/FontDescriptionCocoa.cpp (242213 => 242214)


--- branches/safari-607-branch/Source/WebCore/platform/graphics/cocoa/FontDescriptionCocoa.cpp	2019-02-28 20:17:53 UTC (rev 242213)
+++ branches/safari-607-branch/Source/WebCore/platform/graphics/cocoa/FontDescriptionCocoa.cpp	2019-02-28 20:44:16 UTC (rev 242214)
@@ -165,7 +165,7 @@
 
 AtomicString FontDescription::platformResolveGenericFamily(UScriptCode script, const AtomicString& locale, const AtomicString& familyName)
 {
-    if (script == USCRIPT_COMMON)
+    if (locale.isNull() || script == USCRIPT_COMMON)
         return nullAtom();
 
     static std::once_flag onceFlag;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to