Title: [242431] releases/WebKitGTK/webkit-2.24/Source/WebInspectorUI
Revision
242431
Author
carlo...@webkit.org
Date
2019-03-05 00:44:19 -0800 (Tue, 05 Mar 2019)

Log Message

Merge r241874 - Web Inspector: DOM Debugger: node-specific event breakpoints aren't cleared/recalculated on navigation
https://bugs.webkit.org/show_bug.cgi?id=194874
<rdar://problem/48253415>

Reviewed by Joseph Pecoraro.

* UserInterface/Controllers/DOMManager.js:
(WI.DOMManager.prototype._setDocument):
(WI.DOMManager.prototype.removeBreakpointForEventListener):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.24/Source/WebInspectorUI/ChangeLog (242430 => 242431)


--- releases/WebKitGTK/webkit-2.24/Source/WebInspectorUI/ChangeLog	2019-03-05 08:44:16 UTC (rev 242430)
+++ releases/WebKitGTK/webkit-2.24/Source/WebInspectorUI/ChangeLog	2019-03-05 08:44:19 UTC (rev 242431)
@@ -1,3 +1,15 @@
+2019-02-21  Devin Rousso  <drou...@apple.com>
+
+        Web Inspector: DOM Debugger: node-specific event breakpoints aren't cleared/recalculated on navigation
+        https://bugs.webkit.org/show_bug.cgi?id=194874
+        <rdar://problem/48253415>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Controllers/DOMManager.js:
+        (WI.DOMManager.prototype._setDocument):
+        (WI.DOMManager.prototype.removeBreakpointForEventListener):
+
 2019-02-18  Devin Rousso  <drou...@apple.com>
 
         Web Inspector: duplicate left double quotation mark (\u201C) in 'Unable to show certificate for ā€œ%sā€œ.'

Modified: releases/WebKitGTK/webkit-2.24/Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js (242430 => 242431)


--- releases/WebKitGTK/webkit-2.24/Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js	2019-03-05 08:44:16 UTC (rev 242430)
+++ releases/WebKitGTK/webkit-2.24/Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js	2019-03-05 08:44:19 UTC (rev 242431)
@@ -279,6 +279,9 @@
     _setDocument(payload)
     {
         this._idToDOMNode = {};
+
+        for (let breakpoint of this._breakpointsForEventListeners.values())
+            WI.domDebuggerManager.dispatchEventToListeners(WI.DOMDebuggerManager.Event.EventBreakpointRemoved, {breakpoint});
         this._breakpointsForEventListeners.clear();
 
         let newDocument = null;
@@ -652,8 +655,7 @@
                 return;
             }
 
-            if (breakpoint)
-                WI.domDebuggerManager.dispatchEventToListeners(WI.DOMDebuggerManager.Event.EventBreakpointRemoved, {breakpoint});
+            WI.domDebuggerManager.dispatchEventToListeners(WI.DOMDebuggerManager.Event.EventBreakpointRemoved, {breakpoint});
         });
     }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to