Title: [242485] releases/WebKitGTK/webkit-2.24/Tools
Revision
242485
Author
carlo...@webkit.org
Date
2019-03-05 09:22:41 -0800 (Tue, 05 Mar 2019)

Log Message

Merge r242260 - Unreviewed, fix lldb webkitpy tests
https://bugs.webkit.org/show_bug.cgi?id=194375

Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.

* lldb/lldb_webkit.py:
(WTFStringImplProvider.is_8bit):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.24/Tools/ChangeLog (242484 => 242485)


--- releases/WebKitGTK/webkit-2.24/Tools/ChangeLog	2019-03-05 17:22:38 UTC (rev 242484)
+++ releases/WebKitGTK/webkit-2.24/Tools/ChangeLog	2019-03-05 17:22:41 UTC (rev 242485)
@@ -1,3 +1,13 @@
+2019-03-01  Yusuke Suzuki  <ysuz...@apple.com>
+
+        Unreviewed, fix lldb webkitpy tests
+        https://bugs.webkit.org/show_bug.cgi?id=194375
+
+        Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
+
+        * lldb/lldb_webkit.py:
+        (WTFStringImplProvider.is_8bit):
+
 2019-02-26  Mark Lam  <mark....@apple.com>
 
         Remove remaining poisoning code.

Modified: releases/WebKitGTK/webkit-2.24/Tools/lldb/lldb_webkit.py (242484 => 242485)


--- releases/WebKitGTK/webkit-2.24/Tools/lldb/lldb_webkit.py	2019-03-05 17:22:38 UTC (rev 242484)
+++ releases/WebKitGTK/webkit-2.24/Tools/lldb/lldb_webkit.py	2019-03-05 17:22:41 UTC (rev 242485)
@@ -393,7 +393,7 @@
     def is_8bit(self):
         # FIXME: find a way to access WTF::StringImpl::s_hashFlag8BitBuffer
         return bool(self.valobj.GetChildMemberWithName('m_hashAndFlags').GetValueAsUnsigned(0) \
-            & 1 << 3)
+            & 1 << 2)
 
     def is_initialized(self):
         return self.valobj.GetValueAsUnsigned() != 0
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to