Title: [102248] trunk/Websites/webkit.org
- Revision
- 102248
- Author
- dba...@webkit.org
- Date
- 2011-12-07 10:24:05 -0800 (Wed, 07 Dec 2011)
Log Message
ASSERT_UNREACHED() should be ASSERT_NOT_REACHED() on assertion-guidelines.html
https://bugs.webkit.org/show_bug.cgi?id=74006
Reviewed by Antonio Gomes.
As far I can tell, we've never had an ASSERT_UNREACHED(). We do have an
ASSERT_NOT_REACHED().
* coding/assertion-guidelines.html:
Modified Paths
Diff
Modified: trunk/Websites/webkit.org/ChangeLog (102247 => 102248)
--- trunk/Websites/webkit.org/ChangeLog 2011-12-07 18:21:04 UTC (rev 102247)
+++ trunk/Websites/webkit.org/ChangeLog 2011-12-07 18:24:05 UTC (rev 102248)
@@ -1,3 +1,15 @@
+2011-12-07 Daniel Bates <dba...@webkit.org>
+
+ ASSERT_UNREACHED() should be ASSERT_NOT_REACHED() on assertion-guidelines.html
+ https://bugs.webkit.org/show_bug.cgi?id=74006
+
+ Reviewed by Antonio Gomes.
+
+ As far I can tell, we've never had an ASSERT_UNREACHED(). We do have an
+ ASSERT_NOT_REACHED().
+
+ * coding/assertion-guidelines.html:
+
2011-11-30 Ryosuke Niwa <rn...@webkit.org>
commit-review-policy.html should make clear committers shouldn't land patches without authors' consent
Modified: trunk/Websites/webkit.org/coding/assertion-guidelines.html (102247 => 102248)
--- trunk/Websites/webkit.org/coding/assertion-guidelines.html 2011-12-07 18:21:04 UTC (rev 102247)
+++ trunk/Websites/webkit.org/coding/assertion-guidelines.html 2011-12-07 18:24:05 UTC (rev 102248)
@@ -37,13 +37,13 @@
<ul>
<li>ASSERT(_expression_) - for use during development to ensure that unexpected conditions do not occur. If the _expression_ evaluates to false then abort execution and break into the debugger.
</li>
- <li>ASSERT_UNREACHED() - for use when a certain branch of code should never be executed.
+ <li>ASSERT_NOT_REACHED() - for use when a certain branch of code should never be executed.
<pre class="code">
if (condition) {
...
} else {
<span class="comment">// This should never happen.</span>
- ASSERT_UNREACHED();
+ ASSERT_NOT_REACHED();
}
</pre>
</li>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
