Title: [242590] trunk/Source/WebInspectorUI
- Revision
- 242590
- Author
- drou...@apple.com
- Date
- 2019-03-06 20:32:50 -0800 (Wed, 06 Mar 2019)
Log Message
Web Inspector: Elements: highlight the node when hovering event listeners sorted by node
https://bugs.webkit.org/show_bug.cgi?id=195368
Reviewed by Joseph Pecoraro.
* UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
(WI.DOMNodeDetailsSidebarPanel.prototype._refreshEventListeners.generateGroupsByNode):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (242589 => 242590)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-03-07 04:15:37 UTC (rev 242589)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-03-07 04:32:50 UTC (rev 242590)
@@ -1,3 +1,13 @@
+2019-03-06 Devin Rousso <drou...@apple.com>
+
+ Web Inspector: Elements: highlight the node when hovering event listeners sorted by node
+ https://bugs.webkit.org/show_bug.cgi?id=195368
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
+ (WI.DOMNodeDetailsSidebarPanel.prototype._refreshEventListeners.generateGroupsByNode):
+
2019-03-06 Matt Baker <mattba...@apple.com>
Web Inspector: system accent color follow-ups
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js (242589 => 242590)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2019-03-07 04:15:37 UTC (rev 242589)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2019-03-07 04:32:50 UTC (rev 242590)
@@ -393,9 +393,18 @@
if (!eventListenersForNode)
continue;
+ let nodeId = currentNode.id;
+
eventListenersForNode.sort((a, b) => a.type.toLowerCase().extendedLocaleCompare(b.type.toLowerCase()));
- rows.push(createEventListenerSection(currentNode.displayName, eventListenersForNode, {hideNode: true}));
+ let section = createEventListenerSection(currentNode.displayName, eventListenersForNode, {hideNode: true});
+ section.titleElement.addEventListener("mouseover", (event) => {
+ WI.domManager.highlightDOMNode(nodeId, "all");
+ });
+ section.titleElement.addEventListener("mouseout", (event) => {
+ WI.domManager.hideDOMNodeHighlight();
+ });
+ rows.push(section);
} while (currentNode = currentNode.parentNode);
return rows;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
