Title: [242733] trunk/Tools
- Revision
- 242733
- Author
- [email protected]
- Date
- 2019-03-11 13:17:50 -0700 (Mon, 11 Mar 2019)
Log Message
Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
https://bugs.webkit.org/show_bug.cgi?id=195561
Reviewed by Youenn Fablet.
Make sure the JS in the test requests for permission to receive device orientation events.
* TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (242732 => 242733)
--- trunk/Tools/ChangeLog 2019-03-11 20:06:55 UTC (rev 242732)
+++ trunk/Tools/ChangeLog 2019-03-11 20:17:50 UTC (rev 242733)
@@ -1,3 +1,14 @@
+2019-03-11 Chris Dumez <[email protected]>
+
+ Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=195561
+
+ Reviewed by Youenn Fablet.
+
+ Make sure the JS in the test requests for permission to receive device orientation events.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
+
2019-03-11 Youenn Fablet <[email protected]>
Allow storage quota increase by default in WTR
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm (242732 => 242733)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm 2019-03-11 20:06:55 UTC (rev 242732)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm 2019-03-11 20:17:50 UTC (rev 242733)
@@ -1293,6 +1293,12 @@
TestWebKitAPI::Util::run(&finishedNavigation);
finishedNavigation = false;
+ bool askedForPermission = false;
+ [webView evaluateJavaScript:@"DeviceOrientationEvent.requestPermission()" completionHandler: [&] (id result, NSError *error) {
+ askedForPermission = true;
+ }];
+ TestWebKitAPI::Util::run(&askedForPermission);
+
__block bool didReceiveMessage = false;
[webView performAfterReceivingMessage:@"received-device-orientation-event" action:^{
didReceiveMessage = true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
