Title: [242966] trunk/Tools
- Revision
- 242966
- Author
- aakash_j...@apple.com
- Date
- 2019-03-14 14:44:35 -0700 (Thu, 14 Mar 2019)
Log Message
[ews-app] Gracefully handle the case when state_string is None
https://bugs.webkit.org/show_bug.cgi?id=195753
Reviewed by Lucas Forschler.
* BuildSlaveSupport/ews-app/ews/models/build.py:
* BuildSlaveSupport/ews-app/ews/models/step.py:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/models/build.py (242965 => 242966)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/models/build.py 2019-03-14 21:33:47 UTC (rev 242965)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/models/build.py 2019-03-14 21:44:35 UTC (rev 242966)
@@ -55,6 +55,9 @@
if not Build.is_valid_result(patch_id, build_id, builder_id, number, result, state_string, started_at, complete_at):
return ERR_UNEXPECTED
+ if state_string is None:
+ state_string = ''
+
uid = BuildbotInstance.get_uid(hostname, build_id)
build = Build.get_existing_build(uid)
if build:
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/models/step.py (242965 => 242966)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/models/step.py 2019-03-14 21:33:47 UTC (rev 242965)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/models/step.py 2019-03-14 21:44:35 UTC (rev 242966)
@@ -51,6 +51,9 @@
if not Step.is_valid_result(step_id, build_id, result, state_string, started_at, complete_at):
return ERR_UNEXPECTED
+ if state_string is None:
+ state_string = ''
+
step_uid = BuildbotInstance.get_uid(hostname, step_id)
build_uid = BuildbotInstance.get_uid(hostname, build_id)
Modified: trunk/Tools/ChangeLog (242965 => 242966)
--- trunk/Tools/ChangeLog 2019-03-14 21:33:47 UTC (rev 242965)
+++ trunk/Tools/ChangeLog 2019-03-14 21:44:35 UTC (rev 242966)
@@ -1,5 +1,15 @@
2019-03-14 Aakash Jain <aakash_j...@apple.com>
+ [ews-app] Gracefully handle the case when state_string is None
+ https://bugs.webkit.org/show_bug.cgi?id=195753
+
+ Reviewed by Lucas Forschler.
+
+ * BuildSlaveSupport/ews-app/ews/models/build.py:
+ * BuildSlaveSupport/ews-app/ews/models/step.py:
+
+2019-03-14 Aakash Jain <aakash_j...@apple.com>
+
[ews-app] Status bubble display pending for currently running build step
https://bugs.webkit.org/show_bug.cgi?id=195744
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
