Title: [243332] trunk/Tools
- Revision
- 243332
- Author
- aakash_j...@apple.com
- Date
- 2019-03-21 14:46:08 -0700 (Thu, 21 Mar 2019)
Log Message
[ews-app] Generate status-bubble hover-over messages (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=195680
<rdar://problem/48903534>
Unreviewed infrastructure fix.
* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (243331 => 243332)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-03-21 21:43:14 UTC (rev 243331)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-03-21 21:46:08 UTC (rev 243332)
@@ -83,19 +83,19 @@
elif build.result == Buildbot.EXCEPTION:
bubble['state'] = 'error'
- bubble['details_message'] += ('An unexpected error occured. Recent messages:\n\n'
+ bubble['details_message'] = ('An unexpected error occured. Recent messages:\n\n'
+ self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at))
elif build.result == Buildbot.RETRY:
bubble['state'] = 'provisional-fail'
- bubble['details_message'] += ('Build is being retried. Recent messages:\n\n'
+ bubble['details_message'] = ('Build is being retried. Recent messages:\n\n'
+ self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at))
elif build.result == Buildbot.CANCELLED:
bubble['state'] = 'provisional-fail'
- bubble['details_message'] += ('Build was cancelled. Recent messages:\n\n'
+ bubble['details_message'] = ('Build was cancelled. Recent messages:\n\n'
+ self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at))
else:
bubble['state'] = 'error'
- bubble['details_message'] += ('An unexpected error occured. Recent messages:\n\n'
+ bubble['details_message'] = ('An unexpected error occured. Recent messages:\n\n'
+ self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at))
if 'details_message' in bubble:
Modified: trunk/Tools/ChangeLog (243331 => 243332)
--- trunk/Tools/ChangeLog 2019-03-21 21:43:14 UTC (rev 243331)
+++ trunk/Tools/ChangeLog 2019-03-21 21:46:08 UTC (rev 243332)
@@ -1,3 +1,14 @@
+2019-03-21 Aakash Jain <aakash_j...@apple.com>
+
+ [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
+ https://bugs.webkit.org/show_bug.cgi?id=195680
+ <rdar://problem/48903534>
+
+ Unreviewed infrastructure fix.
+
+ * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+ (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
+
2019-03-21 Andy Estes <aes...@apple.com>
[iOS] Apple Pay should be available in documents with no user agent scripts
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
