Title: [243481] trunk
- Revision
- 243481
- Author
- [email protected]
- Date
- 2019-03-25 19:18:13 -0700 (Mon, 25 Mar 2019)
Log Message
[WPE][GTK] Make building WebVR (w/OpenVR) not depend on ENABLE_EXPERIMENTAL_FEATURES
https://bugs.webkit.org/show_bug.cgi?id=196223
Reviewed by Michael Catanzaro.
Disentangle USE_OPENVR from ENABLE_EXPERIMENTAL_FEATURES, making it
unneeded to include ThirdParty/openvr/ in release tarballs.
* Source/cmake/OptionsGTK.cmake: Set USE_OPENVR to OFF by default,
instead of making it use the value of ENABLE_EXPERIMENTAL_FEATURES.
* Source/cmake/OptionsWPE.cmake: Ditto.
Modified Paths
Diff
Modified: trunk/ChangeLog (243480 => 243481)
--- trunk/ChangeLog 2019-03-26 01:44:50 UTC (rev 243480)
+++ trunk/ChangeLog 2019-03-26 02:18:13 UTC (rev 243481)
@@ -1,3 +1,17 @@
+2019-03-25 Adrian Perez de Castro <[email protected]>
+
+ [WPE][GTK] Make building WebVR (w/OpenVR) not depend on ENABLE_EXPERIMENTAL_FEATURES
+ https://bugs.webkit.org/show_bug.cgi?id=196223
+
+ Reviewed by Michael Catanzaro.
+
+ Disentangle USE_OPENVR from ENABLE_EXPERIMENTAL_FEATURES, making it
+ unneeded to include ThirdParty/openvr/ in release tarballs.
+
+ * Source/cmake/OptionsGTK.cmake: Set USE_OPENVR to OFF by default,
+ instead of making it use the value of ENABLE_EXPERIMENTAL_FEATURES.
+ * Source/cmake/OptionsWPE.cmake: Ditto.
+
2019-03-25 Xan López <[email protected]>
[WTF] Fix typo when forcing WTF_CPU_X86
Modified: trunk/Source/cmake/OptionsGTK.cmake (243480 => 243481)
--- trunk/Source/cmake/OptionsGTK.cmake 2019-03-26 01:44:50 UTC (rev 243480)
+++ trunk/Source/cmake/OptionsGTK.cmake 2019-03-26 02:18:13 UTC (rev 243481)
@@ -89,7 +89,7 @@
# Private options specific to the GTK+ port. Changing these options is
# completely unsupported. They are intended for use only by WebKit developers.
WEBKIT_OPTION_DEFINE(USE_REDIRECTED_XCOMPOSITE_WINDOW "Whether to use a Redirected XComposite Window for accelerated compositing in X11." PRIVATE ON)
-WEBKIT_OPTION_DEFINE(USE_OPENVR "Whether to use OpenVR as WebVR backend." PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
+WEBKIT_OPTION_DEFINE(USE_OPENVR "Whether to use OpenVR as WebVR backend." PRIVATE OFF)
# FIXME: Can we use cairo-glesv2 to avoid this conflict?
WEBKIT_OPTION_CONFLICT(ENABLE_ACCELERATED_2D_CANVAS ENABLE_GLES2)
Modified: trunk/Source/cmake/OptionsWPE.cmake (243480 => 243481)
--- trunk/Source/cmake/OptionsWPE.cmake 2019-03-26 01:44:50 UTC (rev 243480)
+++ trunk/Source/cmake/OptionsWPE.cmake 2019-03-26 02:18:13 UTC (rev 243481)
@@ -67,7 +67,7 @@
WEBKIT_OPTION_DEFINE(ENABLE_WPE_QT_API "Whether to enable support for the Qt5/QML plugin" PUBLIC OFF)
# Private options specific to the WPE port.
-WEBKIT_OPTION_DEFINE(USE_OPENVR "Whether to use OpenVR as WebVR backend." PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
+WEBKIT_OPTION_DEFINE(USE_OPENVR "Whether to use OpenVR as WebVR backend." PRIVATE OFF)
WEBKIT_OPTION_DEFINE(USE_GSTREAMER_HOLEPUNCH "Whether to enable GStreamer holepunch" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(USE_EXTERNAL_HOLEPUNCH "Whether to enable external holepunch" PRIVATE OFF)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
