Title: [243499] trunk/Source
Revision
243499
Author
[email protected]
Date
2019-03-26 09:57:38 -0700 (Tue, 26 Mar 2019)

Log Message

Remove mousemoveEventHandlingPreventsDefault internal setting and quirk
https://bugs.webkit.org/show_bug.cgi?id=196254
<rdar://problem/49124334>

Reviewed by Dean Jackson.

Source/WebCore:

* page/Quirks.cpp:
(WebCore::Quirks::shouldMousemoveEventHandlingPreventDefault const): Deleted.
* page/Quirks.h:
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setMouseEventsSimulationEnabled):
(WebCore::RuntimeEnabledFeatures::mousemoveEventHandlingPreventsDefaultEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setMousemoveEventHandlingPreventsDefaultEnabled): Deleted.

Source/WebKit:

* Shared/WebPreferences.yaml:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (243498 => 243499)


--- trunk/Source/WebCore/ChangeLog	2019-03-26 16:39:11 UTC (rev 243498)
+++ trunk/Source/WebCore/ChangeLog	2019-03-26 16:57:38 UTC (rev 243499)
@@ -1,3 +1,19 @@
+2019-03-26  Antoine Quint  <[email protected]>
+
+        Remove mousemoveEventHandlingPreventsDefault internal setting and quirk
+        https://bugs.webkit.org/show_bug.cgi?id=196254
+        <rdar://problem/49124334>
+
+        Reviewed by Dean Jackson.
+
+        * page/Quirks.cpp:
+        (WebCore::Quirks::shouldMousemoveEventHandlingPreventDefault const): Deleted.
+        * page/Quirks.h:
+        * page/RuntimeEnabledFeatures.h:
+        (WebCore::RuntimeEnabledFeatures::setMouseEventsSimulationEnabled):
+        (WebCore::RuntimeEnabledFeatures::mousemoveEventHandlingPreventsDefaultEnabled const): Deleted.
+        (WebCore::RuntimeEnabledFeatures::setMousemoveEventHandlingPreventsDefaultEnabled): Deleted.
+
 2019-03-26  Commit Queue  <[email protected]>
 
         Unreviewed, rolling out r243493.

Modified: trunk/Source/WebCore/page/Quirks.cpp (243498 => 243499)


--- trunk/Source/WebCore/page/Quirks.cpp	2019-03-26 16:39:11 UTC (rev 243498)
+++ trunk/Source/WebCore/page/Quirks.cpp	2019-03-26 16:57:38 UTC (rev 243499)
@@ -200,9 +200,4 @@
     return false;
 }
 
-bool Quirks::shouldMousemoveEventHandlingPreventDefault() const
-{
-    return false;
 }
-
-}

Modified: trunk/Source/WebCore/page/Quirks.h (243498 => 243499)


--- trunk/Source/WebCore/page/Quirks.h	2019-03-26 16:39:11 UTC (rev 243498)
+++ trunk/Source/WebCore/page/Quirks.h	2019-03-26 16:57:38 UTC (rev 243499)
@@ -46,7 +46,6 @@
     bool hasBrokenEncryptedMediaAPISupportQuirk() const;
     bool hasWebSQLSupportQuirk() const;
     bool shouldDispatchSimulateMouseEvents() const;
-    bool shouldMousemoveEventHandlingPreventDefault() const;
 
     WEBCORE_EXPORT bool isTouchBarUpdateSupressedForHiddenContentEditable() const;
     WEBCORE_EXPORT bool isNeverRichlyEditableForTouchBar() const;

Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (243498 => 243499)


--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2019-03-26 16:39:11 UTC (rev 243498)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2019-03-26 16:57:38 UTC (rev 243499)
@@ -350,9 +350,6 @@
 #if ENABLE(TOUCH_EVENTS)
     bool mouseEventsSimulationEnabled() const { return m_mouseEventsSimulationEnabled; }
     void setMouseEventsSimulationEnabled(bool isEnabled) { m_mouseEventsSimulationEnabled = isEnabled; }
-
-    bool mousemoveEventHandlingPreventsDefaultEnabled() const { return m_mousemoveEventHandlingPreventsDefaultEnabled; }
-    void setMousemoveEventHandlingPreventsDefaultEnabled(bool isEnabled) { m_mousemoveEventHandlingPreventsDefaultEnabled = isEnabled; }
 #endif
     
     bool referrerPolicyAttributeEnabled() const { return m_referrerPolicyAttributeEnabled; }
@@ -536,7 +533,6 @@
 
 #if ENABLE(TOUCH_EVENTS)
     bool m_mouseEventsSimulationEnabled { false };
-    bool m_mousemoveEventHandlingPreventsDefaultEnabled { false };
 #endif
 
     bool m_isITPDatabaseEnabled { false };

Modified: trunk/Source/WebKit/ChangeLog (243498 => 243499)


--- trunk/Source/WebKit/ChangeLog	2019-03-26 16:39:11 UTC (rev 243498)
+++ trunk/Source/WebKit/ChangeLog	2019-03-26 16:57:38 UTC (rev 243499)
@@ -1,3 +1,13 @@
+2019-03-26  Antoine Quint  <[email protected]>
+
+        Remove mousemoveEventHandlingPreventsDefault internal setting and quirk
+        https://bugs.webkit.org/show_bug.cgi?id=196254
+        <rdar://problem/49124334>
+
+        Reviewed by Dean Jackson.
+
+        * Shared/WebPreferences.yaml:
+
 2019-03-26  Philippe Normand  <[email protected]>
 
         [WPE][Qt] Uninitialized racy ViewBackend

Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (243498 => 243499)


--- trunk/Source/WebKit/Shared/WebPreferences.yaml	2019-03-26 16:39:11 UTC (rev 243498)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml	2019-03-26 16:57:38 UTC (rev 243499)
@@ -1611,15 +1611,6 @@
   category: internal
   condition: ENABLE(TOUCH_EVENTS)
 
-MousemoveEventHandlingPreventsDefaultEnabled:
-  type: bool
-  defaultValue: false
-  humanReadableName: "Prevent default for mousemove events"
-  humanReadableDescription: "Allows handling of mousemove events to implicitly call preventDefault() on iOS"
-  webcoreBinding: RuntimeEnabledFeatures
-  category: internal
-  condition: ENABLE(TOUCH_EVENTS)
-
 ReferrerPolicyAttributeEnabled:
   type: bool
   defaultValue: false
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to