Title: [243504] trunk/Source/WebCore
Revision
243504
Author
grao...@webkit.org
Date
2019-03-26 10:29:54 -0700 (Tue, 26 Mar 2019)

Log Message

Remove mousemoveEventHandlingPreventsDefault internal setting and quirk
https://bugs.webkit.org/show_bug.cgi?id=196254
<rdar://problem/49124334>

Unreviewed. Fix build broken by previous commit.

* dom/Event.cpp:
* dom/Event.h:
(WebCore::Event::hasEncounteredListener const): Deleted.
(WebCore::Event::setHasEncounteredListener): Deleted.
* dom/EventTarget.cpp:
(WebCore::EventTarget::innerInvokeEventListeners):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (243503 => 243504)


--- trunk/Source/WebCore/ChangeLog	2019-03-26 17:27:05 UTC (rev 243503)
+++ trunk/Source/WebCore/ChangeLog	2019-03-26 17:29:54 UTC (rev 243504)
@@ -1,3 +1,18 @@
+2019-03-26  Antoine Quint  <grao...@apple.com>
+
+        Remove mousemoveEventHandlingPreventsDefault internal setting and quirk
+        https://bugs.webkit.org/show_bug.cgi?id=196254
+        <rdar://problem/49124334>
+
+        Unreviewed. Fix build broken by previous commit.
+
+        * dom/Event.cpp:
+        * dom/Event.h:
+        (WebCore::Event::hasEncounteredListener const): Deleted.
+        (WebCore::Event::setHasEncounteredListener): Deleted.
+        * dom/EventTarget.cpp:
+        (WebCore::EventTarget::innerInvokeEventListeners):
+
 2019-03-26  Zalan Bujtas  <za...@apple.com>
 
         [ContentChangeObserver] Skip anonymous renderers when checking for "willRespondToMouseClickEvents"

Modified: trunk/Source/WebCore/dom/Event.cpp (243503 => 243504)


--- trunk/Source/WebCore/dom/Event.cpp	2019-03-26 17:27:05 UTC (rev 243503)
+++ trunk/Source/WebCore/dom/Event.cpp	2019-03-26 17:29:54 UTC (rev 243504)
@@ -47,7 +47,6 @@
     , m_isDefaultEventHandlerIgnored { false }
     , m_isTrusted { isTrusted == IsTrusted::Yes }
     , m_isExecutingPassiveEventListener { false }
-    , m_hasEncounteredListener { false }
     , m_eventPhase { NONE }
     , m_type { type }
     , m_createTime { createTime }

Modified: trunk/Source/WebCore/dom/Event.h (243503 => 243504)


--- trunk/Source/WebCore/dom/Event.h	2019-03-26 17:27:05 UTC (rev 243503)
+++ trunk/Source/WebCore/dom/Event.h	2019-03-26 17:29:54 UTC (rev 243504)
@@ -128,9 +128,6 @@
 
     void setInPassiveListener(bool value) { m_isExecutingPassiveEventListener = value; }
 
-    bool hasEncounteredListener() const { return m_hasEncounteredListener; }
-    void setHasEncounteredListener() { m_hasEncounteredListener = true; }
-
     bool cancelBubble() const { return propagationStopped(); }
     void setCancelBubble(bool);
 
@@ -169,7 +166,6 @@
     unsigned m_isDefaultEventHandlerIgnored : 1;
     unsigned m_isTrusted : 1;
     unsigned m_isExecutingPassiveEventListener : 1;
-    unsigned m_hasEncounteredListener : 1;
 
     unsigned m_eventPhase : 2;
 

Modified: trunk/Source/WebCore/dom/EventTarget.cpp (243503 => 243504)


--- trunk/Source/WebCore/dom/EventTarget.cpp	2019-03-26 17:27:05 UTC (rev 243503)
+++ trunk/Source/WebCore/dom/EventTarget.cpp	2019-03-26 17:29:54 UTC (rev 243504)
@@ -301,16 +301,6 @@
         registeredListener->callback().handleEvent(context, event);
         InspectorInstrumentation::didHandleEvent(context);
 
-#if ENABLE(TOUCH_EVENTS)
-        if (RuntimeEnabledFeatures::sharedFeatures().mousemoveEventHandlingPreventsDefaultEnabled() && event.type() == eventNames().mousemoveEvent) {
-            if (is<Element>(event.currentTarget())) {
-                auto* element = downcast<Element>(event.currentTarget());
-                if (!is<HTMLBodyElement>(element) && !is<HTMLHtmlElement>(element))
-                    event.setHasEncounteredListener();
-            }
-        }
-#endif
-
         if (registeredListener->isPassive())
             event.setInPassiveListener(false);
     }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to