Title: [243683] trunk
Revision
243683
Author
wei...@apple.com
Date
2019-03-31 12:29:56 -0700 (Sun, 31 Mar 2019)

Log Message

Remove more i386 specific configurations
https://bugs.webkit.org/show_bug.cgi?id=196430

Reviewed by Alexey Proskuryakov.

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.

* Configurations/ToolExecutable.xcconfig:
ARC can be enabled unconditionally now.

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.

Source/WebKit:

* Configurations/BaseTarget.xcconfig:
WK_HAVE_CORE_PREDICTION can now be enabled unconditionally.

* Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (243682 => 243683)


--- trunk/Source/_javascript_Core/ChangeLog	2019-03-31 17:37:45 UTC (rev 243682)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-03-31 19:29:56 UTC (rev 243683)
@@ -1,3 +1,16 @@
+2019-03-31  Sam Weinig  <wei...@apple.com>
+
+        Remove more i386 specific configurations
+        https://bugs.webkit.org/show_bug.cgi?id=196430
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Configurations/FeatureDefines.xcconfig:
+        ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
+
+        * Configurations/ToolExecutable.xcconfig:
+        ARC can be enabled unconditionally now.
+
 2019-03-29  Yusuke Suzuki  <ysuz...@apple.com>
 
         [JSC] JSWrapperMap should not use Objective-C Weak map (NSMapTable with NSPointerFunctionsWeakMemory) for m_cachedObjCWrappers

Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (243682 => 243683)


--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2019-03-31 17:37:45 UTC (rev 243682)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2019-03-31 19:29:56 UTC (rev 243683)
@@ -396,12 +396,12 @@
 ENABLE_WEB_AUTHN = $(ENABLE_WEB_AUTHN_$(WK_PLATFORM_NAME));
 ENABLE_WEB_AUTHN_iphoneos = ENABLE_WEB_AUTHN;
 ENABLE_WEB_AUTHN_iphonesimulator = ENABLE_WEB_AUTHN;
-ENABLE_WEB_AUTHN_macosx[arch=x86_64] = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_macosx = ENABLE_WEB_AUTHN;
 
 ENABLE_WEB_RTC = $(ENABLE_WEB_RTC_$(WK_PLATFORM_NAME));
 ENABLE_WEB_RTC_iphoneos = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC_iphonesimulator = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_macosx[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_macosx = ENABLE_WEB_RTC;
 
 ENABLE_WIRELESS_PLAYBACK_TARGET = ENABLE_WIRELESS_PLAYBACK_TARGET;
 

Modified: trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig (243682 => 243683)


--- trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig	2019-03-31 17:37:45 UTC (rev 243682)
+++ trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig	2019-03-31 19:29:56 UTC (rev 243683)
@@ -43,7 +43,6 @@
 SKIP_INSTALL_YES = NO;
 
 CLANG_ENABLE_OBJC_ARC = YES;
-CLANG_ENABLE_OBJC_ARC[sdk=macosx*][arch=i386] = NO;
 
 OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS) -isystem icu;
 OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);

Modified: trunk/Source/WebCore/ChangeLog (243682 => 243683)


--- trunk/Source/WebCore/ChangeLog	2019-03-31 17:37:45 UTC (rev 243682)
+++ trunk/Source/WebCore/ChangeLog	2019-03-31 19:29:56 UTC (rev 243683)
@@ -1,3 +1,13 @@
+2019-03-31  Sam Weinig  <wei...@apple.com>
+
+        Remove more i386 specific configurations
+        https://bugs.webkit.org/show_bug.cgi?id=196430
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Configurations/FeatureDefines.xcconfig:
+        ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
+
 2019-03-31  Andy Estes  <aes...@apple.com>
 
         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document

Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (243682 => 243683)


--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2019-03-31 17:37:45 UTC (rev 243682)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2019-03-31 19:29:56 UTC (rev 243683)
@@ -396,12 +396,12 @@
 ENABLE_WEB_AUTHN = $(ENABLE_WEB_AUTHN_$(WK_PLATFORM_NAME));
 ENABLE_WEB_AUTHN_iphoneos = ENABLE_WEB_AUTHN;
 ENABLE_WEB_AUTHN_iphonesimulator = ENABLE_WEB_AUTHN;
-ENABLE_WEB_AUTHN_macosx[arch=x86_64] = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_macosx = ENABLE_WEB_AUTHN;
 
 ENABLE_WEB_RTC = $(ENABLE_WEB_RTC_$(WK_PLATFORM_NAME));
 ENABLE_WEB_RTC_iphoneos = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC_iphonesimulator = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_macosx[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_macosx = ENABLE_WEB_RTC;
 
 ENABLE_WIRELESS_PLAYBACK_TARGET = ENABLE_WIRELESS_PLAYBACK_TARGET;
 

Modified: trunk/Source/WebCore/PAL/ChangeLog (243682 => 243683)


--- trunk/Source/WebCore/PAL/ChangeLog	2019-03-31 17:37:45 UTC (rev 243682)
+++ trunk/Source/WebCore/PAL/ChangeLog	2019-03-31 19:29:56 UTC (rev 243683)
@@ -1,3 +1,13 @@
+2019-03-31  Sam Weinig  <wei...@apple.com>
+
+        Remove more i386 specific configurations
+        https://bugs.webkit.org/show_bug.cgi?id=196430
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Configurations/FeatureDefines.xcconfig:
+        ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
+
 2019-03-29  Myles C. Maxfield  <mmaxfi...@apple.com>
 
         Delete WebMetal implementation in favor of WebGPU

Modified: trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig (243682 => 243683)


--- trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig	2019-03-31 17:37:45 UTC (rev 243682)
+++ trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig	2019-03-31 19:29:56 UTC (rev 243683)
@@ -396,12 +396,12 @@
 ENABLE_WEB_AUTHN = $(ENABLE_WEB_AUTHN_$(WK_PLATFORM_NAME));
 ENABLE_WEB_AUTHN_iphoneos = ENABLE_WEB_AUTHN;
 ENABLE_WEB_AUTHN_iphonesimulator = ENABLE_WEB_AUTHN;
-ENABLE_WEB_AUTHN_macosx[arch=x86_64] = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_macosx = ENABLE_WEB_AUTHN;
 
 ENABLE_WEB_RTC = $(ENABLE_WEB_RTC_$(WK_PLATFORM_NAME));
 ENABLE_WEB_RTC_iphoneos = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC_iphonesimulator = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_macosx[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_macosx = ENABLE_WEB_RTC;
 
 ENABLE_WIRELESS_PLAYBACK_TARGET = ENABLE_WIRELESS_PLAYBACK_TARGET;
 

Modified: trunk/Source/WebKit/ChangeLog (243682 => 243683)


--- trunk/Source/WebKit/ChangeLog	2019-03-31 17:37:45 UTC (rev 243682)
+++ trunk/Source/WebKit/ChangeLog	2019-03-31 19:29:56 UTC (rev 243683)
@@ -1,3 +1,16 @@
+2019-03-31  Sam Weinig  <wei...@apple.com>
+
+        Remove more i386 specific configurations
+        https://bugs.webkit.org/show_bug.cgi?id=196430
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Configurations/BaseTarget.xcconfig:
+        WK_HAVE_CORE_PREDICTION can now be enabled unconditionally.
+ 
+        * Configurations/FeatureDefines.xcconfig:
+        ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
+
 2019-03-31  Andy Estes  <aes...@apple.com>
 
         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document

Modified: trunk/Source/WebKit/Configurations/BaseTarget.xcconfig (243682 => 243683)


--- trunk/Source/WebKit/Configurations/BaseTarget.xcconfig	2019-03-31 17:37:45 UTC (rev 243682)
+++ trunk/Source/WebKit/Configurations/BaseTarget.xcconfig	2019-03-31 19:29:56 UTC (rev 243683)
@@ -107,7 +107,6 @@
 WK_INSTALL_PATH_PREFIX_DEPLOYMENT_YES_MACOS_SINCE_1015_USE_STAGING_INSTALL_PATH_YES = $(PLATFORM_OOB_SYSTEM_CONTENT_DIR);
 
 WK_HAVE_CORE_PREDICTION = YES;
-WK_HAVE_CORE_PREDICTION[sdk=macosx*][arch=i386] = NO;
 
 WK_CORE_PREDICTION_DEFINES = $(WK_CORE_PREDICTION_DEFINES_$(WK_HAVE_CORE_PREDICTION));
 WK_CORE_PREDICTION_DEFINES_YES = HAVE_CORE_PREDICTION;

Modified: trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig (243682 => 243683)


--- trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig	2019-03-31 17:37:45 UTC (rev 243682)
+++ trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig	2019-03-31 19:29:56 UTC (rev 243683)
@@ -396,12 +396,12 @@
 ENABLE_WEB_AUTHN = $(ENABLE_WEB_AUTHN_$(WK_PLATFORM_NAME));
 ENABLE_WEB_AUTHN_iphoneos = ENABLE_WEB_AUTHN;
 ENABLE_WEB_AUTHN_iphonesimulator = ENABLE_WEB_AUTHN;
-ENABLE_WEB_AUTHN_macosx[arch=x86_64] = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_macosx = ENABLE_WEB_AUTHN;
 
 ENABLE_WEB_RTC = $(ENABLE_WEB_RTC_$(WK_PLATFORM_NAME));
 ENABLE_WEB_RTC_iphoneos = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC_iphonesimulator = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_macosx[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_macosx = ENABLE_WEB_RTC;
 
 ENABLE_WIRELESS_PLAYBACK_TARGET = ENABLE_WIRELESS_PLAYBACK_TARGET;
 

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (243682 => 243683)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2019-03-31 17:37:45 UTC (rev 243682)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2019-03-31 19:29:56 UTC (rev 243683)
@@ -1,3 +1,13 @@
+2019-03-31  Sam Weinig  <wei...@apple.com>
+
+        Remove more i386 specific configurations
+        https://bugs.webkit.org/show_bug.cgi?id=196430
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Configurations/FeatureDefines.xcconfig:
+        ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
+
 2019-03-29  Myles C. Maxfield  <mmaxfi...@apple.com>
 
         Delete WebMetal implementation in favor of WebGPU

Modified: trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig (243682 => 243683)


--- trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig	2019-03-31 17:37:45 UTC (rev 243682)
+++ trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig	2019-03-31 19:29:56 UTC (rev 243683)
@@ -396,12 +396,12 @@
 ENABLE_WEB_AUTHN = $(ENABLE_WEB_AUTHN_$(WK_PLATFORM_NAME));
 ENABLE_WEB_AUTHN_iphoneos = ENABLE_WEB_AUTHN;
 ENABLE_WEB_AUTHN_iphonesimulator = ENABLE_WEB_AUTHN;
-ENABLE_WEB_AUTHN_macosx[arch=x86_64] = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_macosx = ENABLE_WEB_AUTHN;
 
 ENABLE_WEB_RTC = $(ENABLE_WEB_RTC_$(WK_PLATFORM_NAME));
 ENABLE_WEB_RTC_iphoneos = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC_iphonesimulator = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_macosx[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_macosx = ENABLE_WEB_RTC;
 
 ENABLE_WIRELESS_PLAYBACK_TARGET = ENABLE_WIRELESS_PLAYBACK_TARGET;
 

Modified: trunk/Tools/ChangeLog (243682 => 243683)


--- trunk/Tools/ChangeLog	2019-03-31 17:37:45 UTC (rev 243682)
+++ trunk/Tools/ChangeLog	2019-03-31 19:29:56 UTC (rev 243683)
@@ -1,3 +1,13 @@
+2019-03-31  Sam Weinig  <wei...@apple.com>
+
+        Remove more i386 specific configurations
+        https://bugs.webkit.org/show_bug.cgi?id=196430
+
+        Reviewed by Alexey Proskuryakov.
+
+        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+        ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
+
 2019-03-31  Andy Estes  <aes...@apple.com>
 
         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document

Modified: trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig (243682 => 243683)


--- trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig	2019-03-31 17:37:45 UTC (rev 243682)
+++ trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig	2019-03-31 19:29:56 UTC (rev 243683)
@@ -396,12 +396,12 @@
 ENABLE_WEB_AUTHN = $(ENABLE_WEB_AUTHN_$(WK_PLATFORM_NAME));
 ENABLE_WEB_AUTHN_iphoneos = ENABLE_WEB_AUTHN;
 ENABLE_WEB_AUTHN_iphonesimulator = ENABLE_WEB_AUTHN;
-ENABLE_WEB_AUTHN_macosx[arch=x86_64] = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_macosx = ENABLE_WEB_AUTHN;
 
 ENABLE_WEB_RTC = $(ENABLE_WEB_RTC_$(WK_PLATFORM_NAME));
 ENABLE_WEB_RTC_iphoneos = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC_iphonesimulator = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_macosx[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_macosx = ENABLE_WEB_RTC;
 
 ENABLE_WIRELESS_PLAYBACK_TARGET = ENABLE_WIRELESS_PLAYBACK_TARGET;
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to