Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (243696 => 243697)
--- trunk/Source/_javascript_Core/ChangeLog 2019-04-01 17:21:46 UTC (rev 243696)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-04-01 17:27:53 UTC (rev 243697)
@@ -1,3 +1,29 @@
+2019-04-01 Michael Catanzaro <[email protected]>
+
+ Stop trying to support building JSC with clang 3.8
+ https://bugs.webkit.org/show_bug.cgi?id=195947
+ <rdar://problem/49069219>
+
+ Reviewed by Darin Adler.
+
+ It seems WebKit hasn't built with clang 3.8 in a while, no devs are using this compiler, we
+ don't know how much effort it would be to make JSC work again, and it's making the code
+ worse. Remove my hacks to support clang 3.8 from JSC.
+
+ * bindings/ScriptValue.cpp:
+ (Inspector::jsToInspectorValue):
+ * bytecode/GetterSetterAccessCase.cpp:
+ (JSC::GetterSetterAccessCase::create):
+ (JSC::GetterSetterAccessCase::clone const):
+ * bytecode/InstanceOfAccessCase.cpp:
+ (JSC::InstanceOfAccessCase::clone const):
+ * bytecode/IntrinsicGetterAccessCase.cpp:
+ (JSC::IntrinsicGetterAccessCase::clone const):
+ * bytecode/ModuleNamespaceAccessCase.cpp:
+ (JSC::ModuleNamespaceAccessCase::clone const):
+ * bytecode/ProxyableAccessCase.cpp:
+ (JSC::ProxyableAccessCase::clone const):
+
2019-03-31 Yusuke Suzuki <[email protected]>
[JSC] Butterfly allocation from LargeAllocation should try "realloc" behavior if collector thread is not active
Modified: trunk/Source/_javascript_Core/bindings/ScriptValue.cpp (243696 => 243697)
--- trunk/Source/_javascript_Core/bindings/ScriptValue.cpp 2019-04-01 17:21:46 UTC (rev 243696)
+++ trunk/Source/_javascript_Core/bindings/ScriptValue.cpp 2019-04-01 17:27:53 UTC (rev 243697)
@@ -74,7 +74,7 @@
return nullptr;
inspectorArray->pushValue(WTFMove(elementValue));
}
- return RefPtr<JSON::Value> { WTFMove(inspectorArray) };
+ return inspectorArray;
}
VM& vm = scriptState.vm();
auto inspectorObject = JSON::Object::create();
@@ -87,7 +87,7 @@
return nullptr;
inspectorObject->setValue(name.string(), WTFMove(inspectorValue));
}
- return RefPtr<JSON::Value> { WTFMove(inspectorObject) };
+ return inspectorObject;
}
ASSERT_NOT_REACHED();
Modified: trunk/Source/_javascript_Core/bytecode/GetterSetterAccessCase.cpp (243696 => 243697)
--- trunk/Source/_javascript_Core/bytecode/GetterSetterAccessCase.cpp 2019-04-01 17:21:46 UTC (rev 243696)
+++ trunk/Source/_javascript_Core/bytecode/GetterSetterAccessCase.cpp 2019-04-01 17:27:53 UTC (rev 243697)
@@ -66,7 +66,7 @@
std::unique_ptr<GetterSetterAccessCase> result(new GetterSetterAccessCase(vm, owner, type, offset, structure, conditionSet, viaProxy, additionalSet, customSlotBase, WTFMove(prototypeAccessChain)));
result->m_domAttribute = domAttribute;
result->m_customAccessor = customGetter ? FunctionPtr<OperationPtrTag>(customGetter) : nullptr;
- return std::unique_ptr<AccessCase> { WTFMove(result) };
+ return result;
}
std::unique_ptr<AccessCase> GetterSetterAccessCase::create(VM& vm, JSCell* owner, AccessType type, Structure* structure, PropertyOffset offset,
@@ -76,7 +76,7 @@
ASSERT(type == Setter || type == CustomValueSetter || type == CustomAccessorSetter);
std::unique_ptr<GetterSetterAccessCase> result(new GetterSetterAccessCase(vm, owner, type, offset, structure, conditionSet, false, nullptr, customSlotBase, WTFMove(prototypeAccessChain)));
result->m_customAccessor = customSetter ? FunctionPtr<OperationPtrTag>(customSetter) : nullptr;
- return std::unique_ptr<AccessCase> { WTFMove(result) };
+ return result;
}
@@ -97,7 +97,7 @@
{
std::unique_ptr<GetterSetterAccessCase> result(new GetterSetterAccessCase(*this));
result->resetState();
- return std::unique_ptr<AccessCase> { WTFMove(result) };
+ return result;
}
bool GetterSetterAccessCase::hasAlternateBase() const
Modified: trunk/Source/_javascript_Core/bytecode/InstanceOfAccessCase.cpp (243696 => 243697)
--- trunk/Source/_javascript_Core/bytecode/InstanceOfAccessCase.cpp 2019-04-01 17:21:46 UTC (rev 243696)
+++ trunk/Source/_javascript_Core/bytecode/InstanceOfAccessCase.cpp 2019-04-01 17:27:53 UTC (rev 243697)
@@ -47,7 +47,7 @@
{
std::unique_ptr<InstanceOfAccessCase> result(new InstanceOfAccessCase(*this));
result->resetState();
- return std::unique_ptr<AccessCase> { WTFMove(result) };
+ return result;
}
InstanceOfAccessCase::~InstanceOfAccessCase()
Modified: trunk/Source/_javascript_Core/bytecode/IntrinsicGetterAccessCase.cpp (243696 => 243697)
--- trunk/Source/_javascript_Core/bytecode/IntrinsicGetterAccessCase.cpp 2019-04-01 17:21:46 UTC (rev 243696)
+++ trunk/Source/_javascript_Core/bytecode/IntrinsicGetterAccessCase.cpp 2019-04-01 17:27:53 UTC (rev 243697)
@@ -51,7 +51,7 @@
{
std::unique_ptr<IntrinsicGetterAccessCase> result(new IntrinsicGetterAccessCase(*this));
result->resetState();
- return std::unique_ptr<AccessCase> { WTFMove(result) };
+ return result;
}
} // namespace JSC
Modified: trunk/Source/_javascript_Core/bytecode/ModuleNamespaceAccessCase.cpp (243696 => 243697)
--- trunk/Source/_javascript_Core/bytecode/ModuleNamespaceAccessCase.cpp 2019-04-01 17:21:46 UTC (rev 243696)
+++ trunk/Source/_javascript_Core/bytecode/ModuleNamespaceAccessCase.cpp 2019-04-01 17:27:53 UTC (rev 243697)
@@ -58,7 +58,7 @@
{
std::unique_ptr<ModuleNamespaceAccessCase> result(new ModuleNamespaceAccessCase(*this));
result->resetState();
- return std::unique_ptr<AccessCase> { WTFMove(result) };
+ return result;
}
void ModuleNamespaceAccessCase::emit(AccessGenerationState& state, MacroAssembler::JumpList& fallThrough)
Modified: trunk/Source/_javascript_Core/bytecode/ProxyableAccessCase.cpp (243696 => 243697)
--- trunk/Source/_javascript_Core/bytecode/ProxyableAccessCase.cpp 2019-04-01 17:21:46 UTC (rev 243696)
+++ trunk/Source/_javascript_Core/bytecode/ProxyableAccessCase.cpp 2019-04-01 17:27:53 UTC (rev 243697)
@@ -52,7 +52,7 @@
{
std::unique_ptr<ProxyableAccessCase> result(new ProxyableAccessCase(*this));
result->resetState();
- return std::unique_ptr<AccessCase> { WTFMove(result) };
+ return result;
}
void ProxyableAccessCase::dumpImpl(PrintStream& out, CommaPrinter& comma) const
Modified: trunk/Source/WTF/ChangeLog (243696 => 243697)
--- trunk/Source/WTF/ChangeLog 2019-04-01 17:21:46 UTC (rev 243696)
+++ trunk/Source/WTF/ChangeLog 2019-04-01 17:27:53 UTC (rev 243697)
@@ -1,3 +1,20 @@
+2019-04-01 Michael Catanzaro <[email protected]>
+
+ Stop trying to support building JSC with clang 3.8
+ https://bugs.webkit.org/show_bug.cgi?id=195947
+ <rdar://problem/49069219>
+
+ Reviewed by Darin Adler.
+
+ It seems WebKit hasn't built with clang 3.8 in a while, no devs are using this compiler, we
+ don't know how much effort it would be to make JSC work again, and it's making the code
+ worse. Remove my hacks to support clang 3.8 from WTF.
+
+ * wtf/MetaAllocator.cpp:
+ (WTF::MetaAllocator::allocate):
+ * wtf/text/StringConcatenate.h:
+ (WTF::tryMakeStringFromAdapters):
+
2019-03-31 Yusuke Suzuki <[email protected]>
[JSC] Butterfly allocation from LargeAllocation should try "realloc" behavior if collector thread is not active
Modified: trunk/Source/WTF/wtf/MetaAllocator.cpp (243696 => 243697)
--- trunk/Source/WTF/wtf/MetaAllocator.cpp 2019-04-01 17:21:46 UTC (rev 243696)
+++ trunk/Source/WTF/wtf/MetaAllocator.cpp 2019-04-01 17:27:53 UTC (rev 243697)
@@ -194,7 +194,7 @@
if (UNLIKELY(!!m_tracker))
m_tracker->notify(handle.ptr());
- return RefPtr<MetaAllocatorHandle> { WTFMove(handle) };
+ return handle;
}
MetaAllocator::Statistics MetaAllocator::currentStatistics()
Modified: trunk/Source/WTF/wtf/text/StringConcatenate.h (243696 => 243697)
--- trunk/Source/WTF/wtf/text/StringConcatenate.h 2019-04-01 17:21:46 UTC (rev 243696)
+++ trunk/Source/WTF/wtf/text/StringConcatenate.h 2019-04-01 17:27:53 UTC (rev 243697)
@@ -278,7 +278,7 @@
makeStringAccumulator(buffer, adapter, adapters...);
- return String { WTFMove(resultImpl) };
+ return resultImpl;
}
UChar* buffer;
@@ -288,7 +288,7 @@
makeStringAccumulator(buffer, adapter, adapters...);
- return String { WTFMove(resultImpl) };
+ return resultImpl;
}
template<typename... StringTypes>
