Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (243852 => 243853)
--- trunk/Source/_javascript_Core/ChangeLog 2019-04-04 03:38:01 UTC (rev 243852)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-04-04 03:44:18 UTC (rev 243853)
@@ -1,3 +1,15 @@
+2019-04-03 Ryan Haddad <ryanhad...@apple.com>
+
+ Unreviewed, rolling out r243843.
+
+ Broke CLoop and Windows builds.
+
+ Reverted changeset:
+
+ "[JSC] Add dump feature for RandomizingFuzzerAgent"
+ https://bugs.webkit.org/show_bug.cgi?id=196586
+ https://trac.webkit.org/changeset/243843
+
2019-04-03 Robin Morisset <rmoris...@apple.com>
B3 should use associativity to optimize _expression_ trees
Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (243852 => 243853)
--- trunk/Source/_javascript_Core/runtime/Options.cpp 2019-04-04 03:38:01 UTC (rev 243852)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp 2019-04-04 03:44:18 UTC (rev 243853)
@@ -451,8 +451,7 @@
|| Options::logPhaseTimes()
|| Options::verboseCFA()
|| Options::verboseDFGFailure()
- || Options::verboseFTLFailure()
- || Options::dumpRandomizingFuzzerAgentPredictions())
+ || Options::verboseFTLFailure())
Options::alwaysComputeHash() = true;
if (!Options::useConcurrentGC())
Modified: trunk/Source/_javascript_Core/runtime/Options.h (243852 => 243853)
--- trunk/Source/_javascript_Core/runtime/Options.h 2019-04-04 03:38:01 UTC (rev 243852)
+++ trunk/Source/_javascript_Core/runtime/Options.h 2019-04-04 03:44:18 UTC (rev 243853)
@@ -436,7 +436,6 @@
\
v(bool, useRandomizingFuzzerAgent, false, Normal, nullptr) \
v(unsigned, seedOfRandomizingFuzzerAgent, 1, Normal, nullptr) \
- v(bool, dumpRandomizingFuzzerAgentPredictions, false, Normal, nullptr) \
\
v(bool, logPhaseTimes, false, Normal, nullptr) \
v(double, rareBlockPenalty, 0.001, Normal, nullptr) \
Modified: trunk/Source/_javascript_Core/runtime/RandomizingFuzzerAgent.cpp (243852 => 243853)
--- trunk/Source/_javascript_Core/runtime/RandomizingFuzzerAgent.cpp 2019-04-04 03:38:01 UTC (rev 243852)
+++ trunk/Source/_javascript_Core/runtime/RandomizingFuzzerAgent.cpp 2019-04-04 03:44:18 UTC (rev 243853)
@@ -33,15 +33,13 @@
{
}
-SpeculatedType RandomizingFuzzerAgent::getPrediction(CodeBlock* codeBlock, int bytecodeIndex, SpeculatedType original)
+SpeculatedType RandomizingFuzzerAgent::getPrediction(CodeBlock*, int, SpeculatedType)
{
auto locker = holdLock(m_lock);
uint32_t high = m_random.getUint32();
uint32_t low = m_random.getUint32();
- SpeculatedType generated = static_cast<SpeculatedType>((static_cast<uint64_t>(high) << 32) | low) & SpecFullTop;
- if (Options::dumpRandomizingFuzzerAgentPredictions())
- dataLogLn("getPrediction name:(", codeBlock->inferredName(), "#", codeBlock->hashAsStringIfPossible(), "),bytecodeIndex:(", bytecodeIndex, "),original:(", SpeculationDump(original), "),generated:(", SpeculationDump(generated), ")");
- return generated;
+ uint64_t result = (static_cast<uint64_t>(high) << 32) | low;
+ return static_cast<SpeculatedType>(result) & SpecFullTop;
}
} // namespace JSC
