Title: [243904] trunk/Source/_javascript_Core
- Revision
- 243904
- Author
- [email protected]
- Date
- 2019-04-04 13:54:02 -0700 (Thu, 04 Apr 2019)
Log Message
Unreviewed, rolling out r243898.
https://bugs.webkit.org/show_bug.cgi?id=196624
`#if !ENABLE(C_LOOP) && NUMBER_OF_CALLEE_SAVES_REGISTERS > 0`
does not work well (Requested by yusukesuzuki on #webkit).
Reverted changeset:
"Unreviewed, build fix for CLoop and Windows after r243886"
https://bugs.webkit.org/show_bug.cgi?id=196387
https://trac.webkit.org/changeset/243898
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (243903 => 243904)
--- trunk/Source/_javascript_Core/ChangeLog 2019-04-04 20:53:22 UTC (rev 243903)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-04-04 20:54:02 UTC (rev 243904)
@@ -1,3 +1,17 @@
+2019-04-04 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r243898.
+ https://bugs.webkit.org/show_bug.cgi?id=196624
+
+ `#if !ENABLE(C_LOOP) && NUMBER_OF_CALLEE_SAVES_REGISTERS > 0`
+ does not work well (Requested by yusukesuzuki on #webkit).
+
+ Reverted changeset:
+
+ "Unreviewed, build fix for CLoop and Windows after r243886"
+ https://bugs.webkit.org/show_bug.cgi?id=196387
+ https://trac.webkit.org/changeset/243898
+
2019-04-04 Yusuke Suzuki <[email protected]>
Unreviewed, build fix for CLoop and Windows after r243886
Modified: trunk/Source/_javascript_Core/interpreter/StackVisitor.cpp (243903 => 243904)
--- trunk/Source/_javascript_Core/interpreter/StackVisitor.cpp 2019-04-04 20:53:22 UTC (rev 243903)
+++ trunk/Source/_javascript_Core/interpreter/StackVisitor.cpp 2019-04-04 20:54:02 UTC (rev 243904)
@@ -253,12 +253,13 @@
return CodeType::Global;
}
-#if !ENABLE(C_LOOP) && NUMBER_OF_CALLEE_SAVES_REGISTERS > 0
Optional<RegisterAtOffsetList> StackVisitor::Frame::calleeSaveRegistersForUnwinding()
{
if (isInlinedFrame())
return WTF::nullopt;
+#if !ENABLE(C_LOOP) && NUMBER_OF_CALLEE_SAVES_REGISTERS > 0
+
#if ENABLE(WEBASSEMBLY)
if (isWasmFrame()) {
if (callee().isCell()) {
@@ -278,9 +279,10 @@
if (CodeBlock* codeBlock = this->codeBlock())
return *codeBlock->calleeSaveRegisters();
+#endif // !ENABLE(C_LOOP) && NUMBER_OF_CALLEE_SAVES_REGISTERS > 0
+
return WTF::nullopt;
}
-#endif // !ENABLE(C_LOOP) && NUMBER_OF_CALLEE_SAVES_REGISTERS > 0
String StackVisitor::Frame::functionName() const
{
Modified: trunk/Source/_javascript_Core/interpreter/StackVisitor.h (243903 => 243904)
--- trunk/Source/_javascript_Core/interpreter/StackVisitor.h 2019-04-04 20:53:22 UTC (rev 243903)
+++ trunk/Source/_javascript_Core/interpreter/StackVisitor.h 2019-04-04 20:54:02 UTC (rev 243904)
@@ -94,9 +94,7 @@
bool hasLineAndColumnInfo() const;
JS_EXPORT_PRIVATE void computeLineAndColumn(unsigned& line, unsigned& column) const;
-#if !ENABLE(C_LOOP) && NUMBER_OF_CALLEE_SAVES_REGISTERS > 0
Optional<RegisterAtOffsetList> calleeSaveRegistersForUnwinding();
-#endif // !ENABLE(C_LOOP) && NUMBER_OF_CALLEE_SAVES_REGISTERS > 0
ClonedArguments* createArguments();
CallFrame* callFrame() const { return m_callFrame; }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
