Title: [243913] trunk/Tools
Revision
243913
Author
aakash_j...@apple.com
Date
2019-04-04 15:42:43 -0700 (Thu, 04 Apr 2019)

Log Message

[ews-app] Status-bubble steps are sometimes displayed in reverse order
https://bugs.webkit.org/show_bug.cgi?id=196625

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._steps_messages): Explicitly specify order_by('uid').

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (243912 => 243913)


--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py	2019-04-04 22:11:46 UTC (rev 243912)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py	2019-04-04 22:42:43 UTC (rev 243913)
@@ -122,7 +122,7 @@
         return '[[' + datetime.datetime.fromtimestamp(time).isoformat() + 'Z]]'
 
     def _steps_messages(self, build):
-        return '\n'.join([step.state_string for step in build.step_set.all() if self._should_display_step(step)])
+        return '\n'.join([step.state_string for step in build.step_set.all().order_by('uid') if self._should_display_step(step)])
 
     def _should_display_step(self, step):
         return not filter(lambda step_to_hide: re.search(step_to_hide, step.state_string), StatusBubble.STEPS_TO_HIDE)

Modified: trunk/Tools/ChangeLog (243912 => 243913)


--- trunk/Tools/ChangeLog	2019-04-04 22:11:46 UTC (rev 243912)
+++ trunk/Tools/ChangeLog	2019-04-04 22:42:43 UTC (rev 243913)
@@ -1,5 +1,15 @@
 2019-04-04  Aakash Jain  <aakash_j...@apple.com>
 
+        [ews-app] Status-bubble steps are sometimes displayed in reverse order
+        https://bugs.webkit.org/show_bug.cgi?id=196625
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble._steps_messages): Explicitly specify order_by('uid').
+
+2019-04-04  Aakash Jain  <aakash_j...@apple.com>
+
         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
         https://bugs.webkit.org/show_bug.cgi?id=196630
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to