Title: [243916] trunk/Source/WebKit
Revision
243916
Author
ryanhad...@apple.com
Date
2019-04-04 15:51:24 -0700 (Thu, 04 Apr 2019)

Log Message

Unreviewed, rolling out r243888.

Introduced layout test crashes.

Reverted changeset:

"[macOS][iOS] Add filter to syscall sandbox rule"
https://bugs.webkit.org/show_bug.cgi?id=196613
https://trac.webkit.org/changeset/243888

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (243915 => 243916)


--- trunk/Source/WebKit/ChangeLog	2019-04-04 22:47:15 UTC (rev 243915)
+++ trunk/Source/WebKit/ChangeLog	2019-04-04 22:51:24 UTC (rev 243916)
@@ -1,3 +1,15 @@
+2019-04-04  Ryan Haddad  <ryanhad...@apple.com>
+
+        Unreviewed, rolling out r243888.
+
+        Introduced layout test crashes.
+
+        Reverted changeset:
+
+        "[macOS][iOS] Add filter to syscall sandbox rule"
+        https://bugs.webkit.org/show_bug.cgi?id=196613
+        https://trac.webkit.org/changeset/243888
+
 2019-04-04  Youenn Fablet  <you...@apple.com>
 
         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters

Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (243915 => 243916)


--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2019-04-04 22:47:15 UTC (rev 243915)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2019-04-04 22:51:24 UTC (rev 243916)
@@ -600,8 +600,6 @@
         (syscall-number SYS_open_dprotected_np)
         (syscall-number SYS_pread_nocancel)
         (syscall-number SYS___semwait_signal_nocancel)
+        (syscall-number SYS_kdebug_trace_string) ;; Needed for performance sampling, see <rdar://problem/48829655>.
     )
-    (with-filter (system-attribute apple-internal)
-        (allow syscall-unix (syscall-number SYS_kdebug_trace_string)) ;; <rdar://problem/49531420>
-    )
 )

Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (243915 => 243916)


--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-04-04 22:47:15 UTC (rev 243915)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-04-04 22:51:24 UTC (rev 243916)
@@ -964,10 +964,8 @@
         (syscall-number SYS_kdebug_typefilter)
         (syscall-number SYS_gettid) ;; Needed for base system, see <rdar://problem/48651255>
         (syscall-number SYS_memorystatus_control) ;; Needed for memory measurement infrastructure, see <rdar://problem/48647263>
+        (syscall-number SYS_kdebug_trace_string) ;; Needed for performance sampling, see <rdar://problem/48829655>.
         (syscall-number SYS_psynch_rw_rdlock) ;; <rdar://problem/49060359>
     )
-    (with-filter (system-attribute apple-internal)
-        (allow syscall-unix (syscall-number SYS_kdebug_trace_string)) ;; <rdar://problem/49531420>
-    )
 )
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to