Title: [243918] trunk/Source/_javascript_Core
- Revision
- 243918
- Author
- [email protected]
- Date
- 2019-04-04 17:08:31 -0700 (Thu, 04 Apr 2019)
Log Message
B3ReduceStrength should know that Mul distributes over Add and Sub
https://bugs.webkit.org/show_bug.cgi?id=196325
<rdar://problem/49441650>
Reviewed by Saam Barati.
Fix some obviously wrong code that was due to an accidental copy-paste.
It made the entire optimization dead code that never ran.
* b3/B3ReduceStrength.cpp:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (243917 => 243918)
--- trunk/Source/_javascript_Core/ChangeLog 2019-04-04 23:14:50 UTC (rev 243917)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-04-05 00:08:31 UTC (rev 243918)
@@ -1,3 +1,16 @@
+2019-04-04 Robin Morisset <[email protected]>
+
+ B3ReduceStrength should know that Mul distributes over Add and Sub
+ https://bugs.webkit.org/show_bug.cgi?id=196325
+ <rdar://problem/49441650>
+
+ Reviewed by Saam Barati.
+
+ Fix some obviously wrong code that was due to an accidental copy-paste.
+ It made the entire optimization dead code that never ran.
+
+ * b3/B3ReduceStrength.cpp:
+
2019-04-04 Saam Barati <[email protected]>
Unreviewed, build fix for CLoop after r243886
Modified: trunk/Source/_javascript_Core/b3/B3ReduceStrength.cpp (243917 => 243918)
--- trunk/Source/_javascript_Core/b3/B3ReduceStrength.cpp 2019-04-04 23:14:50 UTC (rev 243917)
+++ trunk/Source/_javascript_Core/b3/B3ReduceStrength.cpp 2019-04-05 00:08:31 UTC (rev 243918)
@@ -2345,9 +2345,6 @@
Value* x2 = nullptr;
Value* x3 = nullptr;
if (m_value->child(0)->opcode() == Mul && m_value->child(1)->opcode() == Mul) {
- Value* x1 = nullptr;
- Value* x2 = nullptr;
- Value* x3 = nullptr;
if (m_value->child(0)->child(0) == m_value->child(1)->child(0)) {
// Op(Mul(x1, x2), Mul(x1, x3))
x1 = m_value->child(0)->child(0);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
