Title: [243923] trunk/Source/WebCore
- Revision
- 243923
- Author
- [email protected]
- Date
- 2019-04-04 18:09:44 -0700 (Thu, 04 Apr 2019)
Log Message
Element::isFocusable() debug asserts too frequently
https://bugs.webkit.org/show_bug.cgi?id=196634
Reviewed by Geoffrey Garen.
Remove the debug assertion for now.
* dom/Element.cpp:
(WebCore::Element::isFocusable const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (243922 => 243923)
--- trunk/Source/WebCore/ChangeLog 2019-04-05 00:49:40 UTC (rev 243922)
+++ trunk/Source/WebCore/ChangeLog 2019-04-05 01:09:44 UTC (rev 243923)
@@ -1,3 +1,15 @@
+2019-04-04 Ryosuke Niwa <[email protected]>
+
+ Element::isFocusable() debug asserts too frequently
+ https://bugs.webkit.org/show_bug.cgi?id=196634
+
+ Reviewed by Geoffrey Garen.
+
+ Remove the debug assertion for now.
+
+ * dom/Element.cpp:
+ (WebCore::Element::isFocusable const):
+
2019-04-04 Simon Fraser <[email protected]>
Have ScrollableArea store a ScrollType for the current scroll
Modified: trunk/Source/WebCore/dom/Element.cpp (243922 => 243923)
--- trunk/Source/WebCore/dom/Element.cpp 2019-04-05 00:49:40 UTC (rev 243922)
+++ trunk/Source/WebCore/dom/Element.cpp 2019-04-05 01:09:44 UTC (rev 243923)
@@ -553,7 +553,8 @@
if (!renderer()) {
// If the node is in a display:none tree it might say it needs style recalc but
// the whole document is actually up to date.
- ASSERT(!needsStyleRecalc() || !document().childNeedsStyleRecalc());
+ // FIXME: We should be able to assert !needsStyleRecalc() || !document().childNeedsStyleRecalc()
+ // but it hits too frequently on websites like Gmail and Microsoft Exchange.
// Elements in canvas fallback content are not rendered, but they are allowed to be
// focusable as long as their canvas is displayed and visible.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
